From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#24842: 24.5; `help-make-xrefs': False link-type determinations Date: Sun, 5 Feb 2017 11:27:10 -0800 (PST) Message-ID: References: <919e40a4-f6c4-492d-b50f-b0671e13cb60@default> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1486322891 894 195.159.176.226 (5 Feb 2017 19:28:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 5 Feb 2017 19:28:11 +0000 (UTC) To: 24842@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Feb 05 20:28:08 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1caSTn-0008Tj-Jd for geb-bug-gnu-emacs@m.gmane.org; Sun, 05 Feb 2017 20:28:07 +0100 Original-Received: from localhost ([::1]:44216 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1caSTt-0007i4-2e for geb-bug-gnu-emacs@m.gmane.org; Sun, 05 Feb 2017 14:28:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34515) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1caSTl-0007hy-Uz for bug-gnu-emacs@gnu.org; Sun, 05 Feb 2017 14:28:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1caSTi-00048R-Pc for bug-gnu-emacs@gnu.org; Sun, 05 Feb 2017 14:28:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:58714) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1caSTi-00048C-Mb for bug-gnu-emacs@gnu.org; Sun, 05 Feb 2017 14:28:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1caSTh-0001TN-T9 for bug-gnu-emacs@gnu.org; Sun, 05 Feb 2017 14:28:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Feb 2017 19:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24842 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24842-submit@debbugs.gnu.org id=B24842.14863228415613 (code B ref 24842); Sun, 05 Feb 2017 19:28:01 +0000 Original-Received: (at 24842) by debbugs.gnu.org; 5 Feb 2017 19:27:21 +0000 Original-Received: from localhost ([127.0.0.1]:56913 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1caST3-0001ST-5S for submit@debbugs.gnu.org; Sun, 05 Feb 2017 14:27:21 -0500 Original-Received: from aserp1040.oracle.com ([141.146.126.69]:38327) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1caST2-0001SG-1C for 24842@debbugs.gnu.org; Sun, 05 Feb 2017 14:27:20 -0500 Original-Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id v15JRDub028191 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for <24842@debbugs.gnu.org>; Sun, 5 Feb 2017 19:27:13 GMT Original-Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id v15JRD8l017574 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for <24842@debbugs.gnu.org>; Sun, 5 Feb 2017 19:27:13 GMT Original-Received: from abhmp0004.oracle.com (abhmp0004.oracle.com [141.146.116.10]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id v15JRB0C006232 for <24842@debbugs.gnu.org>; Sun, 5 Feb 2017 19:27:12 GMT In-Reply-To: <919e40a4-f6c4-492d-b50f-b0671e13cb60@default> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 12.0.6753.5000 (x86)] X-Source-IP: userv0021.oracle.com [156.151.31.71] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:129001 Archived-At: > 1. One possible approach is to improve the behavior. I have not tested > this generally, but changing the `cond' clauses to include the test > for type and for documentation as part of the `cond' test, instead of > being part of the result clause after the test, fixes at least the > immediate problem of the above example. >=20 > For example, instead of: >=20 > ((match-string 4) ; `function' &c > (and (fboundp sym) ; similarly > (help-xref-button 8 'help-function sym))) >=20 > use this: >=20 > ((and (match-string 4) ; `function' &c > (fboundp sym)) ; similarly > (help-xref-button 8 'help-function sym)) >=20 > Similarly for the other clauses. >=20 > Possibly this does not DTRT generally, since it lets subsequent > `cond' clauses get tested if the code cannot determine that the > symbol is a variable, function, etc. >=20 > But that's the point of those clauses. If they cannot find that some > symbol is a variable, etc., then shouldn't the subsequent clauses be > tried? (The tests might need to be improved. Dunno.) >=20 > Again, I have not tested this, so I don't propose an exact code fix. > I'm reporting the bug. I've been using this for a while, and it seems to be an improvement. I have not noticed any bad cases. Can you please consider making this change? I think the logic is better. Or can you point to a case where it is not an improvement? Thx.