* w32 image-dired and Image Magick's `convert' and `display' with image-dired-thumbnail-display-external, image-dired-dired-display-external
@ 2009-05-13 20:04 MON KEY
2009-05-13 20:29 ` MON KEY
0 siblings, 1 reply; 2+ messages in thread
From: MON KEY @ 2009-05-13 20:04 UTC (permalink / raw)
To: emacs-devel
There seem to be some little w32 related quirks in image-dired.el
around `image-dired-thumbnail-display-external' and
`image-dired-dired-display-external'
When the Image Magick executable name is set as `display.exe' I'm getting:
"Image Magick Exception
display.exe:
Unable to open X server
`'display.c/DisplayImageCond/418 [No such file or dir]."
After setting the image-dired-external-viewer executable name to
`imdisplay.exe' (per the Image Magick installation instructions for
w32) _this_ problem goes away.
However, the var does not play nice with the system cmd shell and the
w32 path with whitespace, e.g.
`c:/Program Files/{...}/image-manipulation-program.exe'
needs to be escaped as:
`c:/\"Program Files\"/{...}/image-manipulation-program.exe'
The conditional in image-dired-external-viewer should do a w32
system-type check _before_ searching for "display" and instead search
for "imdisplay" e.g.
;;; ==============================
*** dired.el~
--- dired.el
***************
*** 1,11 ****
(defcustom image-dired-external-viewer
;; TODO: Use mailcap, dired-guess-shell-alist-default,
;; dired-view-command-alist.
! (cond ((and (eq system-type 'windows-nt)
! (executable-find "imdisplay"))
! (when (string-match "[pP]rogram [fF]iles" image-dired-external-viewer))
! (replace-regexp-in-string "[pP]rogram [fF]iles" "\"Program
Files\"" image-dired-external-viewer))
! ((executable-find "display"))
((executable-find "xli"))
((executable-find "qiv") "qiv -t"))
"Name of external viewer.
--- 1,7 ----
(defcustom image-dired-external-viewer
;; TODO: Use mailcap, dired-guess-shell-alist-default,
;; dired-view-command-alist.
! (cond ((executable-find "display"))
((executable-find "xli"))
((executable-find "qiv") "qiv -t"))
"Name of external viewer.
;;; There may be additonal whitespace checks needed as well - this
catches the most glaring one - on my system at least :).
;;; ==============================
Following customizations might also need to be rexamined:
- `image-dired-cmd-create-thumbnail-program'
When using Image Magick w32 users are encouraged to name `convert.exe'
--> `imconvert.exe'
Emacs should recognize this convention when present.
- `image-dired-cmd-create-standard-thumbnail-command'
When using Image Magick w32 users are encouraged to name `convert.exe'
--> `imconvert.exe'
Again, when present Emacs should recognize convention when present and
set the command to:
`imconvert -size %wx%h "%f" -thumbnail "%wx%h>" png:"%t"'
s_P
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: w32 image-dired and Image Magick's `convert' and `display' with image-dired-thumbnail-display-external, image-dired-dired-display-external
2009-05-13 20:04 w32 image-dired and Image Magick's `convert' and `display' with image-dired-thumbnail-display-external, image-dired-dired-display-external MON KEY
@ 2009-05-13 20:29 ` MON KEY
0 siblings, 0 replies; 2+ messages in thread
From: MON KEY @ 2009-05-13 20:29 UTC (permalink / raw)
To: emacs-devel
Whoops, left out the let form in previous posting.
;;; Revised
;;; ==============================
*** image-dired.el*
--- image-dired.el-
***************
*** 1,12 ****
(defcustom image-dired-external-viewer
;; TODO: Use mailcap, dired-guess-shell-alist-default,
;; dired-view-command-alist.
! (cond ((and (eq system-type 'windows-nt)
! (executable-find "imdisplay"))
! (let ((rp (executable-find "imdisplay")))
! (when (string-match "[pP]rogram [fF]iles" rp))
! (replace-regexp-in-string "[pP]rogram [fF]iles" "\"Program Files\"" rp)))
! ((executable-find "display"))
((executable-find "xli"))
((executable-find "qiv") "qiv -t"))
"Name of external viewer.")
--- 1,7 ----
(defcustom image-dired-external-viewer
;; TODO: Use mailcap, dired-guess-shell-alist-default,
;; dired-view-command-alist.
! (cond ((executable-find "display"))
((executable-find "xli"))
((executable-find "qiv") "qiv -t"))
"Name of external viewer.")
;;; ==============================
s_P
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-05-13 20:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-05-13 20:04 w32 image-dired and Image Magick's `convert' and `display' with image-dired-thumbnail-display-external, image-dired-dired-display-external MON KEY
2009-05-13 20:29 ` MON KEY
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.