From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit Date: Wed, 20 Nov 2019 21:40:32 +0200 Message-ID: References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <908fb02e-1091-0dff-2faa-71c3ec721b76@yandex.ru> <83h82z2250.fsf@gnu.org> <448da651-20ac-14ba-6916-98ab3c23c9d1@yandex.ru> <838sob1acp.fsf@gnu.org> <83tv6yzets.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="110749"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, juri@linkov.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 20 20:41:15 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iXVqk-000SgJ-2x for geb-bug-gnu-emacs@m.gmane.org; Wed, 20 Nov 2019 20:41:14 +0100 Original-Received: from localhost ([::1]:33926 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXVqi-0002Vj-Bd for geb-bug-gnu-emacs@m.gmane.org; Wed, 20 Nov 2019 14:41:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49524) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXVqZ-0002SD-AL for bug-gnu-emacs@gnu.org; Wed, 20 Nov 2019 14:41:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iXVqY-0004Fl-48 for bug-gnu-emacs@gnu.org; Wed, 20 Nov 2019 14:41:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42117) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iXVqY-0004Ff-0Y for bug-gnu-emacs@gnu.org; Wed, 20 Nov 2019 14:41:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iXVqX-0007lj-Rf for bug-gnu-emacs@gnu.org; Wed, 20 Nov 2019 14:41:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 20 Nov 2019 19:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38044 X-GNU-PR-Package: emacs Original-Received: via spool by 38044-submit@debbugs.gnu.org id=B38044.157427884429827 (code B ref 38044); Wed, 20 Nov 2019 19:41:01 +0000 Original-Received: (at 38044) by debbugs.gnu.org; 20 Nov 2019 19:40:44 +0000 Original-Received: from localhost ([127.0.0.1]:50938 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXVqG-0007l1-42 for submit@debbugs.gnu.org; Wed, 20 Nov 2019 14:40:44 -0500 Original-Received: from mail-wr1-f48.google.com ([209.85.221.48]:40739) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXVqE-0007ko-4Q for 38044@debbugs.gnu.org; Wed, 20 Nov 2019 14:40:43 -0500 Original-Received: by mail-wr1-f48.google.com with SMTP id q15so1330487wrw.7 for <38044@debbugs.gnu.org>; Wed, 20 Nov 2019 11:40:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=3Pq0YYXCQgDW/1fv8aHcQltc12u6Itf2bLPqrdM28+o=; b=Uke9+vrUH4ZM7PJw92CHWjq9hPLMtmBgZgjm4BfD/U9qV3C85dljWVMK6gIugE56ZR TdrKSpsWrG+VfVzopu+4AUGITopDRcNj7hXq798cxVaUi4FfvL+nSDoqr2ZRjWgLKIoV vjP3qO+29fAi92JvsRu8KFELH0AsU7d1WYxP35Yq5jpJavrUDeWyIE/oOZNerV5BGHt0 cEtlncAfPt9EnK04ktVGQyq1FoPs73Y9VHo+xO7hzVYMh8igpyga12rf6Jiw46Svnf6Q Zg4iM3IDtGxU1ME5pmL6yXHBa5X++dKU61KL8iyJe9Ut4ftg717g/uHoBogPPncZvfM1 fIaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3Pq0YYXCQgDW/1fv8aHcQltc12u6Itf2bLPqrdM28+o=; b=hHukKNQ8j3FClilXzhP+eTNUmVeIMcItcQ8iRh2FBLIwoahRR+V4on1s/y9mOgZ8EW Dt5K2fqx3Jx+6osmJmVzOoAOCV/pZBEO9G9RkRSXJQKw6g8f+l7BAbwPFDVGNPvnQzIA ++spNCkEIGjcPM8GMlXWEz8yM0Zt7Fba/62GVgw/SQohwD40cdFwRvL6chQpaV79Nd9p kEIItzu3vr1/fvjZmnsbbDU6NNfl9JVF+f6LtH9psbPs90mabvFgsHJGvuhDTUcIS03W 6i+bJ16t+6JjcAeMapaSpmMoSiVg7siiY0QTwiRE5f5vqbdEpRK59vsDGmDaQFZW9tTp tuSQ== X-Gm-Message-State: APjAAAVrs57gGrmr4IGvycqW8Gcvvc0IfwtAaLGkJzIo+vuN7hS7o7sN KlHT5ilCuVjRFSTI8/CJLOU= X-Google-Smtp-Source: APXvYqzzvwavVe4xmYlXMIf02ea/qRIowrulwMznGBq1IbrOzibijczsX56RtADoachkeKtGiO1htQ== X-Received: by 2002:adf:fe0e:: with SMTP id n14mr5970753wrr.72.1574278836148; Wed, 20 Nov 2019 11:40:36 -0800 (PST) Original-Received: from [192.168.0.5] ([212.50.117.215]) by smtp.googlemail.com with ESMTPSA id j63sm288475wmj.46.2019.11.20.11.40.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Nov 2019 11:40:34 -0800 (PST) In-Reply-To: <83tv6yzets.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172070 Archived-At: On 20.11.2019 18:34, Eli Zaretskii wrote: >> How would that even work? vc-diff will always delegate to vc-git-diff. > > It will work if we program either vc-diff or vc-git-diff to call "git > show" under some specific circumstances. That makes little sense to me, sorry. >>>> IMO the log message is more important because it describes and justifies >>>> what happened. Showing the diff is good as well. >>> >>> That's not relevant to the issue at hand. Like it or not, VCSes other >>> than Git describe a revision by the diffs alone. >> >> It's 100% relevant, and the fact that certain older VCSes can't do this >> should have no bearing on whether we implement a satisfactory UI in VC >> or not. That's the whole purpose of VC: make interacting with different >> VS systems easier. > > Easier, yes. But also present the results in a familiar enough form. > If users are accustomed to seeing a revision described by diffs, then > this is what they should by default see in VC, IMO. There's nothing unfamiliar about also seeing the author name and the commit message. Also: most of our users are Git users. Hence, users are accustomed to 'git show'. >>>> Maybe the other VCSes don't have a simple command to do the same, but >>>> they can either be called twice, or use special formatting. For >>>> instance, Hg can use this command: >>>> >>>> hg log -r -p >>> >>> IMO, this is over-engineering. If the VCS developers don't see the >>> need to have a commands which shows meta-data together with the diffs, >>> we should not force that on that VCS. >> >> They added the '-p' flag. So apparently they did see the need. > > Then maybe the hg back-end should indeed call "log -r -p", if that's > what hg users are used to (I don't use hg). What I mean is that we > should show a revision like users are accustomed to see it with the > particular back-end; jumping through hoops to produce Git-like display > where users don't really expect it is IMO over-engineering. I disagree. I think the possible arguments are exhausted at this point. Are you going to invoke the privilege of the Emacs maintainer? All I got to say to this is "lisp/vc/*" is near my name in admin/MAINTAINERS. > And I'm also saying that conceptually a revision's description is a > kind of "diff" operation, so it should preferably be a sub-command of > "C-x v =". That's not how I think about it either. Again: I think the metadata is just as important. And we can't get to that metadata from the diff output.