From: Dmitry Gutov <dgutov@yandex.ru>
To: Eli Zaretskii <eliz@gnu.org>
Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org,
juri@linkov.net
Subject: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit
Date: Wed, 20 Nov 2019 21:40:32 +0200 [thread overview]
Message-ID: <d251cca6-ae67-d8bc-22b5-80d63e79eeb4@yandex.ru> (raw)
In-Reply-To: <83tv6yzets.fsf@gnu.org>
On 20.11.2019 18:34, Eli Zaretskii wrote:
>> How would that even work? vc-diff will always delegate to vc-git-diff.
>
> It will work if we program either vc-diff or vc-git-diff to call "git
> show" under some specific circumstances.
That makes little sense to me, sorry.
>>>> IMO the log message is more important because it describes and justifies
>>>> what happened. Showing the diff is good as well.
>>>
>>> That's not relevant to the issue at hand. Like it or not, VCSes other
>>> than Git describe a revision by the diffs alone.
>>
>> It's 100% relevant, and the fact that certain older VCSes can't do this
>> should have no bearing on whether we implement a satisfactory UI in VC
>> or not. That's the whole purpose of VC: make interacting with different
>> VS systems easier.
>
> Easier, yes. But also present the results in a familiar enough form.
> If users are accustomed to seeing a revision described by diffs, then
> this is what they should by default see in VC, IMO.
There's nothing unfamiliar about also seeing the author name and the
commit message.
Also: most of our users are Git users. Hence, users are accustomed to
'git show'.
>>>> Maybe the other VCSes don't have a simple command to do the same, but
>>>> they can either be called twice, or use special formatting. For
>>>> instance, Hg can use this command:
>>>>
>>>> hg log -r <REV> -p
>>>
>>> IMO, this is over-engineering. If the VCS developers don't see the
>>> need to have a commands which shows meta-data together with the diffs,
>>> we should not force that on that VCS.
>>
>> They added the '-p' flag. So apparently they did see the need.
>
> Then maybe the hg back-end should indeed call "log -r -p", if that's
> what hg users are used to (I don't use hg). What I mean is that we
> should show a revision like users are accustomed to see it with the
> particular back-end; jumping through hoops to produce Git-like display
> where users don't really expect it is IMO over-engineering.
I disagree. I think the possible arguments are exhausted at this point.
Are you going to invoke the privilege of the Emacs maintainer? All I got
to say to this is "lisp/vc/*" is near my name in admin/MAINTAINERS.
> And I'm also saying that conceptually a revision's description is a
> kind of "diff" operation, so it should preferably be a sub-command of
> "C-x v =".
That's not how I think about it either. Again: I think the metadata is
just as important. And we can't get to that metadata from the diff output.
next prev parent reply other threads:[~2019-11-20 19:40 UTC|newest]
Thread overview: 98+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-03 15:17 bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit Lars Ingebrigtsen
2019-11-03 15:43 ` Stephen Berman
2019-11-03 20:16 ` Juri Linkov
2019-11-13 21:03 ` Juri Linkov
2019-11-16 20:31 ` Juri Linkov
2019-11-17 11:53 ` Dmitry Gutov
2019-11-17 21:20 ` Juri Linkov
2019-11-17 21:58 ` Dmitry Gutov
2019-11-17 22:36 ` Juri Linkov
2019-11-17 23:19 ` Dmitry Gutov
2019-11-18 21:31 ` Juri Linkov
2019-11-19 3:34 ` Eli Zaretskii
2019-11-19 11:12 ` Dmitry Gutov
2019-11-19 16:12 ` Eli Zaretskii
2019-11-19 16:59 ` Dmitry Gutov
2019-11-19 17:43 ` Eli Zaretskii
2019-11-19 23:17 ` Dmitry Gutov
2019-11-20 3:43 ` Eli Zaretskii
2019-11-20 12:19 ` Dmitry Gutov
2019-11-20 16:34 ` Eli Zaretskii
2019-11-20 19:40 ` Dmitry Gutov [this message]
2019-11-20 19:57 ` Dmitry Gutov
2019-11-20 20:12 ` Eli Zaretskii
2019-11-20 20:07 ` Eli Zaretskii
2019-11-20 11:04 ` Lars Ingebrigtsen
2019-11-21 15:00 ` Eli Zaretskii
2019-11-19 22:20 ` Juri Linkov
2019-11-20 3:44 ` Eli Zaretskii
2019-11-20 21:50 ` Juri Linkov
2019-11-20 23:37 ` Dmitry Gutov
2019-11-21 23:08 ` Juri Linkov
2019-11-22 18:51 ` Dmitry Gutov
2019-11-21 14:59 ` Eli Zaretskii
2019-11-21 15:34 ` Dmitry Gutov
2019-11-21 15:50 ` Dmitry Gutov
2019-11-21 18:33 ` Eli Zaretskii
2019-11-21 19:08 ` Dmitry Gutov
2019-11-21 20:19 ` Eli Zaretskii
2019-11-21 21:05 ` Dmitry Gutov
2019-11-22 7:20 ` Eli Zaretskii
2019-11-22 19:59 ` Dmitry Gutov
2019-11-22 21:03 ` Eli Zaretskii
2019-11-22 21:43 ` Dmitry Gutov
2019-11-22 21:51 ` Eli Zaretskii
2019-11-23 13:59 ` Eli Zaretskii
2019-11-23 18:52 ` Dmitry Gutov
2019-11-21 21:15 ` Stephen Berman
2019-11-22 7:24 ` Eli Zaretskii
2019-11-22 9:25 ` Stephen Berman
2019-11-23 12:13 ` Eli Zaretskii
2019-11-23 13:16 ` Stephen Berman
2019-11-22 11:19 ` Dmitry Gutov
2019-11-22 12:12 ` Lars Ingebrigtsen
2019-11-22 13:04 ` Eli Zaretskii
2019-11-22 16:27 ` Dmitry Gutov
2019-12-01 13:13 ` Stephen Berman
2019-12-01 17:53 ` Eli Zaretskii
2019-12-01 20:43 ` Stephen Berman
2019-12-01 21:29 ` Dmitry Gutov
2019-12-01 21:39 ` Stephen Berman
2019-12-01 22:30 ` Dmitry Gutov
2019-12-02 3:34 ` Eli Zaretskii
2019-12-02 10:39 ` Dmitry Gutov
2019-12-02 11:07 ` Andreas Schwab
2019-12-02 15:58 ` Eli Zaretskii
2019-12-02 16:05 ` Dmitry Gutov
2019-11-23 18:50 ` Juri Linkov
2019-11-23 19:11 ` Dmitry Gutov
2019-11-23 22:43 ` Juri Linkov
2019-11-24 16:05 ` Eli Zaretskii
2019-11-26 23:01 ` Juri Linkov
2019-11-27 5:39 ` Eli Zaretskii
2019-11-27 22:15 ` Juri Linkov
2019-11-25 0:12 ` Dmitry Gutov
2019-11-26 23:06 ` Juri Linkov
2019-11-27 0:09 ` Dmitry Gutov
2019-11-27 5:40 ` Eli Zaretskii
2019-11-27 21:32 ` Juri Linkov
2019-11-28 3:34 ` Eli Zaretskii
2019-11-21 23:13 ` Juri Linkov
2019-11-22 8:03 ` Eli Zaretskii
2019-11-22 11:20 ` Dmitry Gutov
2019-11-22 13:06 ` Eli Zaretskii
2019-11-22 16:26 ` Dmitry Gutov
2019-11-22 16:38 ` Eli Zaretskii
2019-11-21 22:36 ` Andrii Kolomoiets
2019-11-22 7:40 ` Eli Zaretskii
2020-07-19 15:31 ` Lars Ingebrigtsen
2020-07-19 17:14 ` Dmitry Gutov
2020-07-19 17:16 ` Lars Ingebrigtsen
2020-07-19 19:43 ` Dmitry Gutov
2020-07-19 19:51 ` Lars Ingebrigtsen
2020-07-20 20:56 ` Dmitry Gutov
2020-07-21 21:44 ` Lars Ingebrigtsen
2020-07-22 15:36 ` Dmitry Gutov
2020-07-22 16:14 ` Dmitry Gutov
2020-07-22 16:25 ` Eli Zaretskii
2020-07-22 16:38 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d251cca6-ae67-d8bc-22b5-80d63e79eeb4@yandex.ru \
--to=dgutov@yandex.ru \
--cc=38044@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=juri@linkov.net \
--cc=larsi@gnus.org \
--cc=stephen.berman@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.