From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#51215: Add a navigation feature to vc and diff mode: diff-goto-line Date: Tue, 19 Oct 2021 03:49:13 +0300 Message-ID: References: <87k0ifpcc2.fsf@mat.ucm.es> <9618968c-f3f4-da4f-4dba-e34a88036ced@yandex.ru> <87k0iag5vr.fsf@mat.ucm.es> <87ee8ig5ib.fsf@mat.ucm.es> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6922"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 To: 51215@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 19 02:50:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mcdKV-0001gb-Cy for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 Oct 2021 02:50:11 +0200 Original-Received: from localhost ([::1]:34902 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mcdKU-0002xB-2L for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 18 Oct 2021 20:50:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50580) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mcdKM-0002wn-2L for bug-gnu-emacs@gnu.org; Mon, 18 Oct 2021 20:50:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37348) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mcdKL-0002b9-Op for bug-gnu-emacs@gnu.org; Mon, 18 Oct 2021 20:50:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mcdKL-0007Zn-Ke for bug-gnu-emacs@gnu.org; Mon, 18 Oct 2021 20:50:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Oct 2021 00:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51215 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.163460456129070 (code B ref -1); Tue, 19 Oct 2021 00:50:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 19 Oct 2021 00:49:21 +0000 Original-Received: from localhost ([127.0.0.1]:48894 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mcdJh-0007Ym-DU for submit@debbugs.gnu.org; Mon, 18 Oct 2021 20:49:21 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:38224) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mcdJf-0007Yd-6c for submit@debbugs.gnu.org; Mon, 18 Oct 2021 20:49:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50256) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mcdJe-0002rh-VJ for bug-gnu-emacs@gnu.org; Mon, 18 Oct 2021 20:49:18 -0400 Original-Received: from mail-lf1-x132.google.com ([2a00:1450:4864:20::132]:43941) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mcdJd-0001cB-65 for bug-gnu-emacs@gnu.org; Mon, 18 Oct 2021 20:49:18 -0400 Original-Received: by mail-lf1-x132.google.com with SMTP id r19so3524966lfe.10 for ; Mon, 18 Oct 2021 17:49:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=j5a7gQ1N/nZzh6tS6nARxcXHd3/uNueQe3+iftVmdNs=; b=RvOKy4Rr4ZwjyLw59/h7wgccxwGafa3xXgcuPEMGT5WAs0Wwdq4zsL5qxM80XxEILB 9v6ZPm2jcIqoAUJnwzjK9DbBiDgNA130JvA+LBSF3evzcVffaSEYaDSs5XbqCUOIJQlA ZLrSIX71sUxTrDXvjga/i28us++VV53EJlQ8x2hS0D+aq70FO+Oc6s1TCQYu/q1q/ntr QH1hmphyRL8ZPq/U9qvoL6zba2+E8JtSx2fMFIOSV0J/X5J4WOm5Xox4snru/J20w0cP NFAMMA2ifYCniWwLCnY3sIDVEPF7BqdTHGkM6lQbbf3gv2ORQJNVPEPprmhQznySBmvg 7NBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=j5a7gQ1N/nZzh6tS6nARxcXHd3/uNueQe3+iftVmdNs=; b=rebBeGfmEzgNS7Xzu3LOQLRaCiFcORhOrJKeKQhbgKSRNi4I8MhKT2R3OiQ6MKYtru AL9JdPaVoK4MWimtzAJ1RxwJ5PC/nmWFSF2y5V9vMbx7nSQzqI4V6/YIuzQKtQY2LZeb ajJ9YnrTnXgDEo3o0elqAycJrLvYLiC7S5K9wLHQhqXRkkxlbsdDFdhi3QbgW/D59F2Z TFo4qev0fnVZC8fTWqRjxmDAiQ1Xr7ceJQjV0HENZgsoI3yjrv53371Uf++ZdmeB5VUW ffpvx/GLiPQLOaix0wRYsRAHvp55+hhBI7si0q8Fz1R6kb2eldRLx86YnnIkMktvYOlj OMBA== X-Gm-Message-State: AOAM532hS218p2Usi2BFLolbaF4/UMDcTOt3oHHMYReiRjhAFnD6+fFq GsuWN71EDiOHBWetCcEzgX2KV7af2/8= X-Google-Smtp-Source: ABdhPJxZZIFvvO9WEKFVAwoI791NJjIO8EYT4N4ABLxiXbUY49TYNWVVRaVykOBSh8BYu/TDgAvytQ== X-Received: by 2002:a05:6512:13a5:: with SMTP id p37mr2992973lfa.403.1634604554740; Mon, 18 Oct 2021 17:49:14 -0700 (PDT) Original-Received: from [192.168.0.103] ([5.18.248.29]) by smtp.googlemail.com with ESMTPSA id n12sm1789257ljh.55.2021.10.18.17.49.13 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Oct 2021 17:49:14 -0700 (PDT) In-Reply-To: <87ee8ig5ib.fsf@mat.ucm.es> Content-Language: en-US Received-SPF: pass client-ip=2a00:1450:4864:20::132; envelope-from=raaahh@gmail.com; helo=mail-lf1-x132.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:217530 Archived-At: On 18.10.2021 10:24, Uwe Brauer wrote: >> Hi Dmitry > >> Thanks for answering and clarify some points > >> I am not that used to that interface I jumped to >> https://lists.gnu.org/archive/html/emacs-bug-tracker/2020-08/msg00633.html > To answer my own question: > > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=%2336526 > > Is a different patch than the one I committed. Mine (=Davis) does not > touch the vc-root-diff command it is on a strict one-file base and > therefore simpler. > > Why not apply «mine» and if there is sufficient interest switch to > 2336526? Read further down, we've discussed (unfortunately briefly) Davis's patch closer to the end: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=36526#53 I don't object to applying it, but like I said, it needs someone to champion it, do a proper review. I don't have the time or interest at the moment.