bug#48770: Command `eshell-command` raises error when `eshell-hist-ignoredups` is 'erase

bug#48770: Command `eshell-command` raises error when `eshell-hist-ignoredups` is 'erase

[Okam via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Hello,

This raises the "Ring empty" error because there is no history in
`eshell-history-ring` when I use this command. This command doesn't seem
to be aware of the input history of other Eshell buffers.

Thank you.

bug#48770: Command `eshell-command` raises error when `eshell-hist-ignoredups` is 'erase

[Lars Ingebrigtsen]

Okam <okamsn@protonmail.com> writes:

> This raises the "Ring empty" error because there is no history in
> `eshell-history-ring` when I use this command. This command doesn't seem
> to be aware of the input history of other Eshell buffers.

I'm not quite sure I understand.  I tried `M-x eshell-command' with that
setting, and I got no error in Emacs 28.

What Emacs version is this with?

Do you have a step-by-step recipe to reproduce the problem, starting
from "emacs -Q"?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#48770: Command `eshell-command` raises error when `eshell-hist-ignoredups` is 'erase

[Okam via Bug reports for GNU Emacs, the Swiss army knife of text editors]

On 6/1/21 11:48 AM, Lars Ingebrigtsen wrote:
 > What Emacs version is this with?

This is from the master branch with with repository version
0c7f1e2e42d6bf9f95e88c02d4e1ed9cb40693d8, as determined by
`emacs-repository-version`.

I also tried pulling and compiling from the master branch with
repository version 09081ca119c3debcc72159a46d3bafabfd7519bb.  The error
is still raised.

This is with native compilation enabled, if that changes things.

 > Do you have a step-by-step recipe to reproduce the problem, starting
 > from "emacs -Q"?

1. Start Emacs with `emacs -Q`
2. Evaluate `(setq eshell-hist-ignoredups 'erase)`
3. Run `M-x eshell-command`
4. Run a command, such as `ls`.
5. The error "ring-remove: Ring empty" is signaled.
6. The directory listing is not created.

The value of `eshell-history-ring` during this is

(0 0 .
    [nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil
nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil
nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil
nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil
nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil
nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil
nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil
nil nil nil])

Does any of this information help?

bug#48770: Command `eshell-command` raises error when `eshell-hist-ignoredups` is 'erase

[Lars Ingebrigtsen]

Okam <okamsn@protonmail.com> writes:

> 1. Start Emacs with `emacs -Q`
> 2. Evaluate `(setq eshell-hist-ignoredups 'erase)`
> 3. Run `M-x eshell-command`
> 4. Run a command, such as `ls`.
> 5. The error "ring-remove: Ring empty" is signaled.
> 6. The directory listing is not created.

Thanks for the clear recipe.  With that, I was able to reproduce the
problem, and I've now pushed a fix to Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no