From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: amk@amk.ie Newsgroups: gmane.emacs.devel Subject: Re: About SASL authentication in rcirc Date: Mon, 28 Jun 2021 12:46:01 +0000 Message-ID: References: <87h7hijlmz.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="--=_RainLoop_261_976796198.1624884361" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6172"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "Philip Kaludercic" To: "Tassilo Horn" , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jun 28 16:22:12 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lxs9L-0001SO-FK for ged-emacs-devel@m.gmane-mx.org; Mon, 28 Jun 2021 16:22:11 +0200 Original-Received: from localhost ([::1]:59350 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lxs9K-0005RP-CO for ged-emacs-devel@m.gmane-mx.org; Mon, 28 Jun 2021 10:22:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60054) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lxqeS-00026k-F3 for emacs-devel@gnu.org; Mon, 28 Jun 2021 08:46:13 -0400 Original-Received: from out1.migadu.com ([91.121.223.63]:30100) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lxqeN-0007vE-Kb; Mon, 28 Jun 2021 08:46:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amk.ie; s=key1; t=1624884362; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=O1NJmxyvxEebG897xsI1S4ENGFPJAQ0E4NKhHm1wpRA=; b=tcP6Z88DHSeLTMY6NdmzKul5u28jc8uhElq/xMHfxW/a91Ee+Q6iQ6ao1XniqMJt2rIJ0M YJ2SWHUb/G0Jw74zu/HU74NateR9g6KcdFUrAV/GwLWqkp2WzzN1Gl73f5aZo7JhRfyZUI yjKzobckpMbThLY9Phiasv8gRlXdUP/SisbnF3q/pxvSTmDvKxd53TwLFk1duHLnQcZEJn 10gDMncSOWF5nLPnJglYKwPd9dJzglzHyCdNzEem7lXy0DKiXTbbn7VOlMU/Jnrav5Z+dk +5wIqszvOV9eWiyCAddlKMSReRLU8gJ9+04yp0Wzyfv4mUFD/5Y+l4TQSCq8rQ== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-Reply-To: <87h7hijlmz.fsf@gnu.org> X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: amk@amk.ie Received-SPF: pass client-ip=91.121.223.63; envelope-from=amk@amk.ie; helo=out1.migadu.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Mon, 28 Jun 2021 10:17:22 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:271067 Archived-At: ----=_RainLoop_261_976796198.1624884361 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable June 28, 2021 11:36 AM, "Tassilo Horn" wrote:=0A=0A> Hi Al= ex,=0A> =0A> thanks for bringing SASL authentication to rcirc. I'm using = the=0A> rcirc-update branch of Philip for my IRC needs where Philip has= =0A> cherry-picked your commit implementing SASL authentication for rcirc= .=0A> So obviously I wanted to try that out and changed my=0A> =0A> --8<-= --------------cut here---------------start------------->8---=0A> (setq rc= irc-authinfo=0A> `(("libera" nickserv "tsdh" ,th/nickserv-password-libera= chat)))=0A> --8<---------------cut here---------------end--------------->= 8---=0A> =0A> to=0A> =0A> --8<---------------cut here---------------start= ------------->8---=0A> (setq rcirc-authinfo=0A> `(("libera" sasl "tsdh" ,= th/nickserv-password-liberachat)))=0A> --8<---------------cut here-------= --------end--------------->8---=0A> =0A> and restarted my rcirc session a= fter rebuilding emacs.=0A> =0A> After that, the *irc.libera.chat* buffer = contained a message that tsdh=0A> is a registered nick but not the messag= e afterwards that I'm=0A> successfully registered now (as it is the case = with nickserv=0A> authentication). And when querying NickServ, it told me= that I'm not=0A> logged it.=0A> =0A> If I understand SASL/IRC correctly,= it should have logged in immediately=0A> on connecting, right?=0A> =0A> = So apparently, it seems that it didn't work when I've tried. I'd be=0A> h= appy to debug where it fails if you give me some pointers what to look=0A= > for.=0A> =0A> Bye,=0A> Tassilo=0A=0AHey, =0A=0ACorrect, It should authe= nticate automatically=0A=0AI think the issue is that some of the original= sasl commit got lost in=0Acherry picking. I've attached a patch that fix= es it, I'm not sure if=0Athere is a better place to send a patch to a bra= nch.=0A=0AWith this patch rcirc now checks that sasl authentication has c= ompleted=0Abefore running CAP END as specified here =0Ahttps://ircv3.net/= specs/extensions/sasl-3.1=0A=0AThanks,=0AAlex ----=_RainLoop_261_976796198.1624884361 Content-Type: application/octet-stream; name="0001-Fix-SASL-on-rcirc-update.patch" Content-Disposition: attachment; filename="0001-Fix-SASL-on-rcirc-update.patch" Content-Transfer-Encoding: base64 RnJvbSBiODZmOWYwMjJhY2Y2MzBkYmViNGNkM2NiZWFmMjIyMTJlMWQ4ZWVkIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBBbGV4IE1jR3JhdGggPGFsZXhtY2dyYWFrQGFyaXN0 YS5jb20+CkRhdGU6IE1vbiwgMjggSnVuIDIwMjEgMTM6NDE6MzEgKzAxMDAKU3ViamVjdDog W1BBVENIXSBGaXggU0FTTCBvbiByY2lyYy11cGRhdGUKCi0tLQogbGlzcC9uZXQvcmNpcmMu ZWwgfCAxNSArKysrKysrKysrKysrLS0KIDEgZmlsZSBjaGFuZ2VkLCAxMyBpbnNlcnRpb25z KCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3AvbmV0L3JjaXJjLmVsIGIv bGlzcC9uZXQvcmNpcmMuZWwKaW5kZXggMzdjMzFiZTU4Zi4uNGMxOTdhZWE1NCAxMDA2NDQK LS0tIGEvbGlzcC9uZXQvcmNpcmMuZWwKKysrIGIvbGlzcC9uZXQvcmNpcmMuZWwKQEAgLTYx MCw2ICs2MTAsOCBAQCBTZWUgYHJjaXJjLWNvbm5lY3QnIGZvciBtb3JlIGRldGFpbHMgb24g dGhlc2UgdmFyaWFibGVzLiIpCiAgICJBIGxpc3Qgb2YgY2FwYWJpbGl0aWVzIHRoYXQgY2xp ZW50IGhhcyByZXF1ZXN0ZWQuIikKIChkZWZ2YXItbG9jYWwgcmNpcmMtYWNrZWQtY2FwYWJp bGl0aWVzIG5pbAogICAiQSBsaXN0IG9mIGNhcGFiaWxpdGllcyB0aGF0IHRoZSBzZXJ2ZXIg c3VwcG9ydHMuIikKKyhkZWZ2YXItbG9jYWwgcmNpcmMtZmluaXNoZWQtc2FzbCB0CisgICJD aGVjayB3aGV0aGVyIFNBU0wgYXV0aGVudGljYXRpb24gaGFzIGNvbXBsZXRlZCIpCiAKIChk ZWZ1biByY2lyYy1nZXQtc2VydmVyLW1ldGhvZCAoc2VydmVyKQogICAiUmV0dXJuIGF1dGhl bnRpY2F0aW9uIG1ldGhvZCBmb3IgU0VSVkVSLiIKQEAgLTY1MCwxMCArNjUyLDEzIEBAIHRo YXQgYXJlIGpvaW5lZCBhZnRlciBhdXRoZW50aWNhdGlvbi4iCiAJICAgKHVzZXItbmFtZSAo b3IgdXNlci1uYW1lIHJjaXJjLWRlZmF1bHQtdXNlci1uYW1lKSkKIAkgICAoZnVsbC1uYW1l IChvciBmdWxsLW5hbWUgcmNpcmMtZGVmYXVsdC1mdWxsLW5hbWUpKQogCSAgIChzdGFydHVw LWNoYW5uZWxzIHN0YXJ0dXAtY2hhbm5lbHMpCisgICAgICAgICAgICh1c2Utc2FzbCAoZXEg KHJjaXJjLWdldC1zZXJ2ZXItbWV0aG9kIHNlcnZlcikgJ3Nhc2wpKQogICAgICAgICAgICAo cHJvY2VzcyAob3Blbi1uZXR3b3JrLXN0cmVhbQogICAgICAgICAgICAgICAgICAgICAgKG9y IHNlcnZlci1hbGlhcyBzZXJ2ZXIpIG5pbCBzZXJ2ZXIgcG9ydC1udW1iZXIKICAgICAgICAg ICAgICAgICAgICAgIDp0eXBlIChvciBlbmNyeXB0aW9uICdwbGFpbikpKSkKICAgICAgIDs7 IHNldCB1cCBwcm9jZXNzCisgICAgICAod2hlbiB1c2Utc2FzbAorICAgICAgICAoc2V0cS1s b2NhbCByY2lyYy1maW5pc2hlZC1zYXNsIG5pbCkpCiAgICAgICAoc2V0LXByb2Nlc3MtY29k aW5nLXN5c3RlbSBwcm9jZXNzICdyYXctdGV4dCAncmF3LXRleHQpCiAgICAgICAoc3dpdGNo LXRvLWJ1ZmZlciAocmNpcmMtZ2VuZXJhdGUtbmV3LWJ1ZmZlci1uYW1lIHByb2Nlc3Mgbmls KSkKICAgICAgIChzZXQtcHJvY2Vzcy1idWZmZXIgcHJvY2VzcyAoY3VycmVudC1idWZmZXIp KQpAQCAtNjg1LDYgKzY5MCwxMCBAQCB0aGF0IGFyZSBqb2luZWQgYWZ0ZXIgYXV0aGVudGlj YXRpb24uIgogICAgICAgICAocmNpcmMtc2VuZC1zdHJpbmcgcHJvY2VzcyAiUEFTUyIgcGFz c3dvcmQpKQogICAgICAgKHJjaXJjLXNlbmQtc3RyaW5nIHByb2Nlc3MgIk5JQ0siIG5pY2sp CiAgICAgICAocmNpcmMtc2VuZC1zdHJpbmcgcHJvY2VzcyAiVVNFUiIgdXNlci1uYW1lICIw IiAiKiIgOiBmdWxsLW5hbWUpCisgICAgICA7OyBTZXR1cCBzYXNsLCBhbmQgaW5pdGlhdGUg YXV0aGVudGljYXRpb24uCisgICAgICAod2hlbiAoYW5kIHJjaXJjLWF1dG8gLWF1dGhlbnRp Y2F0ZS1mbGFnCisgICAgICAgICAgICAgICAgIHVzZS1zYXNsKQorICAgICAgICAocmNpcmMt c2VuZC1zdHJpbmcgcHJvY2VzcyAiQVVUSEVOVElDQVRFIiAiUExBSU4iKSkKIAogICAgICAg Ozsgc2V0dXAgcGluZyB0aW1lciBpZiBuZWNlc3NhcnkKICAgICAgICh1bmxlc3MgcmNpcmMt a2VlcGFsaXZlLXRpbWVyCkBAIC0zNDM1LDcgKzM0NDQsNyBAQCBpcyB0aGUgcHJvY2VzcyBv YmplY3QgZm9yIHRoZSBjdXJyZW50IGNvbm5lY3Rpb24uIgogICAgICAgICAgICAgICAoKHN0 cmluZz0gc3ViY21kICJOQUsiKQogICAgICAgICAgICAgICAgKHNldHEgcmNpcmMtcmVxdWVz dGVkLWNhcGFiaWxpdGllcwogICAgICAgICAgICAgICAgICAgICAgKGRlbGV0ZSBjYXAgcmNp cmMtcmVxdWVzdGVkLWNhcGFiaWxpdGllcykpKSkpKQotICAgICh3aGVuIChudWxsIHJjaXJj LXJlcXVlc3RlZC1jYXBhYmlsaXRpZXMpCisgICAgKHdoZW4gKGFuZCAobnVsbCByY2lyYy1y ZXF1ZXN0ZWQtY2FwYWJpbGl0aWVzKSByY2lyYy1maW5pc2hlZC1zYXNsKQogICAgICAgOzsg QWxsIHJlcXVlc3RlZCBjYXBhYmlsaXRpZXMgaGF2ZSBiZWVuIHJlc3BvbmRlZCB0bwogICAg ICAgKHJjaXJjLXNlbmQtc3RyaW5nIHByb2Nlc3MgIkNBUCIgIkVORCIpKSkpCiAKQEAgLTM1 MDAsNyArMzUwOSw5IEBAIFBST0NFU1MgaXMgdGhlIHByb2Nlc3Mgb2JqZWN0IGZvciB0aGUg Y3VycmVudCBjb25uZWN0aW9uLiIKICAgIChiYXNlNjQtZW5jb2RlLXN0cmluZwogICAgIDs7 IHVzZSBjb25uZWN0aW9uIHVzZXItbmFtZQogICAgIChjb25jYXQgIlwwIiAobnRoIDMgcmNp cmMtY29ubmVjdGlvbi1pbmZvKQotICAgICAgICAgICAgIlwwIiAocmNpcmMtZ2V0LXNlcnZl ci1wYXNzd29yZCByY2lyYy1zZXJ2ZXIpKSkpKQorICAgICAgICAgICAgIlwwIiAocmNpcmMt Z2V0LXNlcnZlci1wYXNzd29yZCByY2lyYy1zZXJ2ZXIpKSkpCisgIChzZXRxLWxvY2FsIHJj aXJjLWZpbmlzaGVkLXNhc2wgdCkKKyAgKHJjaXJjLXNlbmQtc3RyaW5nIHByb2Nlc3MgIkNB UCIgIkVORCIpKQogCiAMCiAoZGVmZ3JvdXAgcmNpcmMtZmFjZXMgbmlsCi0tIAoyLjI1LjEK Cg== ----=_RainLoop_261_976796198.1624884361--