From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#59935: 29.0.60; project-list-buffers is slow Date: Sat, 10 Dec 2022 04:03:11 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39128"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Cc: juri@linkov.net To: 59935@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 10 03:04:22 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p3pDx-000A1r-L6 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 10 Dec 2022 03:04:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p3pDg-0004o4-Ur; Fri, 09 Dec 2022 21:04:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p3pDe-0004nc-LS for bug-gnu-emacs@gnu.org; Fri, 09 Dec 2022 21:04:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p3pDe-00047M-7P for bug-gnu-emacs@gnu.org; Fri, 09 Dec 2022 21:04:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p3pDd-0001uo-OX for bug-gnu-emacs@gnu.org; Fri, 09 Dec 2022 21:04:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Dec 2022 02:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59935 X-GNU-PR-Package: emacs Original-Received: via spool by 59935-submit@debbugs.gnu.org id=B59935.16706378017355 (code B ref 59935); Sat, 10 Dec 2022 02:04:01 +0000 Original-Received: (at 59935) by debbugs.gnu.org; 10 Dec 2022 02:03:21 +0000 Original-Received: from localhost ([127.0.0.1]:39830 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3pCy-0001uZ-Lc for submit@debbugs.gnu.org; Fri, 09 Dec 2022 21:03:20 -0500 Original-Received: from mail-wr1-f53.google.com ([209.85.221.53]:37624) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3pCw-0001uT-W7 for 59935@debbugs.gnu.org; Fri, 09 Dec 2022 21:03:19 -0500 Original-Received: by mail-wr1-f53.google.com with SMTP id co23so6937663wrb.4 for <59935@debbugs.gnu.org>; Fri, 09 Dec 2022 18:03:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=H69fy8EjEV9xTokfuhBD3r2tl1c11E8UjpthnQzMdxk=; b=DP1fYLGMztzchBCL8B7RfexMyDtVHkX/SLXXvXoGpE77nEx3+XruNMSvENJad+iwN3 aRlWe4haRa98nsowCsYsyi7qt8WSXbN4N62SYzoE5PblAeBjF2bWdYMF4usnoClfiu5t jc6g8ouEFtkLybPHyq9Xq1c1ukS6U7lJZ1lRxnEySY3qlp8Rqa4r5AOeW73nO/PB79lO oEIQtmrtjlT++g4GG6tGjNgSKZIX7+N/vnySzBePotNka1kLkPduQROkk2e6wUR29Z2+ 07VbxjBAXOyRxwqDs+iwGOtlAL7+0IYAlen1mgPK8nkdTJf7ks7LjvyHVCAwOPeB7kRO Y4BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=H69fy8EjEV9xTokfuhBD3r2tl1c11E8UjpthnQzMdxk=; b=6ws+mznAwUpelDKQfcC5dk7m6LrpkuAW6K7HUFccQ0VbrlufHH5UiTVdo9uKq2puPx FYRxG40oitlLabd7En0QPH30xf3RFytdL4Y/BdFm2ymCHdFs72UMDnjjPmjn5fTddD8d i4Y7daC0QVTTZZyAXhVg0ELfw6diOEJoxyYCdnWE5dZCNXl34koBWXasXO5UBspm/8XU MrvhQ9TP7y2Hgg/DSy6F0bx4n4yFd+4kogzmOVGQr62TB9ylJcg3ON0XjiaNip9YgXyW bTyCCwvL/zA1gSzpu+YjO/7jPcPF3e8eXXxQHw7l0mHXY37aLtgi9SopOsuls2zmpvfH jO0w== X-Gm-Message-State: ANoB5pl/LuUGgTzlkLXcr3+2rMh8VxenHvnqIyiGEJbIWs3jEo5diAA5 FEQSXzGzggCVyqTNkEhMJ9/z2aN35j0= X-Google-Smtp-Source: AA0mqf5Ie5w/8+eFHnJEIr9P03A/EZ/cQfHqo1ksbXG4WLD9rxLWovC9AnxaZ/nWticH6bNX9CHoIQ== X-Received: by 2002:adf:a1c3:0:b0:24b:b74d:8012 with SMTP id v3-20020adfa1c3000000b0024bb74d8012mr1793327wrv.18.1670637793055; Fri, 09 Dec 2022 18:03:13 -0800 (PST) Original-Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id l5-20020adfe9c5000000b0023c8026841csm2644638wrn.23.2022.12.09.18.03.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Dec 2022 18:03:12 -0800 (PST) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250483 Archived-At: On 10/12/2022 03:49, Dmitry Gutov wrote: > Curiously, though, it shows a different list of buffers. It also > includes "hidden" buffers - diff-syntax, Echo Area, etc. We should look > into that either way. The combined fix for both can be this: diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el index 016dfdd5b4..835ab07e50 100644 --- a/lisp/progmodes/project.el +++ b/lisp/progmodes/project.el @@ -1340,18 +1340,21 @@ project-list-buffers start with a space (which are for internal use). With prefix argument ARG, show only buffers that are visiting files." (interactive "P") - (let ((pr (project-current t))) + (let* ((pr (project-current t)) + (fetcher (lambda () + (cl-delete-if-not + (lambda (b) + (or (buffer-file-name b) + (string-match-p "\\`[^ ]" (buffer-name b)))) + (project-buffers pr))))) (display-buffer - (if (version< emacs-version "29.0.50") - (let ((buf (list-buffers-noselect arg (project-buffers pr)))) - (with-current-buffer buf - (setq-local revert-buffer-function - (lambda (&rest _ignored) - (list-buffers--refresh (project-buffers pr)) - (tabulated-list-print t)))) - buf) - (list-buffers-noselect - arg nil (lambda (buf) (memq buf (project-buffers pr)))))))) + (let ((buf (list-buffers-noselect arg (funcall fetcher)))) + (with-current-buffer buf + (setq-local revert-buffer-function + (lambda (&rest _ignored) + (list-buffers--refresh (funcall fetcher)) + (tabulated-list-print t)))) + buf)))) (defcustom project-kill-buffer-conditions '(buffer-file-name ; All file-visiting buffers are included.