From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#71525: 30.0.50; Spin in delete-region/interval_deletion_adjustment Spin in delete-region/interval_deletion_adjustment) Date: Fri, 14 Jun 2024 21:17:22 +0300 Message-ID: References: <87y17a55ny.fsf@stebalien.com> <87ikydo246.fsf@stebalien.com> <86o785z8wl.fsf@gnu.org> <87tthwrh8h.fsf@stebalien.com> <867ceszvp1.fsf@gnu.org> <87r0d0rfxa.fsf@stebalien.com> <87bk44bzf4.fsf@stebalien.com> <8634pgztx0.fsf@gnu.org> <86v82cxahx.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16910"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: jporterbugs@gmail.com, steven@stebalien.com, 71525@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jun 14 20:18:10 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sIBV4-00048a-6P for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 Jun 2024 20:18:10 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sIBUy-0006Be-CD; Fri, 14 Jun 2024 14:18:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sIBUw-0006Ax-VR for bug-gnu-emacs@gnu.org; Fri, 14 Jun 2024 14:18:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sIBUw-0006bH-Nx for bug-gnu-emacs@gnu.org; Fri, 14 Jun 2024 14:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sIBUw-00051c-VD for bug-gnu-emacs@gnu.org; Fri, 14 Jun 2024 14:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Jun 2024 18:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71525 X-GNU-PR-Package: emacs Original-Received: via spool by 71525-submit@debbugs.gnu.org id=B71525.171838905519247 (code B ref 71525); Fri, 14 Jun 2024 18:18:02 +0000 Original-Received: (at 71525) by debbugs.gnu.org; 14 Jun 2024 18:17:35 +0000 Original-Received: from localhost ([127.0.0.1]:40914 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sIBUV-00050M-BE for submit@debbugs.gnu.org; Fri, 14 Jun 2024 14:17:35 -0400 Original-Received: from wfhigh7-smtp.messagingengine.com ([64.147.123.158]:39071) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sIBUS-000504-7v for 71525@debbugs.gnu.org; Fri, 14 Jun 2024 14:17:33 -0400 Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailfhigh.west.internal (Postfix) with ESMTP id D7D1D18000B4; Fri, 14 Jun 2024 14:17:25 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 14 Jun 2024 14:17:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1718389045; x=1718475445; bh=GZaprirR5K8yTymapw89a3Y9uCuYf2aiOjChv+j27Bw=; b= ZrTmUlilWUl45M6DwdqECnDfZi6CKEd70OgLipICsctYft1GOL7he4vjnbAz0MHm KX18GIabE+uDa94ScromxKx+uGApSbt+g4lCpuHpOTVYcliubX4MSqBAKP/VMbPl QQXt9HgWRdcK8i9uCBdawvNoYxxNFqhAx46ytq50qn6wbKZcveMPJBRpXwiYQaA1 MnAuLT0BpoCRULFrwsIyAqvDiS94KQC2nuZjWNelIN726rl1lCR35n5g/mQ9k39s W8B3EY14wp+53VoUV18Q4H/UwAaMQaVcPRcoSQosbAH7HPyPRXksw0RQVaQmCKW9 cI6JiuQKMurY4EohTYMksQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1718389045; x= 1718475445; bh=GZaprirR5K8yTymapw89a3Y9uCuYf2aiOjChv+j27Bw=; b=T MaVCZhHShPzS2ZttNTPvVlPRcluR8glnpaRdzL1HzkYUYKX25+N8NrB51NEMItO/ mgbvpW/XjEqr2/VfffsgAfGROlN+a+8wzcJ2oviYjjEwH8t9mNcvtBUcqX3pF1rI +y62FbG9WotX7BSRfuUqOXZ0h3wFHo67H/Z4EqZZpgBYIt9Y8Uc5kBG+j4ExRvnr zw2hcfnoLkUE4ktrmXegj+yRkGfyQOUFaC2qHJv3LbgC3+fU3lHWT/saOKxWu8CU hbj1B7MgrfMg/Cr2HoY83uLo8OVF6njtJd1MlA5+f1r2Ih7A4wztRwSMHZA5LNaI aUWpmM3wCDcUsIWE6N5PA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrfeduledguddvvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkffggfgfuvfevfhfhjggtgfesthejredttddvjeenucfhrhhomhepffhm ihhtrhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrg htthgvrhhnpeetudeljeegheetgfehgeejkeeuhedvveeikeeufedtvddtveefhfdvveeg udejheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe gumhhithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 14 Jun 2024 14:17:24 -0400 (EDT) Content-Language: en-US In-Reply-To: <86v82cxahx.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287239 Archived-At: On 14/06/2024 10:13, Eli Zaretskii wrote: >> /* Insert a sequence of NCHARS chars which occupy NBYTES bytes >> starting at GAP_END_ADDR - NBYTES (if text_at_gap_tail) and at >> - GPT_ADDR (if not text_at_gap_tail). */ >> + GPT_ADDR (if not text_at_gap_tail). >> + >> + If BEFORE_MARKERS is true, insert before markers. */ > This commentary should also mention process.c as the single caller > using this facility in unconventional ways. Also note that I did make some effort to make the field coding->insert_before_markers used consistently: in the changeset, it's not just obeyed on the code path that decode_coding_c_string goes through - it's used anywhere where insert_from_gap is called and a coding_system structure is available - e.g. in encode_coding. Also in decode_coding_gap, but that one seems to only have one caller (insert-file-contents), so that choice is moot. Something else I've noticed (a bit off topic): insert_from_gap_1's comments says that it "does not invalidate any cache, nor update any markers, nor record any buffer modification information of any sort", but then it calls treesit_record_change when available. Not sure we need to change that, but maybe we should update the comment, at least.