From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#46097: 27.1; Minibuffer may not be current when running minibuffer-exit-hook Date: Mon, 25 Jan 2021 20:04:42 +0100 Message-ID: References: <8735yp9tyn.fsf@miha-pc> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40151"; mail-complaints-to="usenet@ciao.gmane.io" To: klubujevetru , 46097@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 25 20:25:37 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l47UW-000AJr-Sb for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 25 Jan 2021 20:25:36 +0100 Original-Received: from localhost ([::1]:44102 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l47UV-0005ff-UE for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 25 Jan 2021 14:25:35 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35288) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l47Ad-0002od-0m for bug-gnu-emacs@gnu.org; Mon, 25 Jan 2021 14:05:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56619) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l47Ac-00075u-L3 for bug-gnu-emacs@gnu.org; Mon, 25 Jan 2021 14:05:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l47Ac-0006MX-GV for bug-gnu-emacs@gnu.org; Mon, 25 Jan 2021 14:05:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 25 Jan 2021 19:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46097 X-GNU-PR-Package: emacs Original-Received: via spool by 46097-submit@debbugs.gnu.org id=B46097.161160149624435 (code B ref 46097); Mon, 25 Jan 2021 19:05:02 +0000 Original-Received: (at 46097) by debbugs.gnu.org; 25 Jan 2021 19:04:56 +0000 Original-Received: from localhost ([127.0.0.1]:39931 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l47AV-0006M2-Pe for submit@debbugs.gnu.org; Mon, 25 Jan 2021 14:04:56 -0500 Original-Received: from mout.gmx.net ([212.227.15.15]:45161) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l47AT-0006Lo-Mg for 46097@debbugs.gnu.org; Mon, 25 Jan 2021 14:04:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1611601487; bh=cgKPNpopz7ve66i/goAsmqc2jCYgSqAVrPdLz0kfmn0=; h=X-UI-Sender-Class:Subject:To:References:From:Date:In-Reply-To; b=Dp2DC6NEOD7ntwSzWZod9w+w4QrrLKenBFMnEBjUIHftn2pjKJrHslhyVvMn4ZCfL qBnM5y4VhPUd9ng4stRqrMVUWxO+HUMVghdJJW1dN9S7VG/c0fOqXu/sfm0q/4LhQt XVYHl6/UtmMd7pMMC8kN0Tpo9JyI5EuURfADsnbk= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.100] ([212.95.5.156]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MaJ3n-1lXcWR3wRR-00WDM5; Mon, 25 Jan 2021 20:04:47 +0100 In-Reply-To: <8735yp9tyn.fsf@miha-pc> Content-Language: en-US X-Provags-ID: V03:K1:puK17RJzEUbEO5BCOE6F5/wCBCGGI31bYga+aF+p+ZO4uvxSWSB 6bLpENI/HK6uiuLJpJcVuA0X/nORr4dVcKPnRycpYjJwHmIbUqyoJNZZikjKWDq94BpyYf9 Y46qtc1pKzXz0ll3/01r1dBh76OzIo+zUn630AU/OBAX2IAU60LoG1NGdDkY09y6s3X1aBV GjkLOaUejAFkxDI8cuDDQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:St0h9MWV8dY=:bC7nsTyCCo3qQ6a7c5Fya5 /C9SpoaNbEffqtf5FKTR1fl5m6/mfc6DuR8+GGdxGtnBXefjuT4PPwLrr0H2GOwzzKM3TbYml vXKiBOCqoo/QOEAbzHKsUSNz9VQqRr/1LUJ+MbR6kNV/qO0iCKiQJU6Oraqzxqj7dRHF5og7a xZED3HEgh1RtMY3yoPJ7XhCd8uEUc743wtPvqeazz7/eI/VufpPLfd79veNQYEkISV1mMbDJU ttofcj3JW728hqUo7gFU4xgLFGdQoiXcqNcQwPMYRvpXd+eqksiEZpbV+foQ6PE/ttDDpfNBd q8vFZZXfOnHrr48Rr3OhCFRjdC9yh11aCR18W8HVzFtr/3Qs4OC6sGXCzXTGef2/EUnr4rH9v EDUbXu9JLMPUgc8pjkGHQDV0rFle8wMLSGGvCloPE9Y5t7Gc7k4+oM3vRuWnrr7cY4PsOR1Yk b2Ps8U1zMcQr2FKxhmNwuoHezx99TrmejmWZjH+h1xLDwYFI27nKtNDS6otMZDDf5WQXdjIQe UnKW9O/Cnx/WffNhvhZyMUVrvefcQggvQvZWDeqYlTP6mK22VNk3UKvhg+EZADruu3a2D3JGd 4OkXPmYG+nh4g+z1pq/Z2RZdhtcYNJ2cF1AZaQ2Brchk1h+0yQTt7WlqX5FmxWrC5rpIeseeg wdw1baJf30bH2XG7jjWx9gps1dZoMFm2F/dgEOtmrF36QRcrsIBK6VToHNH1K9LFqlcGhAOYs F0OLiNuX4ftRrH4opPCNko1SgsifZUxy4mJ7iGj6fnQFKtXDF7jgmKjVb0v18UF07INqCDLl X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:198583 Archived-At: > Open the minibuffer with C-x C-f, switch to another window with C-x o > and abort the minibuffer with C-] (abort-recursive-edit). > minibuffer-exit-hook ends up running without the minibuffer being the > current buffer. > > This may cause problems if a minibuffer adds a cleanup function the hook > locally, see for example discussion at > https://github.com/oantolin/embark/issues/114 > The cleanup function fails to run in this situation because the local > value of the hook isn't considered. But both, current buffer and selected window, might be of interest for the function running that hook. So I think we should not change the current behavior but rather document it and provide better access to find the minibuffer that was just aborted. The only way I found is (window-buffer (active-minibuffer-window)) Why don't we provide a function like 'active-minibuffer'? Or even a function like 'minibuffer-list'? martin