From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Aloxaf Newsgroups: gmane.emacs.bugs Subject: bug#43532: [feature/native-comp] *.eln file name hashing, algorithm doesn't seem to play nice with NATIVE_FULL_AOT and self-contained, Emacs.app builds for macOS Date: Thu, 1 Oct 2020 23:01:53 +0800 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="------------B9CB6EB512C847B58DBB8085" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8960"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 Cc: 43532@debbugs.gnu.org To: Andrea Corallo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 01 17:19:34 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kO0Mo-0002EH-H8 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 01 Oct 2020 17:19:34 +0200 Original-Received: from localhost ([::1]:34980 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kO0Mn-0002tB-Gw for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 01 Oct 2020 11:19:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49722) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kO0Cc-00076c-4v for bug-gnu-emacs@gnu.org; Thu, 01 Oct 2020 11:09:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54613) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kO0Cb-0006o5-OG for bug-gnu-emacs@gnu.org; Thu, 01 Oct 2020 11:09:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kO0Cb-0004ew-IM for bug-gnu-emacs@gnu.org; Thu, 01 Oct 2020 11:09:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Aloxaf Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 Oct 2020 15:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43532 X-GNU-PR-Package: emacs Original-Received: via spool by 43532-submit@debbugs.gnu.org id=B43532.160156488317846 (code B ref 43532); Thu, 01 Oct 2020 15:09:01 +0000 Original-Received: (at 43532) by debbugs.gnu.org; 1 Oct 2020 15:08:03 +0000 Original-Received: from localhost ([127.0.0.1]:37926 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kO0Be-0004dj-KQ for submit@debbugs.gnu.org; Thu, 01 Oct 2020 11:08:03 -0400 Original-Received: from mail-pf1-f180.google.com ([209.85.210.180]:39844) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kO05w-0004Ub-Tr for 43532@debbugs.gnu.org; Thu, 01 Oct 2020 11:02:10 -0400 Original-Received: by mail-pf1-f180.google.com with SMTP id n14so4746998pff.6 for <43532@debbugs.gnu.org>; Thu, 01 Oct 2020 08:02:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language; bh=215w2QBaHHQJaSAZJf5f4bcKj/KdNgkq3VCxkvMT6xM=; b=Ea3opzbGbLdkNASMRDK5Q8isVGJ6c6pGluAZ1lmaXtkyr/EbNqb4NLrN7epbmc5n4/ oiI8YEDy7yv22eADcwA82MX/T+8icvZdJ7FhTf/SxvT654tRdr+A5sLashH/tP7NJ0Zh YcamTdiuR7YRFeXKbtbJKtr1O+qeOUxpM4XO4+TPiQVxwDBNM1+R78mpZvzjjRUZuErJ oImK+XQ7K/2xemOYq/HzzJsTfByOlp4I69ms7DaRUJ/0k78bQLx0Up6BQbQkR1NsevZG ceLPzo/t45ik5sqFMivr40rNHxpn/78VAamBkJly7KDXijHqwLueFnNPoeE8DSHoP3E0 r0zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language; bh=215w2QBaHHQJaSAZJf5f4bcKj/KdNgkq3VCxkvMT6xM=; b=jBy3BuSF0jg8tbU5iiFS4CpiMBMa9ufj09kUc96svAJtW4O/cM6GzI4CV37/3xUigq k3RbD5RiS0/CWRRr5pp4mkIGmhANdpldegncSt/Gy9VJB/NoViH8ArdOzewNbDM+/rUI wfrs3e+6cgOozZuRZirFMDp7lswwq00/T29UFdwGp248L5k/grep1LAfajiPwSyAUB5A KEA/IzJrC9n2Q9sQwZBuSha4nomUwVD0guPw73L7H++hh/vO8cRn1tvc8oWpc8R45IzS /KUuWbZ9ERrvu/iaZOEkT7hO3DGxjB6JnhtO7zkGs8cmuvvhj4yw6/iUMRYAE5Ackwuk dynw== X-Gm-Message-State: AOAM531p/RDdqPsMC8dBlnEV22pLb/G38VLg85vPnubLZ2ZZDwZu13Wa EhKLesnFqfjgzoV7HJHfpkcIHoHpqe0gvQ== X-Google-Smtp-Source: ABdhPJzCbkH3XVMrSg2iRJGEmomvW6BOqpfN0Qx256TOCnFGhar+VcsW0TDZF9TwDYtEmrf0ym5Z/g== X-Received: by 2002:aa7:8ad8:0:b029:150:7d36:cddf with SMTP id b24-20020aa78ad80000b02901507d36cddfmr7406572pfd.55.1601564522108; Thu, 01 Oct 2020 08:02:02 -0700 (PDT) Original-Received: from [0.0.0.0] (210-61-148-165.HINET-IP.hinet.net. [210.61.148.165]) by smtp.gmail.com with ESMTPSA id e8sm3661565pgj.8.2020.10.01.08.01.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Oct 2020 08:02:01 -0700 (PDT) X-Google-Original-From: Aloxaf In-Reply-To: Content-Language: en-US X-Mailman-Approved-At: Thu, 01 Oct 2020 11:08:01 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:189521 Archived-At: This is a multi-part message in MIME format. --------------B9CB6EB512C847B58DBB8085 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit 在 2020/10/1 下午9:19, Andrea Corallo 写道: > Aloxaf writes: > >> 在 2020/9/30 下午3:13, Andrea Corallo 写道: >> >>> Once the package is produced it can be in any directory with no >>> restrinction on the name or like in MacOS the pkg directory will be >>> called like name.app? >>> >>> Thanks >>> >>> Andrea >> If you mean where it will be installed. It will always be installed to >> / by default, but there is not some special restriction. >> The $pkgdir just like a fake root and install it with AUR should have >> the same directory structure as `make install DSTDIR='/'` >> >> If you mean where the $pkgdir will be. Its value is >> $BUILDDIR/$PACKAGE_NAME/pkg/$PACKAGE_NAME, $BUILDDIR can be configured >> by user. > Yes that's what I meant. Okay then if is correct to assume > $PACKAGE_NAME is know at compile time should be possible on our side to > offer a build option to specify that while compiling. You mean something like `./configure --pkgdir=xxx`? That sounds good and flexible. > >> BTW, is there any special reason to consider file path when hashing? >> IMHO, it may be better not to consider it? > It makes simple and very cheap to keep the cache directory clean, the > fact that's cheap allow us to the this clean-up often. > > Thanks > > Andrea > > PS you should do a replay-all when replaying to keep the bug posted Oops, sorry for that. Thanks     Aloxaf --------------B9CB6EB512C847B58DBB8085 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 8bit



在 2020/10/1 下午9:19, Andrea Corallo 写道:
Aloxaf <aloxafx@gmail.com> writes:


在 2020/9/30 下午3:13, Andrea Corallo 写道:


Once the package is produced it can be in any directory with no
restrinction on the name or like in MacOS the pkg directory will be
called like name.app?

Thanks

   Andrea

If you mean where it will be installed. It will always be installed to
/ by default, but there is not some special restriction.
The $pkgdir just like a fake root and install it with AUR should have
the same directory structure as `make install DSTDIR='/'`

If you mean where the $pkgdir will be. Its value is
$BUILDDIR/$PACKAGE_NAME/pkg/$PACKAGE_NAME, $BUILDDIR can be configured
by user.

Yes that's what I meant.  Okay then if is correct to assume
$PACKAGE_NAME is know at compile time should be possible on our side to
offer a build option to specify that while compiling.

You mean something like `./configure --pkgdir=xxx`? That sounds good and flexible.



BTW, is there any special reason to consider file path when hashing?
IMHO, it may be better not to consider it?

It makes simple and very cheap to keep the cache directory clean, the
fact that's cheap allow us to the this clean-up often.

Thanks

  Andrea

PS you should do a replay-all when replaying to keep the bug posted

Oops, sorry for that.


Thanks

    Aloxaf

--------------B9CB6EB512C847B58DBB8085--