From: Dmitry Gutov <dgutov@yandex.ru>
To: Tino Calancha <tino.calancha@gmail.com>, Andreas Schwab <schwab@suse.de>
Cc: 24725@debbugs.gnu.org
Subject: bug#24725: 25.1.50; vc-region-history may exceed max line number of file in repository
Date: Thu, 20 Oct 2016 13:21:00 +0300 [thread overview]
Message-ID: <d03da0d9-6caf-826a-f7b6-0bf543bb185d@yandex.ru> (raw)
In-Reply-To: <87r37bcuho.fsf@gmail.com>
On 20.10.2016 11:09, Tino Calancha wrote:
>> Shouldn't that be fixed in the caller, and lto always be decremented if
>> the regions ends at bol?
> I think you are right. Otherwise we are including a line out of the
> region, i.e., in interactive calls we also search in the history for
> a line out of the highlighted region.
> How about following new patch?
LGTM, please install.
Although I was thinking of simplifying it to just:
(line-number-at-pos (1- to))
That can only bite us if TO is at bob, which would be very unusual.
next prev parent reply other threads:[~2016-10-20 10:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-18 14:27 bug#24725: 25.1.50; vc-region-history may exceed max line number of file in repository Tino Calancha
2016-10-19 23:22 ` Dmitry Gutov
2016-10-20 4:22 ` Tino Calancha
2016-10-20 7:27 ` Andreas Schwab
2016-10-20 8:09 ` Tino Calancha
2016-10-20 10:21 ` Dmitry Gutov [this message]
2016-10-20 10:44 ` Tino Calancha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d03da0d9-6caf-826a-f7b6-0bf543bb185d@yandex.ru \
--to=dgutov@yandex.ru \
--cc=24725@debbugs.gnu.org \
--cc=schwab@suse.de \
--cc=tino.calancha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.