From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Phil Sainty Newsgroups: gmane.emacs.devel Subject: Re: Help using the right hook for loading theme on emacs daemon GUI Date: Fri, 25 Jan 2019 10:16:58 +1300 Message-ID: References: <6c1611672809c8d7b5011edf0d2dd831@webmail.orcon.net.nz> <83va2e6t7r.fsf@gnu.org> <83d0ol7scu.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="227591"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Orcon Webmail Cc: emacs-devel@gnu.org, kaushal.modi@gmail.com To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jan 24 22:27:05 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gmmWf-000x5T-1D for ged-emacs-devel@m.gmane.org; Thu, 24 Jan 2019 22:27:05 +0100 Original-Received: from localhost ([127.0.0.1]:32813 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gmmWd-0007gn-Uv for ged-emacs-devel@m.gmane.org; Thu, 24 Jan 2019 16:27:03 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:38210) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gmmWP-0007b9-9M for emacs-devel@gnu.org; Thu, 24 Jan 2019 16:26:50 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gmmMx-0003f6-0Q for emacs-devel@gnu.org; Thu, 24 Jan 2019 16:17:03 -0500 Original-Received: from smtp-2.orcon.net.nz ([60.234.4.43]:42476) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gmmMv-0003e5-RF; Thu, 24 Jan 2019 16:17:02 -0500 Original-Received: from [10.253.37.70] (port=52432 helo=webmail.orcon.net.nz) by smtp-2.orcon.net.nz with esmtpa (Exim 4.86_2) (envelope-from ) id 1gmmMs-0004et-NN; Fri, 25 Jan 2019 10:16:58 +1300 Original-Received: from wlgwil-nat-office.catalyst.net.nz ([202.78.240.7]) via [10.253.37.253] by webmail.orcon.net.nz with HTTP (HTTP/1.1 POST); Fri, 25 Jan 2019 10:16:58 +1300 In-Reply-To: <83d0ol7scu.fsf@gnu.org> X-Sender: psainty@orcon.net.nz X-GeoIP: -- X-Spam_score: -2.9 X-Spam_score_int: -28 X-Spam_bar: -- X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 60.234.4.43 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:232677 Archived-At: On 2019-01-25 08:44, Eli Zaretskii wrote: > It's not entirely a no-op, since there's early-init-file and > package-initialize, both of which are called before this hook. Ah, interesting. So this subtlety is new as of Emacs 27. I was already thinking that the `after-make-frame-functions' docstring could use some additional information (it seems to be a common point of confusion when people start using --daemon); and even more so given this new wrinkle. (info "(elisp) Creating Frames") does already say: > Note that any functions added to these hooks by your initial file > are > usually not run for the initial frame, since Emacs reads the initial > file only after creating that frame. However, if the initial frame is > specified to use a separate minibuffer frame (*note Minibuffers and > Frames::), the functions will be run for both, the minibuffer-less and > the minibuffer frame. (As a tangent, the terminology "initial file" instead of the more common "init file" is a little jarring. It crops up in that context in a couple of other places in the manual, I see, and I'm unsure whether it's a typo or intended, but I would be inclined to replace them with "init file" in all cases.) The info node should be updated to cover the new behaviour in 27, and I suggest that the docstrings ought to provide a clear pointer to the info node as being very important reading regarding when the hooks do and do not run. I think the docstrings should possibly also replicate or summarise some of that information; but just ensuring that readers know there are additional subtleties to understand, and where to read about them, would be good enough. -Phil