From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.devel Subject: Re: scratch/igc e30aacad558: Convert SPLAT_PVEC to a function, restore an exhaustive switch Date: Sat, 20 Jul 2024 08:19:48 +0000 Message-ID: References: <172146115753.30547.6490547847617776966@vcs2.savannah.gnu.org> <20240720073917.DECA4C3535F@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36778"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Emacs Devel To: Gerd Moellmann Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jul 20 12:13:12 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sV75S-0009L1-Ik for ged-emacs-devel@m.gmane-mx.org; Sat, 20 Jul 2024 12:13:10 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sV74w-0000fQ-Su; Sat, 20 Jul 2024 06:12:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sV5Jt-0001c2-6B for emacs-devel@gnu.org; Sat, 20 Jul 2024 04:19:57 -0400 Original-Received: from mail-40134.protonmail.ch ([185.70.40.134]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sV5Jr-0002UW-DR for emacs-devel@gnu.org; Sat, 20 Jul 2024 04:19:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1721463592; x=1721722792; bh=jaUKXmPn8HvCs/zSCUDbwp393yqfUn0CzGFFx2G+gso=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=WyTk6J/eya3S1NaMXtknbR1DDjW/YI/qKPJpg7yoshzqQl8iBOuxfKsNhbCMqWPzk DJKDH5Wc4xSRlxDahBLJWb8WOM5gVO5Lr8nMGoKA14yLFt3Ts0lok+ouBKoc4r3D11 eM9y9R5ABaz78JGnHBGM+j2YUXJJviSnJywjKqLbvJ360XnYC2xq98FNJB8sOwzsKn Ngu0LlTOG4Cwd1ZJdSjzLwt4K4/sxNcNboJNYBjArm5N7v+CKlv2VffuetcBaxBdQH u3cPtS6K0LTQVijj+C2EkDqassqj1wGxa3PND8zeTI/dVMjwW+WF8ha/WXRD4YzWvv 1hrnv+JDt5eQw== In-Reply-To: <20240720073917.DECA4C3535F@vcs2.savannah.gnu.org> Feedback-ID: 112775352:user:proton X-Pm-Message-ID: 3efb11a01f274ac5bc4d3b328d2c7437c82a2051 Received-SPF: pass client-ip=185.70.40.134; envelope-from=pipcet@protonmail.com; helo=mail-40134.protonmail.ch X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Sat, 20 Jul 2024 06:12:36 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:321834 Archived-At: On Saturday, July 20th, 2024 at 07:39, Gerd Moellmann wrote: > branch: scratch/igc > commit e30aacad5582889cb18b5089e73d022f0c8ae7c8 > Author: Gerd M=C3=B6llmann gerd@gnu.org >=20 > Commit: Gerd M=C3=B6llmann gerd@gnu.org >=20 > Convert SPLAT_PVEC to a function, restore an exhaustive switch > +#ifndef IN_MY_FORK > + case PVEC_OBARRAY: > +#endif > + case PVEC_HASH_TABLE: > + case PVEC_WEAK_HASH_TABLE: > + case PVEC_SYMBOL_WITH_POS: > + case PVEC_PROCESS: > + case PVEC_RECORD: > + case PVEC_CLOSURE: > + case PVEC_SQLITE: > + case PVEC_TS_NODE: > + case PVEC_NORMAL_VECTOR: > +#ifdef IN_MY_FORK > + case PVEC_PACKAGE: > +#endif > + case PVEC_WINDOW_CONFIGURATION: > + case PVEC_BUFFER: > + case PVEC_FRAME: > + case PVEC_WINDOW: > + case PVEC_CHAR_TABLE: > + case PVEC_SUB_CHAR_TABLE: > + case PVEC_BOOL_VECTOR: > + case PVEC_OVERLAY: > + case PVEC_OTHER: > + case PVEC_MISC_PTR: > + case PVEC_XWIDGET: > + case PVEC_XWIDGET_VIEW: > + case PVEC_TERMINAL: > + case PVEC_MARKER: > + case PVEC_MODULE_GLOBAL_REFERENCE: > + igc_assert (!"finalization not implemented"); > + break; Hmm. I'm afraid my changes mean finalize_vector is called for all vectors w= ith an extended header, so it must be a nop rather than aborting. Is it oka= y if I change that? I'll keep the exhaustive switch, of course :-) Pip