all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Glenn Morris <rgm@gnu.org>
To: 753@emacsbugs.donarmstrong.com
Subject: bug#753: [Fwd: sh-script.el: indentation of ( )]
Date: Fri, 22 Aug 2008 20:12:00 -0400	[thread overview]
Message-ID: <cyfxowy4hb.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <48AC8E68.8080503@t-online.de> (Daniel Pfeiffer's message of "Wed, 20 Aug 2008 23:36:40 +0200")

Daniel Pfeiffer wrote:

> What indent-region on the entire buffer yields:
>
> 	#!/bin/sh
> 	
> 	(
> 	    true
> 	    )
> 	{
> 	    true
> 	}


Emacs 21.4 gets it right here, whereas 22.1 and later gets it wrong.

The difference seems to be caused by sh-get-kw, specifically:

2006-10-10  Stefan Monnier  <monnier@iro.umontreal.ca>

    * progmodes/sh-script.el (sh-get-kw): | is not among the allowed chars
    for a keyword.

In making this change (rev 1.191), you also added '()' to the
non-allowed characters along with '|'. Since it wasn't documented in
the ChangeLog, was this a mistake?






  reply	other threads:[~2008-08-23  0:12 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <eqr67xumlz.fsf@fencepost.gnu.org>
2008-08-20 21:36 ` bug#753: [Fwd: sh-script.el: indentation of ( )] Daniel Pfeiffer
2008-08-23  0:12   ` Glenn Morris [this message]
2008-09-03 17:34     ` Glenn Morris
2009-01-07  4:47       ` Stefan Monnier
     [not found]       ` <jwvy6xnd8rf.fsf-monnier+emacsbugreports@gnu.org>
2009-01-08  8:00         ` Glenn Morris
2009-01-08 16:39           ` Stefan Monnier
2009-01-09  2:39             ` Glenn Morris
2009-01-09  3:58               ` Stefan Monnier
2009-01-09  5:02                 ` Glenn Morris
2009-01-09 17:24                   ` Stefan Monnier
2015-12-30  0:45                     ` Andrew Hyatt
2016-01-01  2:19                       ` Glenn Morris
2016-01-02 20:55                         ` Andrew Hyatt
2008-09-06 19:10   ` bug#753: marked as done ([Fwd: sh-script.el: indentation of ( )]) Emacs bug Tracking System
2009-05-04 20:30   ` Emacs bug Tracking System

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cyfxowy4hb.fsf@fencepost.gnu.org \
    --to=rgm@gnu.org \
    --cc=753@emacsbugs.donarmstrong.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.