From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.devel Subject: Re: finish version test cleanup: Lucid Date: Sun, 28 Oct 2007 20:10:38 -0400 Message-ID: References: <200710281747.l9SHlHL1026263@oogie-boogie.ics.uci.edu> <4724ECDF.3080806@ig.com.br> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1193616653 6969 80.91.229.12 (29 Oct 2007 00:10:53 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 29 Oct 2007 00:10:53 +0000 (UTC) Cc: Dan Nicolaescu , emacs-devel@gnu.org To: Vinicius Jose Latorre Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Oct 29 01:10:53 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1ImIDV-0004uH-9K for ged-emacs-devel@m.gmane.org; Mon, 29 Oct 2007 01:10:53 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ImIDL-0000Nx-Sc for ged-emacs-devel@m.gmane.org; Sun, 28 Oct 2007 20:10:43 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ImIDJ-0000Ns-J0 for emacs-devel@gnu.org; Sun, 28 Oct 2007 20:10:41 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ImIDI-0000Nf-6d for emacs-devel@gnu.org; Sun, 28 Oct 2007 20:10:40 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ImIDI-0000Nc-0D for emacs-devel@gnu.org; Sun, 28 Oct 2007 20:10:40 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1ImIDH-0007P8-Gd for emacs-devel@gnu.org; Sun, 28 Oct 2007 20:10:39 -0400 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.60) (envelope-from ) id 1ImIDG-00072z-9z; Sun, 28 Oct 2007 20:10:38 -0400 X-Spook: Albright e-cash Majic Lexis-Nexis Sears Tower csim X-Ran: W1rl%w-/bM),1('G38u/<]ynWV/p|^@a]Y}OoczIo3b>{c#o>62VrllA6[WYupaZ+ (Vinicius Jose Latorre's message of "Sun, 28 Oct 2007 17:11:11 -0300") User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:82003 Archived-At: Vinicius Jose Latorre wrote: > Dan Nicolaescu wrote: >> Most string version tests have been replaced with feature tests. >> These are the remaining ones: >> >> ./progmodes/cperl-mode.el:81: (defconst cperl-xemacs-p (string-match "XEmacs\\|Lucid" emacs-version)) >> ./progmodes/cperl-mode.el:154:(defconst cperl-xemacs-p (string-match "XEmacs\\|Lucid" emacs-version)) Could be deleted, since there is a separate stand-alone cperl-mode that people on other platforms can use. (At the cost of more difference between the Emacs and standalone version.) >> ./ielm.el:172: (if (string-match "Lucid" emacs-version) Could just delete Lucid code. >> ./ps-print.el:1467: ((string-match "Lucid" emacs-version) >> ./ps-print.el:1469: ((string-match "Epoch" emacs-version) Could just be deleted. All they do is refuse to support said platforms. The rest of Emacs doesn't bother with such checks. (I imagine ps-print is distributed with all current emacs varieties, so the number of people downloading standalone versions will be very small. So you could probably delete _all_ the version-checking code at the start.) >> ./calc/calc.el:825:(defvar calc-emacs-type-lucid (not (not (string-match "Lucid" emacs-version)))) Don't know. >> ./emulation/tpu-mapper.el:83:(defconst tpu-lucid-emacs19-p (string-match "Lucid" emacs-version) Could just delete all lucid Emacs 19 support from this file.