From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: David Edmondson Newsgroups: gmane.emacs.bugs Subject: bug#33043: [PATCH v1 1/1] Support for the truncation of displayed URLs Date: Thu, 18 Oct 2018 10:39:08 +0100 Message-ID: References: <20181015100626.2344-1-dme@dme.org> <87r2go2opq.fsf@tcd.ie> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1539855497 30064 195.159.176.226 (18 Oct 2018 09:38:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 18 Oct 2018 09:38:17 +0000 (UTC) Cc: 33043@debbugs.gnu.org To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 18 11:38:12 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gD4ku-0007jG-CS for geb-bug-gnu-emacs@m.gmane.org; Thu, 18 Oct 2018 11:38:12 +0200 Original-Received: from localhost ([::1]:41287 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gD4n0-0003oA-U1 for geb-bug-gnu-emacs@m.gmane.org; Thu, 18 Oct 2018 05:40:22 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42765) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gD4mn-0003mf-KY for bug-gnu-emacs@gnu.org; Thu, 18 Oct 2018 05:40:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gD4mh-0000eG-TJ for bug-gnu-emacs@gnu.org; Thu, 18 Oct 2018 05:40:09 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51874) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gD4mh-0000eA-Ns for bug-gnu-emacs@gnu.org; Thu, 18 Oct 2018 05:40:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gD4mf-0002Qp-TQ for bug-gnu-emacs@gnu.org; Thu, 18 Oct 2018 05:40:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: David Edmondson Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Oct 2018 09:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33043 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 33043-submit@debbugs.gnu.org id=B33043.15398555599279 (code B ref 33043); Thu, 18 Oct 2018 09:40:01 +0000 Original-Received: (at 33043) by debbugs.gnu.org; 18 Oct 2018 09:39:19 +0000 Original-Received: from localhost ([127.0.0.1]:56132 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gD4lz-0002Pb-FT for submit@debbugs.gnu.org; Thu, 18 Oct 2018 05:39:19 -0400 Original-Received: from mail-wm1-f65.google.com ([209.85.128.65]:55680) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gD4lx-0002PM-37 for 33043@debbugs.gnu.org; Thu, 18 Oct 2018 05:39:18 -0400 Original-Received: by mail-wm1-f65.google.com with SMTP id 206-v6so4734609wmb.5 for <33043@debbugs.gnu.org>; Thu, 18 Oct 2018 02:39:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dme-org.20150623.gappssmtp.com; s=20150623; h=to:cc:subject:in-reply-to:references:from:date:message-id :mime-version; bh=H4UNFLgfC/2jlNnWjnmarkZ0iS/iT3zg3aZ3J4qTaGQ=; b=09ESvfTAogIj7BchlgLP9ti7U4elnO3uVw8Zwy2uo/yDtyn2bKlalcbLjDS1As4oGs Te0ElSlc2MiJ8QwrlaEi9/c8ws/0lQfWOPJsmPuOq7+KkMtri0SONz+FCtdeTqpXG0Wq UM1UpKNhDHKmtBo36xwFP8hjOsEtQPO8Nyvvmh0QfgeOYP37iG2lHxDwCa8CWTq2OEZz X6ZFx9ay3gRt7OtOOXuvTPaGpdmZ3zU1k6P7ninMLSXQCB26g6dyxRz7p/JQufJ3fHTq cw/aY1YKCd/rwqdQgAskJqyHWwh8lLyQypfg0sPBPC3qV302yZc0yFnOFEmpawKYnl0M nL1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:subject:in-reply-to:references:from:date :message-id:mime-version; bh=H4UNFLgfC/2jlNnWjnmarkZ0iS/iT3zg3aZ3J4qTaGQ=; b=p7+ux9cOkj+uZTymhvfbhDt/b5R+HEAZlrqNIcJh5C0tY0xHYoNo045Q8L9nhfcoN0 JTp43XPz+TNvGHiGKCSYhefWmhexZsUITco0nBXt4/GYwSOuic3/1CzeW9dghkLYtPHe iTAEJFxB0UOcDQ7X82pobT5vnCmBG5Mr0QuHDLWNiRJQr0H5TIyHH1dDR0e4VQOIDusP lXs3KRhuUr0MMkHYc81gNkskMN7q4St/3HjUVXlk6lOoQmO79qjfCpLOvS+CHKBXuLxS uf2YjodlAeZF0oiGV7WYKTkq47RUSsnLF+5GjFAZAdUt5hI3JssngMuVAx+Enpb0T7uu UqYg== X-Gm-Message-State: ABuFfoiv4abrMPX1NIw4qR/22RGvFANsDQz/53OQ6Wjybq4ArO5UHwh1 3HsxrudL2mCXFfRTHwyv+RlqBmN3YLA= X-Google-Smtp-Source: ACcGV61uOaleMA2wJAV61QpIJWmGhbOfV/1GiQUOJ542PTo5HxrOVrsTh56CcOjWyKTmNybitNR2yg== X-Received: by 2002:a1c:b7c1:: with SMTP id h184-v6mr6823581wmf.33.1539855550712; Thu, 18 Oct 2018 02:39:10 -0700 (PDT) Original-Received: from disaster-area.hh.sledj.net (disaster-area.hh.sledj.net. [81.149.164.25]) by smtp.gmail.com with ESMTPSA id g3-v6sm12847851wrw.81.2018.10.18.02.39.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 Oct 2018 02:39:09 -0700 (PDT) Original-Received: from localhost (disaster-area.hh.sledj.net [local]) by disaster-area.hh.sledj.net (OpenSMTPD) with ESMTPA id 988926e7; Thu, 18 Oct 2018 09:39:08 +0000 (UTC) In-Reply-To: <87r2go2opq.fsf@tcd.ie> X-HGTTG: gag-halfrunt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:151367 Archived-At: On Wednesday, 2018-10-17 at 23:27:45 +01, Basil L. Contovounesios wrote: > Couldn't we reuse url-truncate-url-for-viewing, which tries to be smart > about where it places the ellipsis, for this? I think the existing code > can also be cleaned up a little: I didn't know about url-truncate-url-for-viewing, no other reason. I'd be happy with your change, but note that it will always truncate URLs that are wider than the current frame - there is no way to have no truncation take place. If a user is most familiar with something like ffap to open URLs then this is unfortunate - ffap doesn't see the full URL in the buffer. > diff --git a/lisp/net/rcirc.el b/lisp/net/rcirc.el > index fe9c71a21c..de28cdb054 100644 > --- a/lisp/net/rcirc.el > +++ b/lisp/net/rcirc.el > @@ -2485,24 +2485,25 @@ rcirc-markup-my-nick > (rcirc-record-activity (current-buffer) 'nick))))) > > (defun rcirc-markup-urls (_sender _response) > - (while (and rcirc-url-regexp ;; nil means disable URL catching > + (while (and rcirc-url-regexp ; nil means disable URL catching. > (re-search-forward rcirc-url-regexp nil t)) > - (let* ((start (match-beginning 0)) > + (let* ((beg (match-beginning 0)) > (end (match-end 0)) > - (url (match-string-no-properties 0)) > - (link-text (buffer-substring-no-properties start end))) > - ;; Add a button for the URL. Note that we use `make-text-button', > - ;; rather than `make-button', as text-buttons are much faster in > - ;; large buffers. > - (make-text-button start end > - 'face 'rcirc-url > - 'follow-link t > - 'rcirc-url url > - 'action (lambda (button) > - (browse-url (button-get button 'rcirc-url)))) > - ;; record the url if it is not already the latest stored url > - (when (not (string= link-text (caar rcirc-urls))) > - (push (cons link-text start) rcirc-urls))))) > + (url (buffer-substring-no-properties beg end))) > + (delete-region beg end) > + ;; Add a button for the URL. Note that we use > + ;; `insert-text-button', rather than `insert-button', as text > + ;; property buttons are much faster in large buffers. > + (insert-text-button > + (url-truncate-url-for-viewing url rcirc-url-max-length) > + 'face 'rcirc-url > + 'follow-link t > + 'rcirc-url url > + 'action (lambda (button) > + (browse-url (button-get button 'rcirc-url)))) > + ;; Record the URL if it is not already the latest stored URL. > + (unless (string= url (caar rcirc-urls)) > + (push (cons url beg) rcirc-urls))))) > > (defun rcirc-markup-keywords (sender response) > (when (and (string= response "PRIVMSG") > > WDYT? > > -- > Basil dme. -- I've still got sand in my shoes.