From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Kevin Rodgers Newsgroups: gmane.emacs.devel Subject: Re: Updating movemail in Emacs Date: Thu, 18 Nov 2004 12:49:03 -0700 Message-ID: References: <200411011451.JAA28950@smtp.ott.qnx.com> <200411011509.iA1F91017792@Mirddin.farlep.net> <200411031853.iA3IrL011498@Mirddin.farlep.net> <200411181708.iAIH8e028114@Mirddin.farlep.net> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1100807383 3780 80.91.229.6 (18 Nov 2004 19:49:43 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 18 Nov 2004 19:49:43 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 18 20:49:35 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1CUsHf-00058i-00 for ; Thu, 18 Nov 2004 20:49:35 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CUsQW-0005vz-Pb for ged-emacs-devel@m.gmane.org; Thu, 18 Nov 2004 14:58:44 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1CUsQD-0005vG-Ks for emacs-devel@gnu.org; Thu, 18 Nov 2004 14:58:25 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1CUsQC-0005uf-R9 for emacs-devel@gnu.org; Thu, 18 Nov 2004 14:58:25 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CUsQC-0005uV-Fq for emacs-devel@gnu.org; Thu, 18 Nov 2004 14:58:24 -0500 Original-Received: from [80.91.229.2] (helo=main.gmane.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1CUsHJ-0006ir-Cs for emacs-devel@gnu.org; Thu, 18 Nov 2004 14:49:13 -0500 Original-Received: from list by main.gmane.org with local (Exim 3.35 #1 (Debian)) id 1CUsHI-0006RO-00 for ; Thu, 18 Nov 2004 20:49:12 +0100 Original-Received: from 170.207.1.200 ([170.207.1.200]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 18 Nov 2004 20:49:12 +0100 Original-Received: from ihs_4664 by 170.207.1.200 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 18 Nov 2004 20:49:12 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-To: emacs-devel@gnu.org Original-Lines: 56 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: 170.207.1.200 User-Agent: Mozilla Thunderbird 0.9 (X11/20041105) X-Accept-Language: en-us, en In-Reply-To: <200411181708.iAIH8e028114@Mirddin.farlep.net> X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:30043 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:30043 Sergey Poznyakoff wrote: > The attached patch automatically detects which flavor of movemail > is in use: native Emacs or GNU mailutils. Unless the variable > rmail-movemail-program is set, it looks for the movemail program > in a list of directories composed of rmail-movemail-search-path, > exec-path and exec-directory. I think it should search for rmail-movemail-program in those directories even if it's set (to a non-absolute name): (defcustom rmail-movemail-program "movemail" "If non-nil, name of program for fetching new mail." :group 'rmail-retrieve :type 'string) (defun rmail-autodetect () (if (file-name-absolute-p rmail-movemail-program) (rmail-probe rmail-movemail-program) (let ((exec-path (append rmail-movemail-search-path exec-path (list exec-directory)))) (rmail-probe (setq rmail-movemail-program (executable-find rmail-movemail-program)))))) ... > @@ -3841,12 +3917,15 @@ TEXT and INDENT are not used." > (setq rmail-pop-password nil) > (setq rmail-encoded-pop-password nil))) > > -(defun rmail-get-pop-password () > - "Get the password for retrieving mail from a POP server. If none > +(defun rmail-get-pop-password (imap) > + "Get the password for retrieving mail from a POP or IMAP server. If none > has been set, then prompt the user for one." > (if (not rmail-encoded-pop-password) > (progn (if (not rmail-pop-password) > - (setq rmail-pop-password (read-passwd "POP password: "))) > + (setq rmail-pop-password > + (read-passwd (if imap > + "IMAP password: " > + "POP password: ")))) > (rmail-set-pop-password rmail-pop-password) > (setq rmail-pop-password nil))) > (rmail-encode-string rmail-encoded-pop-password (emacs-pid))) Wouldn't it be cleaner to name this function rmail-get-remote-password and the variable rmail-remote-password? (If not, at least make the IMAP argument to rmail-get-pop-password &optional). Even better, maintain both rmail-pop-password and rmail-imap-password so the user can access multiple remote mailboxes. -- Kevin Rodgers