From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.devel Subject: Re: master fails to build on FreeBSD when ACL support is on Date: Wed, 14 Nov 2018 18:12:29 -0500 Message-ID: References: <86o9lua0yx.fsf@phe.ftfl.ca> <834lnly8ht.fsf@gnu.org> <86vafy20sj.fsf@phe.ftfl.ca> <83o9lpuct5.fsf@gnu.org> <83lggtu1qn.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1542237035 2806 195.159.176.226 (14 Nov 2018 23:10:35 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 14 Nov 2018 23:10:35 +0000 (UTC) User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 15 00:10:31 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gN4In-0000cS-9g for ged-emacs-devel@m.gmane.org; Thu, 15 Nov 2018 00:10:29 +0100 Original-Received: from localhost ([::1]:34513 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gN4Kt-0002Uk-KS for ged-emacs-devel@m.gmane.org; Wed, 14 Nov 2018 18:12:39 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37007) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gN4Kk-0002Ud-BM for emacs-devel@gnu.org; Wed, 14 Nov 2018 18:12:31 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gN4Kj-0004q2-I9 for emacs-devel@gnu.org; Wed, 14 Nov 2018 18:12:30 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49770) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gN4Kj-0004pt-F2 for emacs-devel@gnu.org; Wed, 14 Nov 2018 18:12:29 -0500 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1gN4Kj-0007rD-A1; Wed, 14 Nov 2018 18:12:29 -0500 X-Spook: NASA Marijuana MIT-LL Black out Bin Laden broadside ISEC X-Ran: .>b{6p>r5}`FzAUJ354;f0Jt`5UUk&T9+MGLtO^^ATuJ88/CL]XD{a^Y~)>=V~&.Y[Fa"^ X-Hue: red X-Attribution: GM X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:231157 Archived-At: Glenn Morris wrote: > IMO the change in 4fd446e is obviously correct. > The current (reverted) code is wrong by inspection when target-file is > relative. In normal use, it never is, but it will be if > byte-compile-dest-file is changed to return a non-absolute value. > > For example, this can be the case for automake, as we saw in > > http://lists.gnu.org/archive/html/emacs-devel/2017-11/msg00551.html > > since Makefiles normally use relative filenames, and automake changes > byte-compile-dest-file-function to return "$@". > > Eg I predict the following will fail on a FreeBSD system like the one in > the original message in this thread: > > ./src/emacs --batch \ > --eval '(setq byte-compile-dest-file-function (lambda (x) "foo.elc"))' > -f batch-byte-compile foo.el > > This simulates how automake may call Emacs to compile a file. > > (It fails on RHEL 7.4 with TMPDIR=/does/not/exist. Obviously this is not > sensible, but the point is that it should not be writing to TMPDIR at all.) Here is an instance of the failure that I predicted: http://lists.nongnu.org/r/bbdb-user/2018-11/msg00003.html Please consider backporting 64c8467 (the master version of the reverted 4fd446e from emacs-26) to the emacs-26 branch.