From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#33344: 26.1; doc-view bounding-box recognition doesn't work on path names with spaces Date: Wed, 14 Nov 2018 13:14:39 -0500 Message-ID: References: <2721782.Y6SdopJXAr@calvin> <9ein120yhb.fsf@fencepost.gnu.org> <83o9as9a6x.fsf@gnu.org> <2pmuqcalt3.fsf@fencepost.gnu.org> <83h8gk93w8.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1542219197 27224 195.159.176.226 (14 Nov 2018 18:13:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 14 Nov 2018 18:13:17 +0000 (UTC) User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) Cc: 33344@debbugs.gnu.org, trent2@web.de To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 14 19:13:13 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gMzf6-0006uh-W7 for geb-bug-gnu-emacs@m.gmane.org; Wed, 14 Nov 2018 19:13:13 +0100 Original-Received: from localhost ([::1]:33653 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gMzhD-0005tx-1o for geb-bug-gnu-emacs@m.gmane.org; Wed, 14 Nov 2018 13:15:23 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49617) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gMzgw-0005sR-Dj for bug-gnu-emacs@gnu.org; Wed, 14 Nov 2018 13:15:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gMzgu-0005zW-5g for bug-gnu-emacs@gnu.org; Wed, 14 Nov 2018 13:15:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48246) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gMzgs-0005xc-CO for bug-gnu-emacs@gnu.org; Wed, 14 Nov 2018 13:15:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gMzgs-0006xI-7O for bug-gnu-emacs@gnu.org; Wed, 14 Nov 2018 13:15:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 14 Nov 2018 18:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33344 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33344-submit@debbugs.gnu.org id=B33344.154221929826708 (code B ref 33344); Wed, 14 Nov 2018 18:15:02 +0000 Original-Received: (at 33344) by debbugs.gnu.org; 14 Nov 2018 18:14:58 +0000 Original-Received: from localhost ([127.0.0.1]:52503 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gMzgn-0006wh-P8 for submit@debbugs.gnu.org; Wed, 14 Nov 2018 13:14:57 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:39788) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gMzgm-0006wT-HH for 33344@debbugs.gnu.org; Wed, 14 Nov 2018 13:14:56 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gMzgg-0005kP-Pb for 33344@debbugs.gnu.org; Wed, 14 Nov 2018 13:14:51 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43055) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gMzgY-0005ca-HP; Wed, 14 Nov 2018 13:14:43 -0500 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1gMzgW-0000ss-5L; Wed, 14 Nov 2018 13:14:40 -0500 X-Spook: SRI Rand Corporation Security Council al-Qaida S Key X-Ran: ``0ER{2:D!6QpH67YYSlTt2fX~Mv/@*^8zaJM.UBYjQ_7ztD)Fwl}hA}M3|u{Z~drr&ti( X-Hue: red X-Attribution: GM In-Reply-To: <83h8gk93w8.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 13 Nov 2018 21:24:55 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:152392 Archived-At: Eli Zaretskii wrote: > I don't disagree, but that's not the point. The point is that this > code was written to use the shell, and it works. Turning it upside > down because it failed to quote a single argument risks introducing > bugs and backward incompatibilities for what IMO is a very small gain. I don't think there's a mystery or grand design here. People sometimes just reach for "shell-command" when they want to run an external process, without thinking about the details. "sh -c STUFF" is the same as just STUFF unless STUFF relies on some shell feature like globbing. If STUFF doesn't require any shell features then calling it via a shell is at best inefficient and at worst harmful (if the shell mishandles any portion of STUFF, as happens here). It is clear by inspection that this particular call does not require shell features, so it should not go through a shell. I've put reviewing all such uses of shell-command in Emacs on my todo list (but it may well never happen). (To return to a previous point: the "doc" argument here cannot be remote, by virtue of doc-view's cache.)