From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Suraj Acharya Newsgroups: gmane.emacs.devel Subject: Re: Filename completion for the 'file widget Date: Tue, 24 Aug 2004 17:35:52 -0700 Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Message-ID: References: <412BD771.7010601@yahoo.com> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1093394183 24240 80.91.224.253 (25 Aug 2004 00:36:23 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 25 Aug 2004 00:36:23 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Aug 25 02:36:14 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1Bzllu-0004Fd-00 for ; Wed, 25 Aug 2004 02:36:14 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BzlqR-0000Xv-8z for ged-emacs-devel@m.gmane.org; Tue, 24 Aug 2004 20:40:55 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1BzlqK-0000Xg-HP for emacs-devel@gnu.org; Tue, 24 Aug 2004 20:40:48 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1BzlqJ-0000XU-U2 for emacs-devel@gnu.org; Tue, 24 Aug 2004 20:40:48 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BzlqJ-0000XR-Px for emacs-devel@gnu.org; Tue, 24 Aug 2004 20:40:47 -0400 Original-Received: from [80.91.224.249] (helo=main.gmane.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1Bzllc-0005h2-AB for emacs-devel@gnu.org; Tue, 24 Aug 2004 20:35:56 -0400 Original-Received: from list by main.gmane.org with local (Exim 3.35 #1 (Debian)) id 1Bzllb-0004uV-00 for ; Wed, 25 Aug 2004 02:35:55 +0200 Original-Received: from 63.96.165.58 ([63.96.165.58]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 25 Aug 2004 02:35:55 +0200 Original-Received: from sacharya by 63.96.165.58 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 25 Aug 2004 02:35:55 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-To: emacs-devel@gnu.org Original-Lines: 25 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: 63.96.165.58 User-Agent: Mozilla Thunderbird 0.7.1 (Windows/20040626) X-Accept-Language: en-us, en In-Reply-To: <412BD771.7010601@yahoo.com> X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:26465 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:26465 Kevin Rodgers wrote: > Suraj Acharya wrote: > > Since I prefer this second non-expanding behavior I managed to get it to > > work on my local machine by using (concat directory completion) in place > > of (expand-file-name completion directory) in widget-file-complete. > > That doesn't seem right. I was going to suggest something like Why do you say it's not right? It gives me the behavior I expect, ie relative paths stay relative and I still get completion for them. It uses default-directory for the current buffer as the base for the relative path completion. > > (file-relative-name (expand-file-name completion directory) directory) > > but I realized that's equivalent to just completion, so I took a look > at the code in wid-edit.el. But it's not clear to me (1) why > widget-file-complete expands the pattern nor (2) why it can safely > assume the pattern has a non-nil directory that can be passed as the > second arg to file-name-completion. > (2) is definitely a bug. Asking for completion in a blank 'file widget gives "let*: Wrong type argument: stringp, nil" in the minibuffer.