From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mohammed Sadiq Newsgroups: gmane.emacs.bugs Subject: bug#60122: 29.0.60; c-ts-mode breaks with '"' separated macros Date: Sat, 17 Dec 2022 12:50:54 +0530 Message-ID: References: <84db9d18bd013acbff59890f895e26f0@sadiqpk.org> <87cz8jrvs0.fsf@thornhill.no> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11828"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60122@debbugs.gnu.org, casouri@gmail.com To: Theodor Thornhill Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 17 08:22:20 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p6RWW-0002sS-86 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 17 Dec 2022 08:22:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p6RWM-0004qi-03; Sat, 17 Dec 2022 02:22:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6RWE-0004oq-NJ for bug-gnu-emacs@gnu.org; Sat, 17 Dec 2022 02:22:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p6RWE-0006yj-26 for bug-gnu-emacs@gnu.org; Sat, 17 Dec 2022 02:22:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p6RWD-0003rp-Js for bug-gnu-emacs@gnu.org; Sat, 17 Dec 2022 02:22:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Mohammed Sadiq Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Dec 2022 07:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60122 X-GNU-PR-Package: emacs Original-Received: via spool by 60122-submit@debbugs.gnu.org id=B60122.167126166914847 (code B ref 60122); Sat, 17 Dec 2022 07:22:01 +0000 Original-Received: (at 60122) by debbugs.gnu.org; 17 Dec 2022 07:21:09 +0000 Original-Received: from localhost ([127.0.0.1]:54322 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6RVM-0003rP-Ny for submit@debbugs.gnu.org; Sat, 17 Dec 2022 02:21:08 -0500 Original-Received: from relay3-d.mail.gandi.net ([217.70.183.195]:56271) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6RVG-0003qe-01 for 60122@debbugs.gnu.org; Sat, 17 Dec 2022 02:21:06 -0500 Original-Received: (Authenticated sender: sadiq@sadiqpk.org) by mail.gandi.net (Postfix) with ESMTPA id D70FC60003; Sat, 17 Dec 2022 07:20:54 +0000 (UTC) In-Reply-To: <87cz8jrvs0.fsf@thornhill.no> X-Sender: sadiq@sadiqpk.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:251259 Archived-At: On 2022-12-17 01:00, Theodor Thornhill wrote: > Mohammed Sadiq writes: > >> The following code is parsed wrong with c-ts-mode: >> >> >> #include >> >> int >> main (void) >> { >> GFileInfo *info; >> GFile *file; >> >> file = g_file_new_for_path ("some/path"); >> info = g_file_query_info (file, >> G_FILE_ATTRIBUTE_THUMBNAIL_IS_VALID "," >> G_FILE_ATTRIBUTE_THUMBNAILING_FAILED "," >> G_FILE_ATTRIBUTE_TIME_MODIFIED "," >> >> G_FILE_ATTRIBUTE_STANDARD_FAST_CONTENT_TYPE, >> G_FILE_QUERY_INFO_NONE, >> NULL, NULL); >> } >> >> >> c-ts-mode doesn't assume G_FILE_ATTRIBUTE_THUMBNAIL_IS_VALID (and >> others) to be a string (or some function/macro call that results in a >> string) resulting in broken font locking and tab indentation. >> >> The same code seems to work fine with c-mode >> > > Hi! > > If you use treesit-explore-mode, you can see that the tree-sitter > parser > returns this ast: > > (expression_statement > (assignment_expression left: (identifier) operator: = > right: > (call_expression function: (identifier) > arguments: > (argument_list ( (identifier) , (identifier) > (ERROR ") > , > (string_literal " > (ERROR (identifier)) > ") > , > (string_literal " > (ERROR (identifier)) > ") > , > (ERROR ") > (identifier) , (identifier) , (null) , (null) )))) > ;) > > > Because tree-sitter fails to parse this there's only so much we can do. > > I think you should file this as a bug at the parser issue tracker over > at github[0]. Maybe it's a known problem already? > > Theo > > > [0]: https://github.com/tree-sitter/tree-sitter-c/issues I did notice that later and filed an issue: https://github.com/tree-sitter/tree-sitter-c/issues/120 cheers, Mohammed Sadiq