From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alex Harsanyi Newsgroups: gmane.emacs.devel Subject: Re: incorrect working revision for the mercurial VC backend Date: Wed, 30 Dec 2009 14:15:05 +0800 Message-ID: References: <19258.47991.673928.374725@totara.tehura.co.nz> <19258.52278.890330.878259@totara.tehura.co.nz> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1262153745 5684 80.91.229.12 (30 Dec 2009 06:15:45 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 30 Dec 2009 06:15:45 +0000 (UTC) Cc: emacs-devel@gnu.org To: Nick Roberts Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Dec 30 07:15:39 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NPrq5-0002Xf-Ap for ged-emacs-devel@m.gmane.org; Wed, 30 Dec 2009 07:15:38 +0100 Original-Received: from localhost ([127.0.0.1]:44486 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NPrq2-0006MJ-CI for ged-emacs-devel@m.gmane.org; Wed, 30 Dec 2009 01:15:18 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NPrpu-0006M6-E0 for emacs-devel@gnu.org; Wed, 30 Dec 2009 01:15:10 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NPrpq-0006LW-Ua for emacs-devel@gnu.org; Wed, 30 Dec 2009 01:15:10 -0500 Original-Received: from [199.232.76.173] (port=55472 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NPrpq-0006LO-JI for emacs-devel@gnu.org; Wed, 30 Dec 2009 01:15:06 -0500 Original-Received: from mail-yx0-f191.google.com ([209.85.210.191]:56659) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NPrpq-0006B6-Cu for emacs-devel@gnu.org; Wed, 30 Dec 2009 01:15:06 -0500 Original-Received: by yxe29 with SMTP id 29so33329739yxe.14 for ; Tue, 29 Dec 2009 22:15:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=H52Vl7dSUEKLyPmwHTyiFnHmXxdNpdAgvzZFtTCPvXA=; b=OWdrl16NYkQeiHYm1HwTp9MJhvw0gWSdKK4Qe6qtkhRKeQkr0PwSE9W9SHULWDEFSF BxhPJEBo9Rj+BXv0pVc0qE6GqXdPtiUEC0I40AU/HmLkWT1qawo63eIrU4lB//PPdcX+ 9tkAl8eXlyuuLdsjW1WsX1rdgAGjPwc9adudU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=tZ0pcOo6NB0ndm+DTTgbd5Bc6t4tTxfnocsmWB8vaV3rS+D9r9y0yqcOS/YypBqzxv c8xwzRX5f/7xwfbEB5aQa8BCVcdVrbkBMH11npptIgekU+XHppRKMw6ErqOS7hBjcQhP OC9R7Tkq9F64rWmpNMtDRZE/CYFJr7Io5aDEE= Original-Received: by 10.150.243.21 with SMTP id q21mr25966915ybh.215.1262153705382; Tue, 29 Dec 2009 22:15:05 -0800 (PST) In-Reply-To: <19258.52278.890330.878259@totara.tehura.co.nz> X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:119020 Archived-At: On Wed, Dec 30, 2009 at 11:42 AM, Nick Roberts wrote: > [please cc the mailing list] > > =A0> I haven't switched yet to bzr, so I cannot pull the change, however > =A0> the patch corresponds to my local fix, except that the last line > =A0> reads: > > But you could apply the patch to your working copy. I could not apply it. If I copy-paste it out of the email, patch rejects it= : $ patch -p1 < vc-hg.patch patching file vc-hg.el Hunk #1 FAILED at 209. 1 out of 1 hunk FAILED -- saving rejects to file vc-hg.el.rej When I try to apply it from Emacs, it asks me first if I want to fix word-wrap damage, but after I say yes, it fails anyway... Sorry but I'm not sure what is wrong. > > =A0> (if (eq 0 status) out =A0"0") > =A0> > =A0> This corresponds to the previous behavior of returning a string as t= he > =A0> revision and returning "0" if there is a problem with running the hg > =A0> command. > > Does that really correspond to the previous behavior? > > =A0 =A0... > =A0 =A0(when (eq 0 status) > =A0 =A0 =A0(if (string-match "changeset: *\\([0-9]*\\)" out) > =A0 =A0 =A0 =A0 =A0(match-string 1 out) > =A0 =A0 =A0 =A0"0")))) You are right. > > Also, iget a quoted string, e.g. "\"290\"", which is why I used read. This is because you use "\"{rev}\"" as the template instead of "{rev}". I used "{rev}" and I get just the revision e.g. 290. Cheers, Alex.