From 54a2d5a65b2e868ce3b18c47f50886d07414adec Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Mon, 17 Oct 2022 00:00:44 -0700 Subject: [PATCH 10/10] Improve randomness of message-canlock-generate * lisp/gnus/message.el (message-canlock-generate): Simplify by using make-nonce. --- lisp/gnus/message.el | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/lisp/gnus/message.el b/lisp/gnus/message.el index 5e4e9854a6..670844703d 100644 --- a/lisp/gnus/message.el +++ b/lisp/gnus/message.el @@ -5192,10 +5192,7 @@ message-send-mail-with-mailclient (defun message-canlock-generate () "Return a string that is non-trivial to guess. Do not use this for anything important, it is cryptographically weak." - (sha1 (concat (message-unique-id) - (format "%x%x%x" (random) (random) (random)) - (prin1-to-string (recent-keys)) - (prin1-to-string (garbage-collect))))) + (make-nonce 20 #'sha1)) (defvar canlock-password) (defvar canlock-password-for-verify) -- 2.34.1