From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#21305: 25.0.50; `get-buffer-window-list' doc - what order? Date: Sat, 22 Aug 2015 10:23:22 -0700 (PDT) Message-ID: References: <089f48ed-6ce9-4753-abcf-3f86d43a278e@default>> <83vbc8iyut.fsf@gnu.org>> <5430f5a7-2939-4f96-8c6c-3e820ffcfd6b@default> <55D74386.6010708@gmx.at> <7036da11-d296-45a9-b6ee-d7b68830927e@default> <55D74AA3.1070202@gmx.at> <1b17a036-c525-4dbc-84fa-cc8adc2b6488@default> <50fbb71c-8a6d-45b4-a467-a31bcc73ac09@default> <55D8195A.4040804@gmx.at> <9aa1dcd7-1781-41aa-bf47-7b280b26da1e@default> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1440264266 22529 80.91.229.3 (22 Aug 2015 17:24:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 22 Aug 2015 17:24:26 +0000 (UTC) Cc: 21305@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Aug 22 19:24:13 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZTCWY-0003Ia-6O for geb-bug-gnu-emacs@m.gmane.org; Sat, 22 Aug 2015 19:24:10 +0200 Original-Received: from localhost ([::1]:47336 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZTCWX-00089O-FH for geb-bug-gnu-emacs@m.gmane.org; Sat, 22 Aug 2015 13:24:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43135) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZTCWU-000898-J0 for bug-gnu-emacs@gnu.org; Sat, 22 Aug 2015 13:24:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZTCWQ-0001K6-Et for bug-gnu-emacs@gnu.org; Sat, 22 Aug 2015 13:24:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:43129) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZTCWQ-0001K0-Am for bug-gnu-emacs@gnu.org; Sat, 22 Aug 2015 13:24:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZTCWQ-0001qu-3Q for bug-gnu-emacs@gnu.org; Sat, 22 Aug 2015 13:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Aug 2015 17:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21305 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21305-submit@debbugs.gnu.org id=B21305.14402642067074 (code B ref 21305); Sat, 22 Aug 2015 17:24:02 +0000 Original-Received: (at 21305) by debbugs.gnu.org; 22 Aug 2015 17:23:26 +0000 Original-Received: from localhost ([127.0.0.1]:35339 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZTCVp-0001q2-OP for submit@debbugs.gnu.org; Sat, 22 Aug 2015 13:23:26 -0400 Original-Received: from userp1040.oracle.com ([156.151.31.81]:36564) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZTCVn-0001pu-P8 for 21305@debbugs.gnu.org; Sat, 22 Aug 2015 13:23:24 -0400 Original-Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id t7MHNMju015154 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 22 Aug 2015 17:23:22 GMT Original-Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userv0021.oracle.com (8.13.8/8.13.8) with ESMTP id t7MHNM6M003379 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Sat, 22 Aug 2015 17:23:22 GMT Original-Received: from abhmp0008.oracle.com (abhmp0008.oracle.com [141.146.116.14]) by userv0122.oracle.com (8.13.8/8.13.8) with ESMTP id t7MHNL4C004205; Sat, 22 Aug 2015 17:23:21 GMT In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6691.5000 (x86)] X-Source-IP: userv0021.oracle.com [156.151.31.71] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:105705 Archived-At: > >> `get-buffer-window-list' is in window.el. Couldn't you try > >> giving it a fourth argument, say SORT, which, if `lru-first' > >> or `mru-first', would cause it to return the windows in the=20 > >> corresponding order? > > > > Patch attached. >=20 > FWIW, I think adding an argument for that is a bad idea. If the > caller needs the windows sorted in a particular way, then *he* > should sort them. (S?he should know whether the return value of `get-buffer-window-list' is a new list (it is), so that `sort' can be applied to it without causing problems elsewhere. For that, s?he will want to consult the code of `get-buffer-window-list'.) > It would make sense to provide sorting directly in the function if > the sorting can't be done, or not as efficiently, after the fact. > But that is not the case here. I don't disagree. What was not obvious was how you might sort windows wrt last-use time. But IIUC, Martin has now updated the manual to mention `window-use-time', of which I was unaware. What I suggested was not to add a SORT arg to `get-buffer-window-list' but to add functions such as `(mru|lru)-window-for-buffer'. (It was for the latter that I was interested in `get-buffer-window-list'.)