From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#25105: 26.0.50; diff navigation is broken Date: Sun, 8 Jan 2017 01:27:26 +0300 Message-ID: References: <87inpt6lce.fsf@gmail.com> <87tw9dc7bk.fsf@secretsauce.net> <87shoxc70l.fsf@secretsauce.net> <20170106030606.GB1101@holos.localdomain> <87lguovn5f.fsf@secretsauce.net> <83mvf4d3m9.fsf@gnu.org> <87pojzci4i.fsf@secretsauce.net> <87o9zicy7w.fsf@secretsauce.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1483828110 3184 195.159.176.226 (7 Jan 2017 22:28:30 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 7 Jan 2017 22:28:30 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:50.0) Gecko/20100101 Thunderbird/50.0 Cc: mvoteiza@udel.edu, 25105@debbugs.gnu.org, npostavs@users.sourceforge.net To: Dima Kogan , Tino Calancha Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jan 07 23:28:26 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cPzT8-0007fL-GR for geb-bug-gnu-emacs@m.gmane.org; Sat, 07 Jan 2017 23:28:10 +0100 Original-Received: from localhost ([::1]:59380 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cPzTC-0001bX-SB for geb-bug-gnu-emacs@m.gmane.org; Sat, 07 Jan 2017 17:28:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54395) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cPzT4-0001aK-MJ for bug-gnu-emacs@gnu.org; Sat, 07 Jan 2017 17:28:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cPzT0-00059r-Oy for bug-gnu-emacs@gnu.org; Sat, 07 Jan 2017 17:28:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:59089) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cPzT0-00059h-LI for bug-gnu-emacs@gnu.org; Sat, 07 Jan 2017 17:28:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cPzT0-00067i-Aw for bug-gnu-emacs@gnu.org; Sat, 07 Jan 2017 17:28:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Jan 2017 22:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25105 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25105-submit@debbugs.gnu.org id=B25105.148382805623507 (code B ref 25105); Sat, 07 Jan 2017 22:28:02 +0000 Original-Received: (at 25105) by debbugs.gnu.org; 7 Jan 2017 22:27:36 +0000 Original-Received: from localhost ([127.0.0.1]:46255 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cPzSa-000675-HR for submit@debbugs.gnu.org; Sat, 07 Jan 2017 17:27:36 -0500 Original-Received: from mail-lf0-f68.google.com ([209.85.215.68]:33681) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cPzSZ-00066s-0p for 25105@debbugs.gnu.org; Sat, 07 Jan 2017 17:27:35 -0500 Original-Received: by mail-lf0-f68.google.com with SMTP id k62so6010837lfg.0 for <25105@debbugs.gnu.org>; Sat, 07 Jan 2017 14:27:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=s5S2Rsmqfx+wbyVJKsnRlCz5iBlAvplaVQpPR4FU7Vs=; b=neGKdmnKVUqzmUg3SGNGO8aCp/np0HIsq9Kmm03F1rmCHhhamNzMceVUFOSSkyRiLf szX0V46TfP9reaN/YdpA+oSbgEgjvbDp/t1n+fNuLyLq1jx0Ef5Q/qZ21KUffkgX1L6e SUClslpxZLUs7ezy8uaNZgPzLXSJg8xtS2KsBxZKqHjetiHYgdRBdmdvL+awv7NbZyFf x+rBfuR1UZIwSUkwHS9dMisfuZxCJE6n12LRBn+1TG65zRCymxme9JY0YEe91C0zafjM iUptosigl1/UYjTQwA5OM74p+rEQA7Y42G9GNjOykFR3Jv7xVZv1opjciA0j+b1av76a pGcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=s5S2Rsmqfx+wbyVJKsnRlCz5iBlAvplaVQpPR4FU7Vs=; b=b+ZlGe7laCelh2d/UEOi3gklaepQfqZzvAXHJarQz6sjtzV1Pr2ry6j3jT8TFJlrGh 13PAL4rIuzj0hJtjRnJgmRFPPBtGdvBe2HoTrYF1GbditTXAOGjeXIMCqOUNUVQLp5bd to+rD7JWIx9AtwQeqLAvufs2zX7Wq0b1j1CgzXVMXNVG6cl6VULXqhQE9ZcoHlHwv/m0 zMSGQ59zi3cwr4t/fkapmZ9D8uc3pBwLEDSUkkUZ6K8KIVQhxf6VW2IhOAPyW11XInjW cSKNJu4XWwT8ouUXKKhWIMOta1XuBWVWNr+D9x1/nugvDoQ5+zW9VHh9n0L6GhHSusyq 7Q2A== X-Gm-Message-State: AIkVDXKPrGbsuyLOZgkMR0Efe5VgZKY2PVSFXU40rELCSV4QPsykwI+AuTGXDmC6EV07dQ== X-Received: by 10.46.19.25 with SMTP id 25mr1517438ljt.15.1483828048891; Sat, 07 Jan 2017 14:27:28 -0800 (PST) Original-Received: from [192.168.1.174] ([178.252.127.239]) by smtp.googlemail.com with ESMTPSA id y26sm20153141lja.22.2017.01.07.14.27.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 07 Jan 2017 14:27:28 -0800 (PST) In-Reply-To: <87o9zicy7w.fsf@secretsauce.net> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:127888 Archived-At: On 08.01.2017 01:16, Dima Kogan wrote: > This clearly shows that it would be useful to have some binding that > jumps to the beginning of the current hunk. But that's not the same as > moving to the 'next' hunk, which is what 'n' ostensibly is supposed to > do. `n' is the easiest key to press, so it should perform navigation that the users will find most useful, in general. If the behavior does not correspond to the command name, it would be better to rename the command, or change its docstring, or etc. But I don't think `diff-hunk-next' jumping to the beginning of the first hunk when invoked at the file header, is in any way odd. After all, point wasn't inside a hunk before. > Right. The choice is whether to revert the new behavior entirely, or to > leave it in with a switch. Since we're looking at a small sample here, > it's not clear which is the right move. Note, however, that nobody else has stepped forward to explicitly support the new behavior. If you get around to polling Emacs users at your workplace, or a meetup, or so on, please let us know.