all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Dima Kogan <dima@secretsauce.net>,
	Tino Calancha <tino.calancha@gmail.com>
Cc: mvoteiza@udel.edu, 25105@debbugs.gnu.org, npostavs@users.sourceforge.net
Subject: bug#25105: 26.0.50; diff navigation is broken
Date: Sun, 8 Jan 2017 01:27:26 +0300	[thread overview]
Message-ID: <cf1697dd-2703-cf06-b3d5-d73422c8db38@yandex.ru> (raw)
In-Reply-To: <87o9zicy7w.fsf@secretsauce.net>

On 08.01.2017 01:16, Dima Kogan wrote:
> This clearly shows that it would be useful to have some binding that
> jumps to the beginning of the current hunk. But that's not the same as
> moving to the 'next' hunk, which is what 'n' ostensibly is supposed to
> do.

`n' is the easiest key to press, so it should perform navigation that 
the users will find most useful, in general.

If the behavior does not correspond to the command name, it would be 
better to rename the command, or change its docstring, or etc.

But I don't think `diff-hunk-next' jumping to the beginning of the first 
hunk when invoked at the file header, is in any way odd. After all, 
point wasn't inside a hunk before.

> Right. The choice is whether to revert the new behavior entirely, or to
> leave it in with a switch. Since we're looking at a small sample here,
> it's not clear which is the right move.

Note, however, that nobody else has stepped forward to explicitly 
support the new behavior.

If you get around to polling Emacs users at your workplace, or a meetup, 
or so on, please let us know.





  reply	other threads:[~2017-01-07 22:27 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-04 15:13 bug#25105: 26.0.50; diff navigation is broken Mark Oteiza
2016-12-04 15:27 ` npostavs
2016-12-05 15:38   ` Dima Kogan
2016-12-05 15:53     ` Dmitry Gutov
2016-12-05 16:33       ` Dima Kogan
2016-12-05 16:55         ` Mark Oteiza
2016-12-05 17:49           ` Dima Kogan
2016-12-25  6:57             ` Dima Kogan
2016-12-25 13:54               ` Mark Oteiza
2017-01-06  1:14 ` Tino Calancha
2017-01-06  1:20   ` Dima Kogan
2017-01-06  1:27     ` Dima Kogan
2017-01-06  3:06       ` Mark Oteiza
2017-01-06  3:50         ` Tino Calancha
2017-01-06  4:16         ` Dima Kogan
2017-01-06  4:43           ` Mark Oteiza
2017-01-06  7:55           ` Eli Zaretskii
2017-01-06  8:03             ` Tino Calancha
2017-01-06 14:14               ` Dmitry Gutov
2017-01-07  1:54                 ` Tino Calancha
2017-01-07  2:05                   ` Mark Oteiza
2017-01-07  9:51                 ` Dima Kogan
2017-01-07 11:16                   ` Tino Calancha
2017-01-07 22:16                     ` Dima Kogan
2017-01-07 22:27                       ` Dmitry Gutov [this message]
2017-01-06  3:09     ` Mark Oteiza
2017-01-06  4:22     ` Tino Calancha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cf1697dd-2703-cf06-b3d5-d73422c8db38@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=25105@debbugs.gnu.org \
    --cc=dima@secretsauce.net \
    --cc=mvoteiza@udel.edu \
    --cc=npostavs@users.sourceforge.net \
    --cc=tino.calancha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.