Re: elisp macros problem

[Lowell Kirsh <lkirsh@cs.ubc.ca>]

This still doesn't seem to work. With the following defun and call:

(defmacro my-add-hooks (hooks &rest body)
   `(dolist (hook ',hooks)
      (my-add-hook hook ,@body)))

(my-add-hooks (inferior-lisp lisp emacs-lisp lisp-interaction)
               (imenu-add-to-menubar "Symbols"))

I get the following macroexpansion, which looks correct to me, but 
doesn't actually do anything:

(cl-block-wrapper
  (catch (quote --cl-block-nil--)
    (let ((--dolist-temp--20870 (quote (inferior-lisp lisp emacs-lisp 
lisp-interaction)))
          hook)
      (while --dolist-temp--20870
        (setq hook (car --dolist-temp--20870))
        (my-add-hook hook
                     (imenu-add-to-menubar "Symbols"))
        (setq --dolist-temp--20870 (cdr --dolist-temp--20870)))
      nil)))


Lowell


David Kastrup wrote:

> Lowell Kirsh <lkirsh@cs.ubc.ca> writes:
> 
> 
>>Why does this not work:
>>
>>(defmacro my-add-hooks (hooks &rest body)
>>   `(dolist (hook ,hooks)
>>       (my-add-hook hook ,@body)))
>>
>>??
> 
> 
> Because you need to write
> `(dolist (hook ',hooks)
> 
> and then call this with an _unquoted_ list, like
> (my-add-hooks (lisp emacs-lisp)
>   body)
> 
> Apart from that, I consider this sort of thing a crock.  What are you
> hoping to achieve that you would not be better off doing by a proper
> function instead of a macro?
>