From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#67977: 30.0.50; tree-sitter: Emacs crashes when accessing treesit-nodes in a narrowed buffer Date: Sun, 31 Dec 2023 15:40:28 +0200 Message-ID: References: <87r0jdddxf.fsf@yandex.ru> <835y0pfkgr.fsf@gnu.org> <1DE32BF7-75D8-4F49-975D-53C782D26016@gmail.com> <08D379EF-1556-4498-8E60-F7972A25752A@gmail.com> <2141703952885@mail.yandex.ru> <10451704018554@mail.yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30938"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: Eli Zaretskii , "67977@debbugs.gnu.org" <67977@debbugs.gnu.org> To: Denis Zubarev , Yuan Fu , Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 31 14:41:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rJw4A-0007tp-Lq for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 31 Dec 2023 14:41:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rJw3t-0004xF-Pf; Sun, 31 Dec 2023 08:41:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rJw3p-0004uf-ND for bug-gnu-emacs@gnu.org; Sun, 31 Dec 2023 08:41:01 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rJw3p-0007qK-E2 for bug-gnu-emacs@gnu.org; Sun, 31 Dec 2023 08:41:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rJw3q-00039c-ID for bug-gnu-emacs@gnu.org; Sun, 31 Dec 2023 08:41:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 31 Dec 2023 13:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67977 X-GNU-PR-Package: emacs Original-Received: via spool by 67977-submit@debbugs.gnu.org id=B67977.170403004112087 (code B ref 67977); Sun, 31 Dec 2023 13:41:02 +0000 Original-Received: (at 67977) by debbugs.gnu.org; 31 Dec 2023 13:40:41 +0000 Original-Received: from localhost ([127.0.0.1]:45835 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJw3V-00038t-2J for submit@debbugs.gnu.org; Sun, 31 Dec 2023 08:40:41 -0500 Original-Received: from out3-smtp.messagingengine.com ([66.111.4.27]:56389) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJw3T-00038g-Mf for 67977@debbugs.gnu.org; Sun, 31 Dec 2023 08:40:40 -0500 Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 57DBB5C00CF; Sun, 31 Dec 2023 08:40:33 -0500 (EST) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Sun, 31 Dec 2023 08:40:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1704030033; x=1704116433; bh=26dZOkjYUrLNAIabDdBcR/E6DHbnKxAMxPKYQGAt+3Y=; b= kdqfWDMeMVrOEhDTSTOCHXXHdnQs7gRFCZPAkX9U3Fcf0ORYFJNQHdUq+0JlNck+ J6WtGLZVVxQNYJLFVQgX0LXM9LMvwShHJAWGVSNyhLPKZpMTODezDEbEsnaJYtkj +FEUawSihzMUp49IpIx6P4hm81xztsSYrlQhFxh/OFXFLPbzTSoUZ/3Xkr83jim0 MZMvza+035HX3z11DVKpQP9/8dhh2YMPFiIEeFbhaM0Mzo5dNTH9fZz4sxw+RIm8 hPIXzMgXEHVHAaYaZilbHmMHYn6OufB8KPPYoJDVMgFs5edKRWC14yrxOZcKlKeU sUWRWZx/R/fbxfa+5bJdKg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1704030033; x= 1704116433; bh=26dZOkjYUrLNAIabDdBcR/E6DHbnKxAMxPKYQGAt+3Y=; b=q ZsTt6WgBRwnoJJHJ6JfcfELGQ3hOssXHrnldd0P3ER4byyZfoa+/y1IAs8fmaMRT 4IVggs9FstKY8y8YYVDAtBSJ6nj7S37tvCl62nscIJ01VvIbJf1K43Mf/Llhtk+G 7/1dKRgJLqjEpZOZoEizXb7SP+5QIVO1ckSf2hq8dFvtQkLe1LSj81EVmq/lFYwS XUxy6k6ujO/DgeeoGkbbq/c3hJ/o0rbqVS2LNbP1e4x6ohLRUmOqNdRKeKnSZahg t1iL9B9y+fPJjJLO5/OIYMIasWoztU1iE84DCdX8VEliNQWR7Osxbn/BlNkQzTbY PgKszdNIsUSnu8lLlto9Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvdefkedgfedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtvdejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepteduleejgeehtefgheegjeekueehvdevieekueeftddvtdevfefhvdevgedu jeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 31 Dec 2023 08:40:31 -0500 (EST) Content-Language: en-US In-Reply-To: <10451704018554@mail.yandex.ru> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277144 Archived-At: On 31/12/2023 12:39, Denis Zubarev wrote: > Also there were errors when running benchmark in the narrowed buffer: > Error muted by safe_call: (internal--syntax-propertize 1482) signaled > (args-out-of-range 1 1872) That does look like a bug. The patch below seems to fix it: diff --git a/lisp/treesit.el b/lisp/treesit.el index 264b95dc3a3..46ebadcf057 100644 --- a/lisp/treesit.el +++ b/lisp/treesit.el @@ -1150,7 +1150,7 @@ treesit--pre-syntax-ppss (if (and new-start (< new-start start)) (progn (setq treesit--syntax-propertize-start nil) - (cons new-start end)) + (cons (max new-start (point-min)) end)) nil))) ;;; Indent Or maybe syntax-propertize itself should have a protection against going outside of bounds: diff --git a/lisp/emacs-lisp/syntax.el b/lisp/emacs-lisp/syntax.el index e35992298a6..61a9e79b59c 100644 --- a/lisp/emacs-lisp/syntax.el +++ b/lisp/emacs-lisp/syntax.el @@ -431,7 +431,7 @@ syntax-propertize (if (or (null new) (and (>= (car new) start) (<= (cdr new) end))) nil - (setq start (car new)) + (setq start (max (car new) (point-min))) (setq end (cdr new)) ;; If there's been a change, we should go through the ;; list again since this new position may