From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#44424: [PATCH] 28.0.50; Use bespoke face for commit message in vc-print-root-log Date: Sat, 28 Nov 2020 20:13:38 +0200 Message-ID: References: <87eela9wx9.fsf@protesilaos.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2987"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 To: Protesilaos Stavrou , 44424@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 28 19:14:18 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kj4jh-0000jA-Lw for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 28 Nov 2020 19:14:17 +0100 Original-Received: from localhost ([::1]:55552 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kj4jg-00064N-Nn for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 28 Nov 2020 13:14:16 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48810) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kj4jT-00062H-ER for bug-gnu-emacs@gnu.org; Sat, 28 Nov 2020 13:14:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37466) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kj4jS-0004EZ-JP for bug-gnu-emacs@gnu.org; Sat, 28 Nov 2020 13:14:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kj4jS-0005yx-FL for bug-gnu-emacs@gnu.org; Sat, 28 Nov 2020 13:14:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Nov 2020 18:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44424 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch fixed Original-Received: via spool by 44424-submit@debbugs.gnu.org id=B44424.160658723022969 (code B ref 44424); Sat, 28 Nov 2020 18:14:02 +0000 Original-Received: (at 44424) by debbugs.gnu.org; 28 Nov 2020 18:13:50 +0000 Original-Received: from localhost ([127.0.0.1]:49012 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kj4jG-0005yP-6I for submit@debbugs.gnu.org; Sat, 28 Nov 2020 13:13:50 -0500 Original-Received: from mail-ej1-f51.google.com ([209.85.218.51]:33479) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kj4jD-0005yC-Le for 44424@debbugs.gnu.org; Sat, 28 Nov 2020 13:13:48 -0500 Original-Received: by mail-ej1-f51.google.com with SMTP id 7so12429746ejm.0 for <44424@debbugs.gnu.org>; Sat, 28 Nov 2020 10:13:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=vgY84/TGokZK4TXB0+a6pEOzC+A/fv2toj5gYW+YgdY=; b=fwjY8Qj4NqEyNnLpQv4X1wKAqbKPne9JKNPG5ePi+ccdMTDqVqnuoxL9RHyJ4+PkXi 8YYSV5SnNOb8929SkPptIo0w5ipKFLzXsk8SIWvxY9v02UCTcja3tqs0ot8jd/Gsd74D QuZf5UUrD3KeZFMlzlNlKOUg8yPG02kKmUgE1OUTWanscFIgepJDrQtePpdbubb1vg+Q ejk/KYMHqu1eB4TbErrzFsVNv6vubNbUems3/hQSL8ho6ew542xZNkiDyoXMQAoMfHQo PopDRlxlDjqx6nQcNrYbZrCPBc4DQyMcb0vuwOm3UzAyvzJy/0XY6CH6/dnJIZVU4fXJ 0Yog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=vgY84/TGokZK4TXB0+a6pEOzC+A/fv2toj5gYW+YgdY=; b=fCF06/S0pYiz4A/GmxEgMyayaaBeFxQEsCVs/buOebr4BQiNp5n1l0ZrTGUeBPOR/s uyQGIJ5BAAzoJ8bPwZ5/6nsqGwyF5cwx7g0/bPdTdSU87PyAsnmVZAm79fladIqzqqLV itv2Ero5DbQub9ng2/5RQsK9dXluPt+hI1cbAN2H8yUe0xGTNOL151mmc40HyIvLp2M9 b1qfqx2tCmfQ1XpdiDL7fW7dvm8dK9FuQLY5Nt4hpBEwtv5Q9MFIrYzFY7nIccpoLZgS Ybpu4DKrv2Ym662u8RztGa2rPdJJGCkBDGo/yMv2D3xCgyrME9j+LkWwOCYdTY5uSt6i YrRw== X-Gm-Message-State: AOAM5304FiACNxj3bih65F2tp0byfK6TMButbnHRI2PoYgqaH+EfonXO KJSlh1HfZfJ2pR5Oh2gJtwvlxO1kSaYXXw== X-Google-Smtp-Source: ABdhPJziuos8biBWqeoqgfwnUZZ3QB7KJdsc8peithRL6/hkOl7YXOwvOx5LI7zRCSltghNDyFu67g== X-Received: by 2002:a17:906:4705:: with SMTP id y5mr13264835ejq.112.1606587221489; Sat, 28 Nov 2020 10:13:41 -0800 (PST) Original-Received: from [192.168.0.4] ([66.205.71.3]) by smtp.googlemail.com with ESMTPSA id c4sm6564030ejx.9.2020.11.28.10.13.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 28 Nov 2020 10:13:40 -0800 (PST) In-Reply-To: <87eela9wx9.fsf@protesilaos.com> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:194494 Archived-At: On 03.11.2020 19:23, Protesilaos Stavrou wrote: > What do you think? I think the idea is good, but the change in the looks is a bit questionable. Can we do it without the grey background? It's kind of weird to see it surrounded by "unexpanded" log entries that use the default white background. And other windows that mostly use the white background. As we can see on the screenshots you posted yourself, the "before" one looks more uniform than the "after". If there are no alternative ideas on which colors to pick, we can just inherit from font-lock-comment-face, to retain the previous looks.