From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#64735: 29.0.92; find invocations are ~15x slower because of ignores Date: Fri, 21 Jul 2023 22:53:58 +0300 Message-ID: References: <1fd5e3ed-e1c3-5d6e-897f-1d5d55e379fa@gutov.dev> <87wmyupvlw.fsf@localhost> <5c4d9bea-3eb9-b262-138a-4ea0cb203436@gutov.dev> <87tttypp2e.fsf@localhost> <837cqu35lw.fsf@gnu.org> <87o7k6pmk3.fsf@localhost> <834jly351p.fsf@gnu.org> <87lefapkdx.fsf@localhost> <831qh230h5.fsf@gnu.org> <87wmyu8mi0.fsf@localhost> <83wmyu1l1k.fsf@gnu.org> <87ttty8l73.fsf@localhost> <6f55b301-7610-ee4a-996e-fc6a8db33c33@gutov.dev> <87y1j9l8u2.fsf@localhost> <0c6f4daf-ea8a-0636-1b51-f4640ff39834@gutov.dev> <87jzutl76e.fsf@localhost> <87h6pxl6m4.fsf@localhost> <87351hl0yj.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34129"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: sbaugh@janestreet.com, Eli Zaretskii , 64735@debbugs.gnu.org To: Ihor Radchenko Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 21 21:55:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qMwDd-0008YV-3w for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 21 Jul 2023 21:55:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qMwDQ-00052k-BG; Fri, 21 Jul 2023 15:55:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qMwDO-00052b-RO for bug-gnu-emacs@gnu.org; Fri, 21 Jul 2023 15:55:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qMwDO-0000cA-7l for bug-gnu-emacs@gnu.org; Fri, 21 Jul 2023 15:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qMwDN-0003v5-SU for bug-gnu-emacs@gnu.org; Fri, 21 Jul 2023 15:55:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Jul 2023 19:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64735 X-GNU-PR-Package: emacs Original-Received: via spool by 64735-submit@debbugs.gnu.org id=B64735.168996925315012 (code B ref 64735); Fri, 21 Jul 2023 19:55:01 +0000 Original-Received: (at 64735) by debbugs.gnu.org; 21 Jul 2023 19:54:13 +0000 Original-Received: from localhost ([127.0.0.1]:34952 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMwCa-0003u2-CD for submit@debbugs.gnu.org; Fri, 21 Jul 2023 15:54:13 -0400 Original-Received: from out3-smtp.messagingengine.com ([66.111.4.27]:49719) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMwCV-0003tn-8T for 64735@debbugs.gnu.org; Fri, 21 Jul 2023 15:54:11 -0400 Original-Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 1A8ED5C0090; Fri, 21 Jul 2023 15:54:02 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Fri, 21 Jul 2023 15:54:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1689969242; x=1690055642; bh=8mRF5AHmBaLcWh8sMzoKBdXdlWWQdYJHgWG pCGKqgTo=; b=eEswCrQ4nYKMug5OWTkKNlgZNcLyLsi5E/8Q5f1pOWBeXh1CtEM g6TBT2CekwD8LtU8Q5tYcJ8HhzovCIKkagUShdUyIaX5Rjxz0VNrIlJupDqcvvV8 s53Q2ZToRJa4BVVae6CHQUbX17BKjy7OU3kuqBLzS8tHR7rjloTW2eCk7+O7sW2M +P1IU1cPgretTRCo9WtEL43QRqfCTYkbhx2bTK9qzSuPwhpUmno3gDB+90xWT4PU aKSf+Ceduvyn5zCREx71YDrfp8jkMwUrkB004KjdTMufgaxdjXpVbeh9+NPX7mSM g7VZs4grEerjiXA8guTOMH5XPG5TSB/0U3A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1689969242; x=1690055642; bh=8mRF5AHmBaLcWh8sMzoKBdXdlWWQdYJHgWG pCGKqgTo=; b=UMAypXmwtfRwPlDeOHuYtgF3oO5foss62miweR6xPMGS8Vz/EX1 7SV7BPHS2zwGOBhnHyf08uOHjgwrKxBPnplIW0jEX1OuVk1HbipIAq8iPmV/8xE/ 2Aw9oggQ0hjXoISQWHa6K2vr4yeIogs0OHLL2Ut8cp/ZHRCfD2CT0LmSUR24TOXs Vn9+Od7DGv0jnde16yx81Z23keKnjSXbvF+VCOsfJRQyKbmHQRVRMrHtnYlgnmWE l4JhI4t6hvwJCnoRH1ZQ5UKME96A/JPRLvdxFDo5ZGDDzhbPAAh/W5tCjVGWrmoc KJPvN3Ky/kE3H7qEpPXUXoZuFII3u0EFP/A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrhedvgddufeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepiefgteevheevveffheeltdeukeeiieekueefgedugfefgefhudelgfefveel vdevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 21 Jul 2023 15:54:00 -0400 (EDT) Content-Language: en-US In-Reply-To: <87351hl0yj.fsf@localhost> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265761 Archived-At: On 21/07/2023 18:48, Ihor Radchenko wrote: > Dmitry Gutov writes: > >>> Locally, AFAIU, running `find-lisp-find-files' without >>> `file-name-handler-alist' is equivalent to running GNU find. >>> (That was a reply to Eli's message that we cannot disable >>> `file-name-handler-alist') >> >> But it's slower! At least 2x, even with file handlers disabled. >> According to your own measurements, with a modern SSD (not to mention >> all of our users with spinning media). > > Yes, but (1) there is room for optimization; (2) I have a hope that we > can implement better "ignores" when using `find-lisp-find-files', thus > eventually outperforming GNU find (when used with large number of > ignores). There are natural limits to that optimization, if the approach is to generate the full list of files in Lisp, and then filter it out programmatically: every file name will need to be allocated. That's a lot of unnecessary consing. But you're welcome to try it and report back with results. Tramp is easy to disable, so you should be fine in terms of infrastructure.