Re: master 9074a9f496b: Add customization to let EWW guess content-type if needed

Re: master 9074a9f496b: Add customization to let EWW guess content-type if needed

[Michael Albinus]

Jim Porter <jporterbugs@gmail.com> writes:

Hi Sebastián, Jim,

>     Add customization to let EWW guess content-type if needed
>     
>     * lisp/net/eww.el (eww-guess-content-type-functions): New user option.
>     (eww--guess-content-type, eww--html-if-doctype): New functions.
>     (eww-render): Call 'eww--guess-content-type' (bug#73133).
> ---
>  lisp/net/eww.el | 39 ++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 38 insertions(+), 1 deletion(-)

This fails eww-tests:

--8<---------------cut here---------------start------------->8---
# make -C test eww-tests
make: Entering directory '/home/albinus/src/emacs/test'
make[1]: Entering directory '/home/albinus/src/emacs/test'
  ELC+ELN  lisp/net/eww-tests.elc
  GEN      lisp/net/eww-tests.log
Running 9 tests (2024-10-22 11:31:05+0200, selector `(not (tag :unstable))')
   passed  1/9  eww-test/display/html (0.292603 sec)
   passed  2/9  eww-test/history/back-forward (0.001062 sec)
   passed  3/9  eww-test/history/before-navigate/clone-previous (0.001303 sec)
   passed  4/9  eww-test/history/before-navigate/delete-future-history (0.001374 sec)
   passed  5/9  eww-test/history/before-navigate/ignore-history (0.001349 sec)
   passed  6/9  eww-test/history/new-page (0.000828 sec)
Test eww-test/history/reload-in-place backtrace:
  signal(ert-test-failed (((should (equal (plist-get (nth 1 eww-histor
  ert-fail(((should (equal (plist-get (nth 1 eww-history) :text) "http
  (if (unwind-protect (setq value-96 (apply fn-94 args-95)) (setq form
  (let (form-description-98) (if (unwind-protect (setq value-96 (apply
  (let ((value-96 'ert-form-evaluation-aborted-97)) (let (form-descrip
  (let* ((fn-94 #'equal) (args-95 (condition-case err (list (plist-get
  (progn (eww-mode) (eww "one.invalid") (eww "two.invalid") (eww "thre
  (unwind-protect (progn (eww-mode) (eww "one.invalid") (eww "two.inva
  (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn
  (let ((temp-buffer (generate-new-buffer " *temp*" t))) (save-current
  (progn (fset 'eww-retrieve vnew) (let ((temp-buffer (generate-new-bu
  (unwind-protect (progn (fset 'eww-retrieve vnew) (let ((temp-buffer 
  (let* ((vnew #'(lambda (url callback args) (let ((temp-buffer ...)) 
  #f(lambda () [t] (let* ((vnew #'...) (old (symbol-function ...))) (u
  #f(compiled-function () #<bytecode -0x9bf804316f473b1>)()
  handler-bind-1(#f(compiled-function () #<bytecode -0x9bf804316f473b1
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name eww-test/history/reload-in-place :doc
  ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
  ert-run-tests((not (tag :unstable)) #f(compiled-function (event-type
  ert-run-tests-batch((not (tag :unstable)))
  ert-run-tests-batch-and-exit((not (tag :unstable)))
  eval((ert-run-tests-batch-and-exit '(not (tag :unstable))) t)
  command-line-1(("-L" ":." "-l" "ert" "--eval" "(setq treesit-extra-l
  command-line()
  normal-top-level()
Test eww-test/history/reload-in-place condition:
    (ert-test-failed
     ((should (equal (plist-get ... :text) "http://two.invalid/")) :form
      (equal "\nhttp://two.invalid/" "http://two.invalid/") :value nil
      :explanation
      (arrays-of-different-length 20 19 "\nhttp://two.invalid/"
				  "http://two.invalid/" first-mismatch-at
				  0)))
   FAILED  7/9  eww-test/history/reload-in-place (0.001007 sec) at lisp/net/eww-tests.el:116
   passed  8/9  eww-test/readable/default-readable (0.001255 sec)
   passed  9/9  eww-test/readable/toggle-display (0.002841 sec)

Ran 9 tests, 8 results as expected, 1 unexpected (2024-10-22 11:31:07+0200, 1.828562 sec)

1 unexpected results:
   FAILED  eww-test/history/reload-in-place
--8<---------------cut here---------------end--------------->8---

Re: master 9074a9f496b: Add customization to let EWW guess content-type if needed

[Jim Porter]

On 10/22/2024 2:35 AM, Michael Albinus wrote:
> Jim Porter <jporterbugs@gmail.com> writes:
> 
> Hi Sebastián, Jim,
> 
>>      Add customization to let EWW guess content-type if needed
>>      
>>      * lisp/net/eww.el (eww-guess-content-type-functions): New user option.
>>      (eww--guess-content-type, eww--html-if-doctype): New functions.
>>      (eww-render): Call 'eww--guess-content-type' (bug#73133).
>> ---
>>   lisp/net/eww.el | 39 ++++++++++++++++++++++++++++++++++++++-
>>   1 file changed, 38 insertions(+), 1 deletion(-)
> 
> This fails eww-tests:

Whoops, forgot about those tests. Fixed with f58652a4197.

Re: master 9074a9f496b: Add customization to let EWW guess content-type if needed

[Michael Albinus]

Jim Porter <jporterbugs@gmail.com> writes:

Hi Jim,

> Whoops, forgot about those tests. Fixed with f58652a4197.

Thanks!

Best regards, Michael.