From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jens Schmidt Newsgroups: gmane.emacs.devel Subject: Re: master 3b1fd42732f: * lisp/loadup.el: Check advice after `rmc.el`; turn error into warning Date: Thu, 14 Dec 2023 00:03:16 +0100 Message-ID: References: <170197287539.12661.7539324399514249195@vcs2.savannah.gnu.org> <20231207181435.BCB79C0C6AD@vcs2.savannah.gnu.org> <73d5b60d-afbd-4543-8001-9fe043b4b6ab@vodafonemail.de> <83wmtis4tt.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------l2v1eqSMUnBG3xpXGaG7tY4S" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31066"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: emacs-devel@gnu.org, monnier@iro.umontreal.ca To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Dec 14 00:05:06 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rDYHq-0007rU-Az for ged-emacs-devel@m.gmane-mx.org; Thu, 14 Dec 2023 00:05:06 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rDYGn-0000Yx-J9; Wed, 13 Dec 2023 18:04:01 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rDYGl-0000Ya-Sy for emacs-devel@gnu.org; Wed, 13 Dec 2023 18:03:59 -0500 Original-Received: from mr5.vodafonemail.de ([145.253.228.165]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rDYGj-0003vO-Ar; Wed, 13 Dec 2023 18:03:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vodafonemail.de; s=vfde-mb-mr2-23sep; t=1702508624; bh=XqwTP1M/1qs77YHyq5YFmfJpVL5WsHRpq8p1/U6y4Nk=; h=Content-Type:Message-ID:Date:User-Agent:From:Subject:To: References:Content-Language:In-Reply-To:From; b=p4t9blZUwn+CaJhPsnOoWUD5KXFc/N0hc/QzW+X6Zc/SKt/L2B8qF3m3frFLq0jav 8r3RYW3TOuBkEHObfNoi3m9hDD8Bv9W2g+Dv1amoQPUin2GE3Sf5GF1Dx6E+voQJoj IJ/l+QIKJjlyzaMy6BV3iyT9HJ34PBU1M9ZGdth8= Original-Received: from smtp.vodafone.de (unknown [10.0.0.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mr5.vodafonemail.de (Postfix) with ESMTPS id 4Sr9yS3vWvz1yGd; Wed, 13 Dec 2023 23:03:44 +0000 (UTC) Original-Received: from [192.168.178.41] (port-92-196-121-220.dynamic.as20676.net [92.196.121.220]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp.vodafone.de (Postfix) with ESMTPSA id 4Sr9yF5KglzMm7J; Wed, 13 Dec 2023 23:03:30 +0000 (UTC) Content-Language: de-DE-frami, en-US In-Reply-To: <83wmtis4tt.fsf@gnu.org> X-purgate-type: clean X-purgate: clean X-purgate-size: 5519 X-purgate-ID: 155817::1702508620-4AFFC6E3-B5AE4CF9/0/0 Received-SPF: pass client-ip=145.253.228.165; envelope-from=jschmidt4gnu@vodafonemail.de; helo=mr5.vodafonemail.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:313751 Archived-At: This is a multi-part message in MIME format. --------------l2v1eqSMUnBG3xpXGaG7tY4S Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2023-12-13 12:46, Eli Zaretskii wrote: >> Date: Tue, 12 Dec 2023 22:48:56 +0100 >> From: Jens Schmidt >> >> So probably TRT here would be to place these paragraphs as follows: >> >> 0. (load "leim/leim-list.el" t) >> >> 1. (load "emacs-lisp/rmc") >> >> 2. Check for advices (on core libs only). >> >> 3. (load "site-load" t) >> >> 4. "default-directory must be unibyte" >> >> What do you think? > > I think you are right about rmc, but leim-list should be after rmc, > not before. Is rmc (technically) required at all in loadup.el? I tried bootstrap'ping and check'ing with the attached patch, and these come through fine. rmc.el provides autoloaded function `read-multiple-choice', which is called from `kill-buffer--possibly-save' (defined in simple.el), which is called from Fkill_buffer (defined in buffer.c), but only during interactive use. Of course, killing buffers is everyday business, but autoloading "rmc" while prompting for user input should be neglectable, shouldn't it? And during bootstrap everything should be noninteractive, so "rmc" wouldn't be required at that time, would it? And do I get a free wish from Eli when I help reducing preloaded libs? --------------l2v1eqSMUnBG3xpXGaG7tY4S Content-Type: text/x-patch; charset=UTF-8; name="0001-Remove-preload-of-rmc-from-loadup.el.patch" Content-Disposition: attachment; filename="0001-Remove-preload-of-rmc-from-loadup.el.patch" Content-Transfer-Encoding: base64 RnJvbSA5ZTgxY2YxYzdlYzU0NzA5OGNlN2FkYTI2MGIxMTZhNTI0MmJkZTcyIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKZW5zIFNjaG1pZHQgPGpzY2htaWR0NGdudUB2b2Rh Zm9uZW1haWwuZGU+CkRhdGU6IFdlZCwgMTMgRGVjIDIwMjMgMjI6MTE6MzIgKzAxMDAKU3Vi amVjdDogW1BBVENIXSA7IFJlbW92ZSBwcmVsb2FkIG9mIHJtYyBmcm9tIGxvYWR1cC5lbAoK U2VlIGRpc2N1c3Npb24gb24KaHR0cHM6Ly9saXN0cy5nbnUub3JnL2FyY2hpdmUvaHRtbC9l bWFjcy1kZXZlbC8yMDIzLTEyL21zZzAwMzA5Lmh0bWwuCgoqIGxpc3AvbG9hZHVwLmVsICgi ZW1hY3MtbGlzcC9ybWMiKTogUmVtb3ZlIHByZWxvYWQuCiogbGlzcC9maWxlcy5lbCAocmVh ZC1tdWx0aXBsZS1jaG9pY2UpOgoqIGxpc3Avc2ltcGxlLmVsIChyZWFkLW11bHRpcGxlLWNo b2ljZSk6IERlY2xhcmUgZnVuY3Rpb24uCiogbGlzcC9sb2FkdXAuZWw6IE1ha2UgdGhlIHdh cm5pbmcgb24gYWR2aXNlZCBwcmVsb2FkZWQgZnVuY3Rpb25zIGEKdGFkIG5vaXNpZXIuCi0t LQogbGlzcC9maWxlcy5lbCAgfCAzICsrKwogbGlzcC9sb2FkdXAuZWwgfCA1ICstLS0tCiBs aXNwL3NpbXBsZS5lbCB8IDMgKysrCiAzIGZpbGVzIGNoYW5nZWQsIDcgaW5zZXJ0aW9ucygr KSwgNCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL2ZpbGVzLmVsIGIvbGlzcC9m aWxlcy5lbAppbmRleCBmODdlNzgwNzMwMS4uNGVlNzYxNGY5OWEgMTAwNjQ0Ci0tLSBhL2xp c3AvZmlsZXMuZWwKKysrIGIvbGlzcC9maWxlcy5lbApAQCAtMjI5Nyw2ICsyMjk3LDkgQEAg ZmlsZXMtLWFzay11c2VyLWFib3V0LWxhcmdlLWZpbGUtaGVscC10ZXh0CiAgICBvcC10eXBl CiAgICBvcC10eXBlKSkKIAorKGRlY2xhcmUtZnVuY3Rpb24gcmVhZC1tdWx0aXBsZS1jaG9p Y2UgImVtYWNzLWxpc3Avcm1jIgorICAgICAgICAgICAgICAgICAgKHByb21wdCBjaG9pY2Vz ICZvcHRpb25hbCBoZWxwLXN0cmluZyBzaG93LWhlbHAgbG9uZy1mb3JtKSkKKwogKGRlZnVu IGZpbGVzLS1hc2stdXNlci1hYm91dC1sYXJnZS1maWxlIChzaXplIG9wLXR5cGUgZmlsZW5h bWUgb2ZmZXItcmF3KQogICAiUXVlcnkgdGhlIHVzZXIgYWJvdXQgd2hhdCB0byBkbyB3aXRo IGxhcmdlIGZpbGVzLgogRmlsZXMgYXJlIFwibGFyZ2VcIiBpZiBmaWxlIFNJWkUgaXMgbGFy Z2VyIHRoYW4gYGxhcmdlLWZpbGUtd2FybmluZy10aHJlc2hvbGQnLgpkaWZmIC0tZ2l0IGEv bGlzcC9sb2FkdXAuZWwgYi9saXNwL2xvYWR1cC5lbAppbmRleCAxZjk1OTQ2NGIyMy4uZGUx OTM0ZTkyOTkgMTAwNjQ0Ci0tLSBhL2xpc3AvbG9hZHVwLmVsCisrKyBiL2xpc3AvbG9hZHVw LmVsCkBAIC00MDYsOSArNDA2LDYgQEAKICAgICAgIChtZXNzYWdlICJXYXJuaW5nOiBDaGFu Z2UgaW4gbG9hZC1wYXRoIGR1ZSB0byBzaXRlLWxvYWQgd2lsbCBiZSBcCiBsb3N0IGFmdGVy IGR1bXBpbmciKSkpCiAKLTs7IFVzZWQgYnkgYGtpbGwtYnVmZmVyJywgZm9yIGluc3RhbmNl LgotKGxvYWQgImVtYWNzLWxpc3Avcm1jIikKLQogOzsgQWN0aXZlbHkgY2hlY2sgZm9yIGFk dmlzZWQgZnVuY3Rpb25zIGR1cmluZyBwcmVsb2FkIHNpbmNlOgogOzsgLSBhZHZpY2VzIGlu IEVtYWNzJ3MgY29yZSBhcmUgZ2VuZXJhbGx5IGNvbnNpZGVyZWQgYmFkIHN0eWxlOwogOzsg LSBgU25hcmYtZG9jdW1lbnRhdGlvbicgbG9vc2VzIGRvY3N0cmluZ3Mgb2YgcHJpbWl0aXZl cyBhZHZpc2VkCkBAIC00MTksNyArNDE2LDcgQEAKICAgICAgICAgOzsgRG9uJ3QgbWFrZSBp dCBhbiBlcnJvciBiZWNhdXNlIGl0J3Mgbm90IHNlcmlvdXMgZW5vdWdoIGFuZAogICAgICAg ICA7OyBpdCBjYW4gYmUgYW5ub3lpbmcgZHVyaW5nIGRldmVsb3BtZW50LiAgQWxzbyB0aGVy ZSBhcmUgc3RpbGwKICAgICAgICAgOzsgY2lyY3Vtc3RhbmNlcyB3aGVyZSB3ZSB1c2UgYWR2 aWNlIG9uIHByZWxvYWRlZCBmdW5jdGlvbnMuCi0gICAgICAgIChtZXNzYWdlICJXYXJuaW5n OiBBZHZpY2UgaW5zdGFsbGVkIG9uIHByZWxvYWRlZCBmdW5jdGlvbiAlUyIgZikpKSkKKyAg ICAgICAgKG1lc3NhZ2UgIlxuV2FybmluZzogQWR2aWNlIGluc3RhbGxlZCBvbiBwcmVsb2Fk ZWQgZnVuY3Rpb24gJVMiIGYpKSkpCiAKIDs7IE1ha2Ugc3VyZSBkZWZhdWx0LWRpcmVjdG9y eSBpcyB1bmlieXRlIHdoZW4gZHVtcGluZy4gIFRoaXMgaXMKIDs7IGJlY2F1c2Ugd2UgY2Fu bm90IGRlY29kZSBhbmQgZW5jb2RlIGl0IGNvcnJlY3RseSAoc2luY2UgdGhlIGxvY2FsZQpk aWZmIC0tZ2l0IGEvbGlzcC9zaW1wbGUuZWwgYi9saXNwL3NpbXBsZS5lbAppbmRleCBjZWUx ZGRhYzUyZi4uNzFjZWRkNmNiMTcgMTAwNjQ0Ci0tLSBhL2xpc3Avc2ltcGxlLmVsCisrKyBi L2xpc3Avc2ltcGxlLmVsCkBAIC0xMTA5Myw2ICsxMTA5Myw5IEBAIHNjcmF0Y2gtYnVmZmVy CiAgIChpbnRlcmFjdGl2ZSkKICAgKHBvcC10by1idWZmZXItc2FtZS13aW5kb3cgKGdldC1z Y3JhdGNoLWJ1ZmZlci1jcmVhdGUpKSkKIAorKGRlY2xhcmUtZnVuY3Rpb24gcmVhZC1tdWx0 aXBsZS1jaG9pY2UgImVtYWNzLWxpc3Avcm1jIgorICAgICAgICAgICAgICAgICAgKHByb21w dCBjaG9pY2VzICZvcHRpb25hbCBoZWxwLXN0cmluZyBzaG93LWhlbHAgbG9uZy1mb3JtKSkK KwogKGRlZnVuIGtpbGwtYnVmZmVyLS1wb3NzaWJseS1zYXZlIChidWZmZXIpCiAgICJBc2sg dGhlIHVzZXIgdG8gY29uZmlybSBraWxsaW5nIG9mIGEgbW9kaWZpZWQgQlVGRkVSLgogCi0t IAoyLjMwLjIKCg== --------------l2v1eqSMUnBG3xpXGaG7tY4S--