From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Charalampos Mitrodimas Newsgroups: gmane.emacs.bugs Subject: bug#17219: 24.3.50; wrong alignment when a list is given to dired Date: Mon, 23 Dec 2024 18:20:23 +0000 Message-ID: References: <877g71yrdc.fsf@yahoo.fr> <87a5cn77dx.fsf@kubajecminek.cz> <240007c8-70a4-432f-a28d-bcf9662ad757@posteo.net> <87ikramglo.fsf@kubajecminek.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17466"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Nicolas Richard , Eli Zaretskii , 17219@debbugs.gnu.org To: Jakub =?UTF-8?Q?Je=C4=8Dm=C3=ADnek?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 23 19:21:22 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tPn3R-0004Md-TM for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 23 Dec 2024 19:21:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tPn3A-0000u2-Ft; Mon, 23 Dec 2024 13:21:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tPn38-0000tY-RI for bug-gnu-emacs@gnu.org; Mon, 23 Dec 2024 13:21:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tPn38-0002GZ-Bj for bug-gnu-emacs@gnu.org; Mon, 23 Dec 2024 13:21:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:From:References:MIME-Version:Date:To:Subject; bh=5wsVOlStraWYHBOF+QuivB92fhStT60F+1xym80fc5c=; b=skwYHXbhMt3LrKelxhmvsQuYabaqOVK1uKZbM+dkVxJwC8t6wYVX/d7U2UlEonYvXRC28tXITjKh45X55Ax+MNwM/LLhtrQwQgLRcIlla1MNa2cyF63Z/7JAqAegHcTYUhzMElkwg9WI5N3FAtW11/47js9GFM0Qug5oLQShKngIVSrO0R6GiatteeSYrCX9xFb/4RXzknZLdtIr1ZikDa+RcIXLmyMzyK/ozmRpIFYnxo5dc4xh3ag6spkdD91UHn/XLS/1SEt+NW2dPKEA1iGPWUmeRk8NSCS6DltpfvNpVDiXp3GNAJtpKMk17/hU7lfDWwDCbsh8B8jc4PpSmg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tPn37-0002zU-Tp for bug-gnu-emacs@gnu.org; Mon, 23 Dec 2024 13:21:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Charalampos Mitrodimas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 23 Dec 2024 18:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17219 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 17219-submit@debbugs.gnu.org id=B17219.173497803611444 (code B ref 17219); Mon, 23 Dec 2024 18:21:01 +0000 Original-Received: (at 17219) by debbugs.gnu.org; 23 Dec 2024 18:20:36 +0000 Original-Received: from localhost ([127.0.0.1]:56144 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tPn2i-0002yV-1g for submit@debbugs.gnu.org; Mon, 23 Dec 2024 13:20:36 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]:57165) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tPn2e-0002yC-L5 for 17219@debbugs.gnu.org; Mon, 23 Dec 2024 13:20:34 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 27C66240101 for <17219@debbugs.gnu.org>; Mon, 23 Dec 2024 19:20:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1734978026; bh=c3umozFy5GcH0RNDoyLv3dnBpmvmCJuN3df8Whu4Bd8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:From:Content-Type: Content-Transfer-Encoding:From; b=OnXr9lsqYBK6l5bvrbxlhKByGnyzior6yCrwR65+uAg90GLIWHY8WGu+mBmP5YexR 7cZ0E5VZnOJjyTKvNlo2iVCeLYLgNaCbjp4Qj0iBQdXyL4+IIWr2d/3ntITAp0Ez8Y tMpHiqaA8VhpIjrPylj9R//6nz8S/nVlKGdZ7y73HNW/TBmAiXrPejR8sFYKmy9e+M VJ1IwVUkTznR8ztd+D2jR9s+xUahFCltzZVGJZtmuVYxM0AyStNbyFB3KNaTUtMoGM Jy2nc1N8zIEw8NV196O/VRBL8ag69tH9PhKAcW/P+Smb82o7FJAvPqyiTWya8Nx2Tu slyWZNSE6wdlg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4YH5t1148Bz9rxM; Mon, 23 Dec 2024 19:20:25 +0100 (CET) Content-Language: en-US In-Reply-To: <87ikramglo.fsf@kubajecminek.cz> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:297658 Archived-At: Thanks Jakub! On 12/23/24 19:52, Jakub Ječmínek via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote: > Hello, > > "Charalampos Mitrodimas" writes: > >> What about performance? Depending on the size of the directory, >> recalculating alignment could have a minor performance impact. > There is. The largest directory I have on my machine has around 18k > files (~5GB) and the penalty is around 20ms. I've run the tests for both > functions in standalone Emacs session started using 'emacs -Q'. Below > are the profiling results: > > Function Name Call Count Elapsed Time Average Time > -------------------------------------------------------- > dired-revert-new 10 5.2096629750 0.5209662975 > dired-revert-old 10 5.051716523 0.5051716522 > > dired-revert-new 25 11.843308944 0.4737323577 > dired-revert-old 25 11.391448779 0.4556579511 > > > Please let me know if that's too high so we can find another way. If my math doesn't deceive me, the performance penalty ranges between 3.13% (10 calls) and 3.97% (25 calls) based on the profiling results, which I find acceptable. -- C. Mitrodimas