From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#71655: Eshell external commands do not work under GNU Emacs for Windows Date: Sun, 7 Jul 2024 20:26:17 -0700 Message-ID: References: <86y170oifx.fsf@gnu.org> <86v824ohym.fsf@gnu.org> <86r0csnrk7.fsf@gnu.org> <8b97b729-c431-1dc2-d4d4-b988120e7de0@gmail.com> <86cyocnjkl.fsf@gnu.org> <858d2907-7ee4-da6f-cd9e-6b7bd3ba4c7e@gmail.com> <86pls8ff73.fsf@gnu.org> <875xtyyjcv.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7944"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 71655-done@debbugs.gnu.org, james@literate-devops.io To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jul 08 05:28:27 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sQf3C-0001x3-Rj for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 08 Jul 2024 05:28:26 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sQf2l-0005G7-Vl; Sun, 07 Jul 2024 23:28:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sQf2k-0005Fn-LD for bug-gnu-emacs@gnu.org; Sun, 07 Jul 2024 23:27:58 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sQf2k-0006l4-Cu for bug-gnu-emacs@gnu.org; Sun, 07 Jul 2024 23:27:58 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sQf2o-0007cO-NV for bug-gnu-emacs@gnu.org; Sun, 07 Jul 2024 23:28:02 -0400 Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Jul 2024 03:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 71655 X-GNU-PR-Package: emacs Mail-Followup-To: 71655@debbugs.gnu.org, jporterbugs@gmail.com, james@literate-devops.io Original-Received: via spool by 71655-done@debbugs.gnu.org id=D71655.172040925129242 (code D ref 71655); Mon, 08 Jul 2024 03:28:02 +0000 Original-Received: (at 71655-done) by debbugs.gnu.org; 8 Jul 2024 03:27:31 +0000 Original-Received: from localhost ([127.0.0.1]:49392 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sQf2J-0007ba-0R for submit@debbugs.gnu.org; Sun, 07 Jul 2024 23:27:31 -0400 Original-Received: from mail-pl1-f182.google.com ([209.85.214.182]:43016) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sQf2H-0007bM-6x for 71655-done@debbugs.gnu.org; Sun, 07 Jul 2024 23:27:29 -0400 Original-Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-1faad2f1967so29794835ad.0 for <71655-done@debbugs.gnu.org>; Sun, 07 Jul 2024 20:27:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720409179; x=1721013979; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=audRt7fRtaHJAypC2zr5a+4S4wIdbMdzCDcLlozMhh4=; b=YzT7BZE7O+YzUbe2PhtX3FnnobBqB6js0J+OxCMLjboPARC4/2hWWBlfiDqE4pdhw3 ofMm9PrhsqTbj2MvrdjOTxXUVz7B0ykTzq9bRALx0xgFiitLHjFpQTPv0hqq3lKoQukP xQ2WWVPAuXsqYW6vmIflIA/y/MHfCHO4/oEKQqiEOG+WPS/Yb3SFyGq1CdBKOHJwjJNo JVEaCEsWc8DhEAbV4MNCsTtdPOqUV50KeIn3cbLTVutqaJWHD4vJ6FIvtrgrzAyLhqdo JgUAFww9ixlquglUXvppvpnENxXGZFe+zX8SfQzhLdWn3DMbLzk4sA3aXVrmBKna4Hwo pnYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720409179; x=1721013979; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=audRt7fRtaHJAypC2zr5a+4S4wIdbMdzCDcLlozMhh4=; b=roxw8CKcah90AXWfXahezx9ioq4ekYm6sZUOiMNP2DVijpGECaCmPEJsbu7ui0JuRy 8TRqZpiEuwsW+wBuyDU8ihNApW1B7AnkD52baFH8ytfSFgAR9XAGN8iNwjFkuVDIDVNE +Awpq4Cuam8NPf6S+BHV8k7NvVZ3Q4gD7fmINLgpUe3mQeHxnWRoIT5z+H9m4ix9uwn4 ewk21CgPZlL1a2uXBGqIQJ8X4lee2Q7tHUSlVnM669Z30AHkpKk/Y2twUno5tt8gcPAp LpevIrg/vULNCnRsbEkDhEOnn74vxE7jJJQysh1/Nbm43DnSIFz4b6pYPvUPwW5txY4+ cWHQ== X-Forwarded-Encrypted: i=1; AJvYcCWj5KL9hNzTq0nl2Qt4/mH/7qb1h3Sc/gXBpe+WHQAP3pwPGHCoqRoTXiEgfujoKQX+HXcEt7yufdgOw36sM3cGckztilpT7TYzdw== X-Gm-Message-State: AOJu0YyyzKnIwQam/WjFN5Zf3CTBCZQc/UbP+2upzYN+Ujb3R5LlmqVC 2gd1fCcNUNit5nnvVNEjuk80V0EeVmeO54/bXgtFtz0zurC3dkuS X-Google-Smtp-Source: AGHT+IG+2Gcn8gUnXGjIKywglOyw9EqNs/vCXMEJJAFf7vVhUrPwC7pbEdy+yuVlxkaZ/JNZNTg/4w== X-Received: by 2002:a17:903:41ce:b0:1fa:2b11:657d with SMTP id d9443c01a7336-1fb37037269mr158055285ad.10.1720409178554; Sun, 07 Jul 2024 20:26:18 -0700 (PDT) Original-Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-1fb2b1e60a4sm72927795ad.235.2024.07.07.20.26.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 07 Jul 2024 20:26:18 -0700 (PDT) Content-Language: en-US In-Reply-To: <875xtyyjcv.fsf@gmx.de> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288578 Archived-At: On 6/23/2024 10:56 PM, Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote: > Jim Porter writes: > >> I'll think about this some more and see if we can get all the checks >> we want without making the code slower over Tramp. (Maybe Tramp caches >> enough that this isn't a problem, but I'm not certain yet.) > > If Eshell calls `process-file', it shall bind `process-file-side-effects' > to nil if appropriate for the given command. > > Furthermore, Eshell might bind `remote-file-name-inhibit-cache' to > something which helps. The default value (10) seems to be very conservative. After looking into this, it turns out Eshell doesn't look for a shebang on remote files (a comment in 'eshell-connection-local-command' claims that it doesn't work with Tramp syntax, but I'm not sure that's actually correct...). I've therefore merged the "B" variant of my patch to emacs-30 (as commit 130c3efa108) that checks for zero size on the file. I thought about it and this way seemed safer, since I'm not sure what other scenarios might signal a 'file-error', and I'd rather not suppress something I shouldn't: better for a user to file another bug in that case so we can evaluate it, I think. Closing this bug now. (Though of course let me know if I've missed anything here.)