From: Jim Porter <jporterbugs@gmail.com>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: Eli Zaretskii <eliz@gnu.org>,
71655-done@debbugs.gnu.org, james@literate-devops.io
Subject: bug#71655: Eshell external commands do not work under GNU Emacs for Windows
Date: Sun, 7 Jul 2024 20:26:17 -0700 [thread overview]
Message-ID: <ccdaca10-ba36-a6fd-527f-4f8078583898@gmail.com> (raw)
In-Reply-To: <875xtyyjcv.fsf@gmx.de>
On 6/23/2024 10:56 PM, Michael Albinus via Bug reports for GNU Emacs,
the Swiss army knife of text editors wrote:
> Jim Porter <jporterbugs@gmail.com> writes:
>
>> I'll think about this some more and see if we can get all the checks
>> we want without making the code slower over Tramp. (Maybe Tramp caches
>> enough that this isn't a problem, but I'm not certain yet.)
>
> If Eshell calls `process-file', it shall bind `process-file-side-effects'
> to nil if appropriate for the given command.
>
> Furthermore, Eshell might bind `remote-file-name-inhibit-cache' to
> something which helps. The default value (10) seems to be very conservative.
After looking into this, it turns out Eshell doesn't look for a shebang
on remote files (a comment in 'eshell-connection-local-command' claims
that it doesn't work with Tramp syntax, but I'm not sure that's actually
correct...).
I've therefore merged the "B" variant of my patch to emacs-30 (as commit
130c3efa108) that checks for zero size on the file. I thought about it
and this way seemed safer, since I'm not sure what other scenarios might
signal a 'file-error', and I'd rather not suppress something I
shouldn't: better for a user to file another bug in that case so we can
evaluate it, I think.
Closing this bug now. (Though of course let me know if I've missed
anything here.)
next prev parent reply other threads:[~2024-07-08 3:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 15:53 bug#71655: Eshell external commands do not work under GNU Emacs for Windows James Hilling via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-19 19:12 ` Eli Zaretskii
2024-06-19 19:22 ` Eli Zaretskii
2024-06-19 19:40 ` Jim Porter
2024-06-20 4:53 ` Eli Zaretskii
2024-06-20 5:34 ` Jim Porter
2024-06-20 7:45 ` Eli Zaretskii
2024-06-22 19:55 ` Jim Porter
2024-06-23 4:36 ` Eli Zaretskii
2024-06-24 1:40 ` Jim Porter
2024-06-24 5:56 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-08 3:26 ` Jim Porter [this message]
2024-07-08 11:09 ` Eli Zaretskii
2024-06-19 19:30 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ccdaca10-ba36-a6fd-527f-4f8078583898@gmail.com \
--to=jporterbugs@gmail.com \
--cc=71655-done@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=james@literate-devops.io \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.