Re: master e776df2a3ea: help-setup-xref: Keep the local values only of some variables

Re: master e776df2a3ea: help-setup-xref: Keep the local values only of some variables

[Andrea Corallo]

Dmitry Gutov <dgutov@yandex.ru> writes:

> branch: master
> commit e776df2a3eae0454ea85287e15ebba649bf8e918
> Author: Dmitry Gutov <dmitry@gutov.dev>
> Commit: Dmitry Gutov <dmitry@gutov.dev>
>
>     help-setup-xref: Keep the local values only of some variables
>
>     * lisp/help-mode.el (help-setup-xref): Kill all local variables,
>     saving ones that are known to need to be preserved (bug#73637).

Hello Dmitry,

I see this change is introducing the following for me on master:

FAILED  package-test-signed
FAILED  package-test-describe-package
FAILED  package-test-describe-non-installed-package
FAILED  package-test-describe-non-installed-multi-file-package
FAILED  package-test-describe-installed-multi-file-package
FAILED  31/37  package-test-signed (1.591804 sec) at lisp/emacs-lisp/package-tests.el:771
FAILED   7/37  package-test-describe-package (0.004512 sec) at lisp/emacs-lisp/package-tests.el:698
FAILED   6/37  package-test-describe-non-installed-package (0.409124 sec) at lisp/emacs-lisp/package-tests.el:744
FAILED   5/37  package-test-describe-non-installed-multi-file-package (0.538978 sec) at lisp/emacs-lisp/package-tests.el:757
FAILED   4/37  package-test-describe-installed-multi-file-package (0.544010 sec) at lisp/emacs-lisp/package-tests.el:730
FAILED  help-mode-tests-follow-symbol
FAILED  help-mode-tests-do-xref
FAILED   2/15  help-mode-tests-follow-symbol (0.040801 sec) at lisp/help-mode-tests.el:154
FAILED   1/15  help-mode-tests-do-xref (0.080359 sec) at lisp/help-mode-tests.el:147
FAILED  erc-nicks-list-faces
FAILED  16/16  erc-nicks-list-faces (0.045369 sec) at lisp/erc/erc-nicks-tests.el:387

Would you mind having a look?

Thanks

  Andrea

Re: master e776df2a3ea: help-setup-xref: Keep the local values only of some variables

[Dmitry Gutov]

Hi Andrea,

On 08/10/2024 12:47, Andrea Corallo wrote:

>> branch: master
>> commit e776df2a3eae0454ea85287e15ebba649bf8e918
>> Author: Dmitry Gutov <dmitry@gutov.dev>
>> Commit: Dmitry Gutov <dmitry@gutov.dev>
>>
>>      help-setup-xref: Keep the local values only of some variables
>>
>>      * lisp/help-mode.el (help-setup-xref): Kill all local variables,
>>      saving ones that are known to need to be preserved (bug#73637).
> 
> Hello Dmitry,
> 
> I see this change is introducing the following for me on master

Sorry about that.

Hopefully this won't result in digging in much further, but I've pushed 
revision ef87ce0ffae now that fixes the tests locally, at least.

> FAILED  package-test-signed
> FAILED  package-test-describe-package
> FAILED  package-test-describe-non-installed-package
> FAILED  package-test-describe-non-installed-multi-file-package
> FAILED  package-test-describe-installed-multi-file-package
> FAILED  31/37  package-test-signed (1.591804 sec) at lisp/emacs-lisp/package-tests.el:771
> FAILED   7/37  package-test-describe-package (0.004512 sec) at lisp/emacs-lisp/package-tests.el:698
> FAILED   6/37  package-test-describe-non-installed-package (0.409124 sec) at lisp/emacs-lisp/package-tests.el:744
> FAILED   5/37  package-test-describe-non-installed-multi-file-package (0.538978 sec) at lisp/emacs-lisp/package-tests.el:757
> FAILED   4/37  package-test-describe-installed-multi-file-package (0.544010 sec) at lisp/emacs-lisp/package-tests.el:730
> FAILED  help-mode-tests-follow-symbol
> FAILED  help-mode-tests-do-xref
> FAILED   2/15  help-mode-tests-follow-symbol (0.040801 sec) at lisp/help-mode-tests.el:154
> FAILED   1/15  help-mode-tests-do-xref (0.080359 sec) at lisp/help-mode-tests.el:147
> FAILED  erc-nicks-list-faces
> FAILED  16/16  erc-nicks-list-faces (0.045369 sec) at lisp/erc/erc-nicks-tests.el:387

Re: master e776df2a3ea: help-setup-xref: Keep the local values only of some variables

[Andrea Corallo]

Dmitry Gutov <dmitry@gutov.dev> writes:

> Hi Andrea,
>
> On 08/10/2024 12:47, Andrea Corallo wrote:
>
>>> branch: master
>>> commit e776df2a3eae0454ea85287e15ebba649bf8e918
>>> Author: Dmitry Gutov <dmitry@gutov.dev>
>>> Commit: Dmitry Gutov <dmitry@gutov.dev>
>>>
>>>      help-setup-xref: Keep the local values only of some variables
>>>
>>>      * lisp/help-mode.el (help-setup-xref): Kill all local variables,
>>>      saving ones that are known to need to be preserved (bug#73637).
>> Hello Dmitry,
>> I see this change is introducing the following for me on master
>
> Sorry about that.
>
> Hopefully this won't result in digging in much further, but I've
> pushed revision ef87ce0ffae now that fixes the tests locally, at
> least.

Thanks my test bed is clean now.

  Andrea