From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#62720: 29.0.60; Not easy at all to upgrade :core packages like Eglot Date: Wed, 12 Apr 2023 18:45:01 +0300 Message-ID: References: <87a5zj2vfo.fsf@gmail.com> <87wn2modrm.fsf@posteo.net> <87ile6o2ov.fsf@posteo.net> <87y1mz38rl.fsf@posteo.net> <87ile2n0kn.fsf@gmail.com> <83v8i2abqi.fsf@gnu.org> <87wn2ilgx7.fsf@gmail.com> <83a5ze9uc1.fsf@gnu.org> <831qkq9rpy.fsf@gnu.org> <83pm898xb9.fsf@gnu.org> <87h6tlleg0.fsf@gmail.com> <8335558qc7.fsf@gnu.org> <83sfd5761f.fsf@gnu.org> <87zg7djrgr.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31022"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Cc: philipk@posteo.net, larsi@gnus.org, 62720@debbugs.gnu.org, monnier@iro.umontreal.ca To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Apr 12 17:46:14 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pmcfl-0007t1-UH for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 12 Apr 2023 17:46:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pmcfc-0002dI-MQ; Wed, 12 Apr 2023 11:46:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pmcfb-0002cH-20 for bug-gnu-emacs@gnu.org; Wed, 12 Apr 2023 11:46:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pmcfa-0003cJ-PH for bug-gnu-emacs@gnu.org; Wed, 12 Apr 2023 11:46:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pmcfa-0005Qo-8A for bug-gnu-emacs@gnu.org; Wed, 12 Apr 2023 11:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Apr 2023 15:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62720 X-GNU-PR-Package: emacs Original-Received: via spool by 62720-submit@debbugs.gnu.org id=B62720.168131431320790 (code B ref 62720); Wed, 12 Apr 2023 15:46:02 +0000 Original-Received: (at 62720) by debbugs.gnu.org; 12 Apr 2023 15:45:13 +0000 Original-Received: from localhost ([127.0.0.1]:40970 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pmcem-0005PF-IE for submit@debbugs.gnu.org; Wed, 12 Apr 2023 11:45:12 -0400 Original-Received: from new2-smtp.messagingengine.com ([66.111.4.224]:50021) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pmcel-0005Ox-8h for 62720@debbugs.gnu.org; Wed, 12 Apr 2023 11:45:11 -0400 Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id 33590581FC5; Wed, 12 Apr 2023 11:45:06 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 12 Apr 2023 11:45:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1681314306; x=1681317906; bh=tvnvvzsu1XvWsA46cN2TcXrOMKfAlC5WvN7 zcovev0s=; b=aHhcuCtOv6vehFJkSncqeSn0U5GH3N5n+hyksxCDNsJUmPpGgOr AWo9GDs1px7bXH6NHruAo9g2ioUtsgiZ+Z6Sn9+NaruX/M+seht5lvL+3pZBwago MCCJSG7LUiS5w6148SOG7/CTATivT9SYKUhdo+l+2ePr2YXYApMRj5r3DkXhnhK/ e/9qJhb6RSs/FmdvE8obAAU4HqaQU3wG8s/d1E3SU3r/uAt4UjIlc/KBhvK/jKJI zWQhHODyra1STCbcyp8bJOSO5/S3kILoggoNZlVnlcIiA6U+MLeiU7VaJN1ymhcv uiBLuR5VEz9bXTb28MH0HVhQpP9qTZzOy7A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1681314306; x=1681317906; bh=tvnvvzsu1XvWsA46cN2TcXrOMKfAlC5WvN7 zcovev0s=; b=iY3kN4Q5E+z3eTehVEomAATb3Uj/bwUO2zXSyLv74Q2YZ5BfMCx Mvz1vpeTIC4csUCeDoRziGKEXi+HeIw3pz6/flKgDZygI5Sx65xJogHB74FyC1ZM 0nvTbNEet17CcPEmG7wvA+dIlbbiX16fXAauXkDROXj5bUTU4JmH9RUZmy7ZgnsL CwKZ0lq2ucr8flkOGHoWGUP7nx53mqdj9jOcZ57+Hb8+aen/yt6bFj3QrCtJAa+N +i9fffrXLzUbbCghH0jzApLC/h4T2mKAgSWg9LxwrP3SBQqEaxdIxXr3VQ4U+PLW mw6hqQDidcDkbCPUaCyx7eizJnE7RJNbd2A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdekiedgleefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtkeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhephfffheeljeffgeffueeghfekkedtfffgheejvdegjeettdduheeufffggfef jeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 12 Apr 2023 11:45:03 -0400 (EDT) Content-Language: en-US In-Reply-To: <87zg7djrgr.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:259772 Archived-At: On 12/04/2023 14:00, João Távora wrote: > Eli Zaretskii writes: > >> the restrictions. What else can I say to express clearly that I would >> like such a command to not be installed? > Had another idea: what about this very tiny patch, then? It makes `M-x > package-install` work for installing a :core package. This also rhymes > exactly with Stefan's intution/feeling that :core packages need to be > "installed" to promote them to installable. The current M-x > package-install recommendation could remain flawlessly and then you can > do whatever you think is best for M-x package-update & friends. > > diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el > index f92afe56b76..134505a96af 100644 > --- a/lisp/emacs-lisp/package.el > +++ b/lisp/emacs-lisp/package.el > @@ -2164,8 +2164,10 @@ package-installed-p > (and pkg-descs > (version-list-<= min-version > (package-desc-version (car pkg-descs))))) > - ;; Also check built-in packages. > - (package-built-in-p package min-version))))) > + ;; Also check built-in packages. But if min-version is nil, just > + ;; act as if a package-desc had been passed (bug#62720) > + (and min-version (package-built-in-p package min-version)))))) > > (defun package-download-transaction (packages) > "Download and install all the packages in PACKAGES. If the package becomes "mass-upgradable" afterwards, this seems like the best solution, behavior-wise (imminent 29 release aside, of course). Does 'M-x package-update/upgrade' get fixed automatically with this, or does it need separate changes?