From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Mendler Newsgroups: gmane.emacs.devel Subject: Re: Caching where-is-internal Date: Mon, 24 May 2021 22:07:02 +0200 Message-ID: References: <87zgwlb4xc.fsf@gmail.com> <87eedxrqz4.fsf@mail.linkov.net> <5213fac0-fcc9-a6aa-0a16-a124d9ec92bc@daniel-mendler.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25936"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org, =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= , Juri Linkov To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon May 24 22:07:59 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1llGrm-0006Tr-J9 for ged-emacs-devel@m.gmane-mx.org; Mon, 24 May 2021 22:07:58 +0200 Original-Received: from localhost ([::1]:47570 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1llGrl-000242-Ce for ged-emacs-devel@m.gmane-mx.org; Mon, 24 May 2021 16:07:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60560) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llGqz-0001On-Vc for emacs-devel@gnu.org; Mon, 24 May 2021 16:07:09 -0400 Original-Received: from server.qxqx.de ([2a01:4f8:121:346::180]:51025 helo=mail.qxqx.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llGqx-0000J5-DO for emacs-devel@gnu.org; Mon, 24 May 2021 16:07:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=iuCi6+HiCFotLJcB7Ulfs3XnCFhIvFKC5DQkQQoMgJM=; b=NLTeorNZ6HYDtZupkK4uLjqC2w at4BHpph7Eyq1x5P5MMeSRdRriR/LwLYntDM0x8bdRELh6XGFhwTG2kVmCU3LV5qOV3Qxxx4MSDWE NyAPgd2rMDZKmDFdruRYHgRObjnDsWdt6VMIRMxpCdDJvPx62DJXRbAh0Ucb/mw3n9Go=; In-Reply-To: Content-Language: en-US Received-SPF: pass client-ip=2a01:4f8:121:346::180; envelope-from=mail@daniel-mendler.de; helo=mail.qxqx.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269803 Archived-At: On 5/24/21 9:53 PM, Stefan Monnier wrote: >> The funny thing here is that the initial (costly?) computation of the >> `marginalia--annotate-binding-hash` does not lead to a noticeable slowdown. > > The first call to `where-is-internal` will traverse all the keymaps and > build the hash-table (which doesn't cost much more than just a plain > uncached `where-is-internal`), and the subsequent ones will hit the > hash-table instead. This makes sense. Thanks. Then we have to figure out why this spurious cache flush happens. At the time when I wrote this code I should have reported the issue right away or investigated a bit more deeply. It is good to revisit this now in the light of the current discussion. Daniel