From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chaoyi Newsgroups: gmane.emacs.bugs Subject: Re: bug#4736: 23.1; ns-antialias-text set to nil has no effect Date: Wed, 11 Nov 2009 22:34:57 -0800 (PST) Organization: http://groups.google.com Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1258144511 15291 80.91.229.12 (13 Nov 2009 20:35:11 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 13 Nov 2009 20:35:11 +0000 (UTC) To: bug-gnu-emacs@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 13 21:35:04 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1N92rI-0000fZ-3y for geb-bug-gnu-emacs@m.gmane.org; Fri, 13 Nov 2009 21:35:04 +0100 Original-Received: from localhost ([127.0.0.1]:44015 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N92rH-0007Sb-HF for geb-bug-gnu-emacs@m.gmane.org; Fri, 13 Nov 2009 15:35:03 -0500 Original-Path: news.stanford.edu!usenet.stanford.edu!postnews.google.com!j24g2000yqa.googlegroups.com!not-for-mail Original-Newsgroups: gnu.emacs.bug Original-Lines: 38 Original-NNTP-Posting-Host: 132.177.26.92 Original-X-Trace: posting.google.com 1258007697 32378 127.0.0.1 (12 Nov 2009 06:34:57 GMT) Original-X-Complaints-To: groups-abuse@google.com Original-NNTP-Posting-Date: Thu, 12 Nov 2009 06:34:57 +0000 (UTC) Complaints-To: groups-abuse@google.com Injection-Info: j24g2000yqa.googlegroups.com; posting-host=132.177.26.92; posting-account=oeOeJQoAAADjAKjkty31DJB8biSP0b3T User-Agent: G2/1.0 X-HTTP-UserAgent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.1.5) Gecko/20091102 Firefox/3.5.5,gzip(gfe),gzip(gfe) Original-Xref: news.stanford.edu gnu.emacs.bug:60882 X-Mailman-Approved-At: Fri, 13 Nov 2009 15:34:59 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:32587 Archived-At: On Oct 17, 7:16=A0am, Adrian Robert wrote: > http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D4736 > > I cannot reproduce this. =A0You must make a new frame or otherwise =A0 > trigger full redrawing, but it works here. =A0Please experiment a =A0 > little, and if you can narrow down the conditions that cause failure, =A0 > please report back. I confirm this bug with latest CVS version. Attached patch seems fixed this problem. -- diff --git a/src/nsfont.m b/src/nsfont.m index dded6a3..ec52cc8 100644 --- a/src/nsfont.m +++ b/src/nsfont.m @@ -50,7 +50,7 @@ extern Lisp_Object Qnormal, Qbold, Qitalic, Qcondensed, Qexpanded; static Lisp_Object Vns_reg_to_script; static Lisp_Object Qapple, Qroman, Qmedium; extern Lisp_Object Qappend; -extern int ns_antialias_text; +extern Lisp_Object ns_antialias_text; extern float ns_antialias_threshold; extern int ns_tmp_flags; extern struct nsfont_info *ns_tmp_font; @@ -1229,7 +1229,7 @@ nsfont_draw (struct glyph_string *s, int from, int to, int x, int y, CGContextSetFont (gcontext, font->cgfont); CGContextSetFontSize (gcontext, font->size); - if (ns_antialias_text =3D=3D Qnil || font->size <=3D ns_antialias_threshold) + if (NILP (ns_antialias_text) || font->size <=3D ns_antialias_threshold) CGContextSetShouldAntialias (gcontext, 0); else CGContextSetShouldAntialias (gcontext, 1);