Re: bug#4736: 23.1; ns-antialias-text set to nil has no effect

[Chaoyi <chaoyi.yin@gmail.com>]

On Oct 17, 7:16 am, Adrian Robert <adrian.b.rob...@gmail.com> wrote:
> http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=4736
>
> I cannot reproduce this.  You must make a new frame or otherwise  
> trigger full redrawing, but it works here.  Please experiment a  
> little, and if you can narrow down the conditions that cause failure,  
> please report back.

I confirm this bug with latest CVS version.  Attached patch seems
fixed this problem.

--
diff --git a/src/nsfont.m b/src/nsfont.m
index dded6a3..ec52cc8 100644
--- a/src/nsfont.m
+++ b/src/nsfont.m
@@ -50,7 +50,7 @@ extern Lisp_Object Qnormal, Qbold, Qitalic,
Qcondensed, Qexpanded;
 static Lisp_Object Vns_reg_to_script;
 static Lisp_Object Qapple, Qroman, Qmedium;
 extern Lisp_Object Qappend;
-extern int ns_antialias_text;
+extern Lisp_Object ns_antialias_text;
 extern float ns_antialias_threshold;
 extern int ns_tmp_flags;
 extern struct nsfont_info *ns_tmp_font;
@@ -1229,7 +1229,7 @@ nsfont_draw (struct glyph_string *s, int from,
int to, int x, int y,

     CGContextSetFont (gcontext, font->cgfont);
     CGContextSetFontSize (gcontext, font->size);
-    if (ns_antialias_text == Qnil || font->size <=
ns_antialias_threshold)
+    if (NILP (ns_antialias_text) || font->size <=
ns_antialias_threshold)
       CGContextSetShouldAntialias (gcontext, 0);
     else
       CGContextSetShouldAntialias (gcontext, 1);