From: Glenn Morris <rgm@gnu.org>
To: "Fabián Ezequiel Gallina" <fabian@anue.biz>
Cc: 13438@debbugs.gnu.org
Subject: bug#13438: /srv/bzr/emacs/emacs-24 r111196: * imenu.el (imenu-default-create-index-function): Remove useless
Date: Thu, 24 Jan 2013 13:01:17 -0500 [thread overview]
Message-ID: <cbk3r2bguq.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <E1Ty8dP-0000cA-TK@vcs.savannah.gnu.org> ("Fabián Ezequiel Gallina"'s message of "Wed, 23 Jan 2013 18:55:46 -0300")
> * imenu.el (imenu-default-create-index-function): Remove useless
> infinite loop check.
[...]
> --- a/lisp/imenu.el 2013-01-01 09:11:05 +0000
> +++ b/lisp/imenu.el 2013-01-23 21:55:46 +0000
> @@ -683,8 +683,6 @@
> (goto-char (point-max))
> ;; Search for the function
> (while (funcall imenu-prev-index-position-function)
> - (when (= pos (point))
> - (error "Infinite loop at %s:%d: imenu-prev-index-position-function does not move point" (buffer-name) pos))
> (setq pos (point))
> (save-excursion
> (setq name (funcall imenu-extract-index-name-function)))
I'm not keen on removing an infinite loop check from emacs-24 at this
stage. Why is this issue (apparently) only seen in Python mode, and why
isn't there a Python-specific solution (which seems like it would be
just making imenu-prev-index-position-function return nil when
appropriate)?
Related discussion:
http://lists.gnu.org/archive/html/emacs-devel/2013-01/msg00536.html
next parent reply other threads:[~2013-01-24 18:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1Ty8dP-0000cA-TK@vcs.savannah.gnu.org>
2013-01-24 18:01 ` Glenn Morris [this message]
2013-01-24 18:30 ` bug#13438: /srv/bzr/emacs/emacs-24 r111196: * imenu.el (imenu-default-create-index-function): Remove useless Stefan Monnier
2013-01-25 8:34 ` Glenn Morris
2013-01-25 13:55 ` Fabián Ezequiel Gallina
2013-01-27 2:12 ` Glenn Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cbk3r2bguq.fsf@fencepost.gnu.org \
--to=rgm@gnu.org \
--cc=13438@debbugs.gnu.org \
--cc=fabian@anue.biz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.