From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#46459: 28.0.50; Shared keymap for Git VC dir "Branch" header? Date: Sat, 13 Feb 2021 02:50:41 +0200 Message-ID: References: <87a6s94vze.fsf@protesilaos.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38411"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 To: Protesilaos Stavrou , 46459@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 13 01:51:15 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lAj9X-0009sz-4w for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 13 Feb 2021 01:51:15 +0100 Original-Received: from localhost ([::1]:39110 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lAj9W-0001zB-7R for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 12 Feb 2021 19:51:14 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51586) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lAj9K-0001xu-Pj for bug-gnu-emacs@gnu.org; Fri, 12 Feb 2021 19:51:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49925) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lAj9K-0002BG-Ib for bug-gnu-emacs@gnu.org; Fri, 12 Feb 2021 19:51:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lAj9K-0006kY-Hf for bug-gnu-emacs@gnu.org; Fri, 12 Feb 2021 19:51:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 Feb 2021 00:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46459 X-GNU-PR-Package: emacs Original-Received: via spool by 46459-submit@debbugs.gnu.org id=B46459.161317745325928 (code B ref 46459); Sat, 13 Feb 2021 00:51:02 +0000 Original-Received: (at 46459) by debbugs.gnu.org; 13 Feb 2021 00:50:53 +0000 Original-Received: from localhost ([127.0.0.1]:33238 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lAj9B-0006k8-8N for submit@debbugs.gnu.org; Fri, 12 Feb 2021 19:50:53 -0500 Original-Received: from mail-wr1-f46.google.com ([209.85.221.46]:34593) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lAj97-0006js-QS for 46459@debbugs.gnu.org; Fri, 12 Feb 2021 19:50:51 -0500 Original-Received: by mail-wr1-f46.google.com with SMTP id g10so1470577wrx.1 for <46459@debbugs.gnu.org>; Fri, 12 Feb 2021 16:50:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=mlCAZ96FMG6mXR/Xirgosw4sPZi3H1gzQAgWDsbr5XQ=; b=rXoeBUL6boCTQ7hAoLBe2vNFJ9SHxm+M3asypEV8tfYhZdEv+XPuZZEVNmzlFpp/+m KGx4iboqZ0RzmZFu5z45uVD6ToTPffOfpwCXdZRgy6C0Q0X9KCJTuRNFQawbKs+I8mO/ WdewIP5J/qN71x/AdrjeS5LZl8ZxUcXiigrlfZMZpczdnGyewLQQW0I5HwfD0vSVgy4R j14X+iDM4OOuUADefbsj663sviwqNNFlp2rkCWAB3e36Jog8x5PIuIK9AP1MoGK7SZuR y5b2pSr3Vq5d4aaj6SCZH5rQ1eiMJHGI3VvNiUlNggXl98huQB8TAySO5H7ALAzj16vN aLLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=mlCAZ96FMG6mXR/Xirgosw4sPZi3H1gzQAgWDsbr5XQ=; b=CyUjgWUgFP39+1y7MAXvRBvuB+s2hyvXwGGTyT0fiVLTdhivr4R2a172B0YbqRYbId F5Pnmqaw4ceox6ltLCGLCPXO3wtI9yodwk1pwJ5yd8jUbLw3VCZM2Losi7sGHgfz9ROX 4PynBvPTxGpnstzhQFuVd9b9EKJtwiyv04CpP3CUUqKXDBSdp4QlZJ2HV6Z5vqKGE/Uv 0r0FB0VdrHrsj2mxpfe436QTAsKd4CjNfzWHPtJIbCiG1zoZyBkCheoTm//xQ3rUEH05 MOIxlGctIIIjowIAlsp8ORbaoHn0sFTnpQQv8a9fNzc1xN0SvHwwnZ01/2jwz1eJko4Y W/HQ== X-Gm-Message-State: AOAM532ra3yy8kN587q0LT5MIVlLIKXMUQ+eX+R9KgAHij4SnGvkiPRP yVwv5aYcjnzbE1tVQZwo7jzUDK4GGXU= X-Google-Smtp-Source: ABdhPJzS77nmwTNWsAPwiT+0GsQPMLDTOru64o2BK42OcXANA5q0Nxzk8to3FkoJw7CXPiwQ8d5aeQ== X-Received: by 2002:adf:97d3:: with SMTP id t19mr6516760wrb.164.1613177443834; Fri, 12 Feb 2021 16:50:43 -0800 (PST) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id c18sm50260809wmk.0.2021.02.12.16.50.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Feb 2021 16:50:42 -0800 (PST) In-Reply-To: <87a6s94vze.fsf@protesilaos.com> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:199890 Archived-At: Hi! On 12.02.2021 08:54, Protesilaos Stavrou wrote: > In vc-git.el the header for vc-dir stashes is propertized with its own > keymap. This means that while point is over the value of the "Stash:" > header, the specified keymap comes into effect, instead of the main one > for vc-dir. The latter takes effect when point is anywhere but that > header's value. > > Should this principle be applied to the value of the "Branch" header as > well? The attached patch is a proof-of-concept to that end. > > If you believe this is worth doing, what else do you think should go > into such a patch from a usability standpoint? It seems less obviously useful, given that the stashes list allows one to interact with a particular stash (whether it is to view it or delete it), whereas this keymap should only save the user one S-b key sequence, and only if they figure out to move point to the branch name. I don't really object, though, if people like it. Speaking of usability, I guess something that would make this feature more discoverable could help, like a button on top of the branch name, and a menu similar to the stashes' one.