From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#27986: 26.0.50; 'rename-file' can rename files without confirmation Date: Sat, 19 Aug 2017 14:37:13 -0700 Organization: UCLA Computer Science Department Message-ID: References: <61980dde-3d68-7200-e7f4-98f62e410060@cs.ucla.edu> <0e80a1cf-8217-9e9a-a00f-9fdbd6575fc4@cs.ucla.edu> <0a79089f-36ed-8183-a3bf-6cfa32cb9028@cs.ucla.edu> <6dbd21fd-d191-812a-5810-cb4fbcfbcb20@cornell.edu> <0720ef94-7787-94e7-a44d-576ec7f75607@cornell.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1503178700 6196 195.159.176.226 (19 Aug 2017 21:38:20 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 19 Aug 2017 21:38:20 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 Cc: 27986@debbugs.gnu.org To: Ken Brown , Philipp Stephani , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Aug 19 23:38:16 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1djBRV-0000tM-AT for geb-bug-gnu-emacs@m.gmane.org; Sat, 19 Aug 2017 23:38:05 +0200 Original-Received: from localhost ([::1]:37927 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1djBRc-00072m-0k for geb-bug-gnu-emacs@m.gmane.org; Sat, 19 Aug 2017 17:38:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41345) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1djBRV-00072D-91 for bug-gnu-emacs@gnu.org; Sat, 19 Aug 2017 17:38:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1djBRS-0004td-6R for bug-gnu-emacs@gnu.org; Sat, 19 Aug 2017 17:38:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37216) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1djBRS-0004t9-3P for bug-gnu-emacs@gnu.org; Sat, 19 Aug 2017 17:38:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1djBRR-0004RZ-Pe for bug-gnu-emacs@gnu.org; Sat, 19 Aug 2017 17:38:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Aug 2017 21:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27986 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: security Original-Received: via spool by 27986-submit@debbugs.gnu.org id=B27986.150317864116976 (code B ref 27986); Sat, 19 Aug 2017 21:38:01 +0000 Original-Received: (at 27986) by debbugs.gnu.org; 19 Aug 2017 21:37:21 +0000 Original-Received: from localhost ([127.0.0.1]:45897 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1djBQn-0004Pj-K5 for submit@debbugs.gnu.org; Sat, 19 Aug 2017 17:37:21 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:44246) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1djBQm-0004PW-4h for 27986@debbugs.gnu.org; Sat, 19 Aug 2017 17:37:20 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 75FA5160883; Sat, 19 Aug 2017 14:37:14 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id HiBK-QBSp-wr; Sat, 19 Aug 2017 14:37:13 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id B884116088B; Sat, 19 Aug 2017 14:37:13 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 2fE6aHZ3xuCJ; Sat, 19 Aug 2017 14:37:13 -0700 (PDT) Original-Received: from [192.168.1.9] (unknown [47.153.184.153]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 8E1D5160883; Sat, 19 Aug 2017 14:37:13 -0700 (PDT) In-Reply-To: <0720ef94-7787-94e7-a44d-576ec7f75607@cornell.edu> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:135924 Archived-At: Ken Brown wrote: > This is now done. The implementation will appear in the next Cygwin release. > When that release occurs, I'll install something like the attached patch. Thanks. > Question: Is the patch OK as is, or should I make the call to renameat2 > conditional on CYGWIN? In other words, is it safe to assume that renameat2 is > defined on any platform on which RENAME_NOREPLACE is defined but not SYS_renameat2? It should be OK, for the same reason the RENAME_EXCL branch is OK (it assumes renameatx_np). If we run across some future platform where it doesn't work, we can port it then. As far as I know, Cygwin will be the first platform with renameat2 in its C library.