From: Ken Brown <kbrown@cornell.edu>
To: Andy Moreton <andrewjmoreton@gmail.com>, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master cc5325b: Pacify -Wcast-function-type warnings in GCC 8.1
Date: Mon, 20 Aug 2018 10:45:40 -0400 [thread overview]
Message-ID: <cbb794b5-7905-275b-c1ce-943f9654e9c0@cornell.edu> (raw)
In-Reply-To: <vz1pnydazpb.fsf@gmail.com>
On 8/20/2018 10:18 AM, Andy Moreton wrote:
> On Mon 20 Aug 2018, Ken Brown wrote:
>
>> On 8/17/2018 10:31 AM, Eli Zaretskii wrote:
>>> branch: master
>>> commit cc5325b0bea13bd93478fcee0b035877b3a72290
>>> Author: Andy Moreton <andrewjmoreton@gmail.com>
>>> Commit: Eli Zaretskii <eliz@gnu.org>
>>>
>>> Pacify -Wcast-function-type warnings in GCC 8.1
>>> * src/w32.h: (get_proc_addr): New function.
>>> * src/w32fns.c (setup_w32_kbdhook, Ffile_system_info)
>>> * src/w32uniscribe.c (syms_of_w32uniscribe): Use get_proc_addr.
>>
>> This breaks the Cygwin-w32 build because w32fns.c and w32uniscribe.c don't
>> include w32.h on Cygwin, so get_proc_addr is undefined. Could the definition
>> of get_proc_addr be moved to a different header that gets included in the
>> Cygwin build? Maybe w32common.h?
>
> Sorry Ken, I forgot to test this Cygwin as well as mingw32 and mingw64.
> Does something like this patch work for you ?
Yes, that fixes it.
Thanks.
Ken
next prev parent reply other threads:[~2018-08-20 14:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180817143134.25638.77810@vcs0.savannah.gnu.org>
[not found] ` <20180817143136.6E89A209C7@vcs0.savannah.gnu.org>
2018-08-20 13:29 ` [Emacs-diffs] master cc5325b: Pacify -Wcast-function-type warnings in GCC 8.1 Ken Brown
2018-08-20 14:18 ` Andy Moreton
2018-08-20 14:45 ` Ken Brown [this message]
2018-08-20 21:07 ` Ken Brown
2018-08-20 14:57 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cbb794b5-7905-275b-c1ce-943f9654e9c0@cornell.edu \
--to=kbrown@cornell.edu \
--cc=andrewjmoreton@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.