From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#35406: Build error for emacsclient on FreeBSD Date: Wed, 24 Apr 2019 17:45:00 -0700 Organization: UCLA Computer Science Department Message-ID: References: <2wa7gfwfj3.fsf@fencepost.gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------1C00DD6B0B758A6504FEBC15" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="34183"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 Cc: Josh Howard To: Glenn Morris , 35406@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Apr 25 02:58:03 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hJSiB-0008kF-KP for geb-bug-gnu-emacs@m.gmane.org; Thu, 25 Apr 2019 02:58:03 +0200 Original-Received: from localhost ([127.0.0.1]:49307 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJSiA-0002pu-KK for geb-bug-gnu-emacs@m.gmane.org; Wed, 24 Apr 2019 20:58:02 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57024) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJShx-0002jO-No for bug-gnu-emacs@gnu.org; Wed, 24 Apr 2019 20:57:50 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJSWX-0001mH-UI for bug-gnu-emacs@gnu.org; Wed, 24 Apr 2019 20:46:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43338) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hJSWX-0001m7-Qt for bug-gnu-emacs@gnu.org; Wed, 24 Apr 2019 20:46:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hJSWX-00081f-Jx for bug-gnu-emacs@gnu.org; Wed, 24 Apr 2019 20:46:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Apr 2019 00:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35406 X-GNU-PR-Package: emacs Original-Received: via spool by 35406-submit@debbugs.gnu.org id=B35406.155615310930784 (code B ref 35406); Thu, 25 Apr 2019 00:46:01 +0000 Original-Received: (at 35406) by debbugs.gnu.org; 25 Apr 2019 00:45:09 +0000 Original-Received: from localhost ([127.0.0.1]:56882 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hJSVh-00080R-G5 for submit@debbugs.gnu.org; Wed, 24 Apr 2019 20:45:09 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:37970) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hJSVf-00080B-BK for 35406@debbugs.gnu.org; Wed, 24 Apr 2019 20:45:08 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id B2A6516183D; Wed, 24 Apr 2019 17:45:01 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id XZRHXIMwmeJl; Wed, 24 Apr 2019 17:45:00 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id E1D9C161844; Wed, 24 Apr 2019 17:45:00 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 97dqAbXiu8mM; Wed, 24 Apr 2019 17:45:00 -0700 (PDT) Original-Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id BAF1216176D; Wed, 24 Apr 2019 17:45:00 -0700 (PDT) Openpgp: preference=signencrypt Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= xsFNBEyAcmQBEADAAyH2xoTu7ppG5D3a8FMZEon74dCvc4+q1XA2J2tBy2pwaTqfhpxxdGA9 Jj50UJ3PD4bSUEgN8tLZ0san47l5XTAFLi2456ciSl5m8sKaHlGdt9XmAAtmXqeZVIYX/UFS 96fDzf4xhEmm/y7LbYEPQdUdxu47xA5KhTYp5bltF3WYDz1Ygd7gx07Auwp7iw7eNvnoDTAl KAl8KYDZzbDNCQGEbpY3efZIvPdeI+FWQN4W+kghy+P6au6PrIIhYraeua7XDdb2LS1en3Ss mE3QjqfRqI/A2ue8JMwsvXe/WK38Ezs6x74iTaqI3AFH6ilAhDqpMnd/msSESNFt76DiO1ZK QMr9amVPknjfPmJISqdhgB1DlEdw34sROf6V8mZw0xfqT6PKE46LcFefzs0kbg4GORf8vjG2 Sf1tk5eU8MBiyN/bZ03bKNjNYMpODDQQwuP84kYLkX2wBxxMAhBxwbDVZudzxDZJ1C2VXujC OJVxq2kljBM9ETYuUGqd75AW2LXrLw6+MuIsHFAYAgRr7+KcwDgBAfwhPBYX34nSSiHlmLC+ KaHLeCLF5ZI2vKm3HEeCTtlOg7xZEONgwzL+fdKo+D6SoC8RRxJKs8a3sVfI4t6CnrQzvJbB n6gxdgCu5i29J1QCYrCYvql2UyFPAK+do99/1jOXT4m2836j1wARAQABzSBQYXVsIEVnZ2Vy dCA8ZWdnZXJ0QGNzLnVjbGEuZWR1PsLBfgQTAQIAKAUCTIByZAIbAwUJEswDAAYLCQgHAwIG FQgCCQoLBBYCAwECH In-Reply-To: <2wa7gfwfj3.fsf@fencepost.gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158215 Archived-At: This is a multi-part message in MIME format. --------------1C00DD6B0B758A6504FEBC15 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Josh Howard wrote: > I'd propose it be switched to eaccess() which should be a synonym on Linux and makes it a bit more portable. Sorry, I messed up. I should have used the POSIX-specified faccessat, which has a Gnulib portability emulation for platforms lacking faccessat. I installed the attached into master; please give it a try. --------------1C00DD6B0B758A6504FEBC15 Content-Type: text/x-patch; name="euidaccess.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="euidaccess.patch" diff --git a/lib-src/emacsclient.c b/lib-src/emacsclient.c index 5871a18ce6..fd56007b15 100644 --- a/lib-src/emacsclient.c +++ b/lib-src/emacsclient.c @@ -1472,7 +1472,7 @@ set_local_socket (char const *server_name) int sockdirnamelen = snprintf (sockdirname, sizeof sockdirname, "/run/user/%"PRIuMAX, id); if (0 <= sockdirnamelen && sockdirnamelen < sizeof sockdirname - && euidaccess (sockdirname, X_OK) == 0) + && faccessat (AT_FDCWD, sockdirname, X_OK, AT_EACCESS) == 0) message (true, ("%s: Should XDG_RUNTIME_DIR='%s' be in the environment?\n" --------------1C00DD6B0B758A6504FEBC15--