From: martin rudalics <rudalics@gmx.at>
To: Alan Mackenzie <acm@muc.de>
Cc: 48674@debbugs.gnu.org, "Iris García" <iris.garcia.desebastian@gmail.com>
Subject: bug#48674: Frames and minibuffer bug
Date: Fri, 28 May 2021 10:26:32 +0200 [thread overview]
Message-ID: <cb011d43-f56e-ae05-1c89-85e69660701e@gmx.at> (raw)
In-Reply-To: <YK/6j33WpYPo7j4b@ACM>
>> Does this mean that the
>
>> Fselect_window (f->selected_window, norecord);
>
>> in do_switch_frame fails? If so, why?
>
> For some values of "fails", yes. When we're in frame F1's minibuffer,
> and do (with-selected-frame F2 (foo)):
> (i) Frame F2 becomes selected.
> (ii) The current window in F1 ceases to be the mini-window, becoming some
> other window.
> (iii) The minibuffer is moved from F1 to F2.
>
> (iv) We evaluate (foo).
>
> (v) Frame F1 becomes selected again.
> (vi) The current window in F1 doesn't revert to being the mini-window.
But why precisely does Fselect_window fail here?
> This is what has preoccupied me over the last few hours. It seems we
> want do_switch_frame to do different things for (i) a "permanent" frame
> switch (e.g. C-x 5 o) and (i) a "temporary" frame switch (e.g.
> with-selected-frame). If the selected window in F1 is the mini-window,
> we want it to select a different window in (i), but stay the same in
> (ii).
Be careful in one additional regard: The display engine calls
Fselect_window too for its own purposes.
>> Are we sure that we want to disallow a function on
>> `minibuffer-setup-hook' to change the selected window? With Emacs 27
>
>
>> (defun foo ()
>> (select-window (frame-first-window)))
>
>> (add-hook 'minibuffer-setup-hook 'foo)
>
>
>> works without any problems here.
>
> Are you sure? For me, that setup makes C-x C-f open a minibuffer, but
> leave point in the same window, not the miniwindow. That was a quick try
> with the emacs-27 branch, not Emacs 27.{1,2}, and was on a GUI.
Yes. But this is an effect the user/application might want - explicitly
select some other window to, for example (I'm purely speculating), select
a completion window right away. Iris OTOH never wants to select another
window explicitly.
> I think we should disallow selecting windows in minibuffer-setup-hook.
> This hook is run after the mini-window has been selected in read_minibuf,
> just before the recursive edit.
We cannot disallow it. We can only undo its effect. And that would
constitute an incompatible change - do you really want to go for it?
martin
next prev parent reply other threads:[~2021-05-28 8:26 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 11:23 bug#48674: Frames and minibuffer bug Iris García
2021-05-26 17:45 ` martin rudalics
2021-05-27 10:34 ` Alan Mackenzie
2021-05-27 16:33 ` martin rudalics
2021-05-27 19:56 ` Iris García
2021-05-28 8:25 ` martin rudalics
2021-05-28 9:34 ` Iris García
2021-05-28 9:51 ` martin rudalics
2021-05-31 16:36 ` Alan Mackenzie
2021-06-01 11:29 ` Iris García
2021-05-27 20:01 ` Alan Mackenzie
2021-05-28 8:26 ` martin rudalics [this message]
2021-05-28 17:15 ` Alan Mackenzie
2021-05-28 20:14 ` Alan Mackenzie
2021-05-29 9:20 ` martin rudalics
2021-05-29 13:10 ` Alan Mackenzie
2021-05-29 15:12 ` martin rudalics
2021-05-29 15:24 ` Eli Zaretskii
2021-05-29 17:00 ` Alan Mackenzie
2021-05-30 13:58 ` Alan Mackenzie
2021-05-31 7:55 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb011d43-f56e-ae05-1c89-85e69660701e@gmx.at \
--to=rudalics@gmx.at \
--cc=48674@debbugs.gnu.org \
--cc=acm@muc.de \
--cc=iris.garcia.desebastian@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.