From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 100e339: Update from gnulib Date: Mon, 26 Feb 2018 18:51:45 -0500 Message-ID: References: <20180201172143.17217.47676@vcs0.savannah.gnu.org> <20180201172144.5A58620856@vcs0.savannah.gnu.org> <1cfd41ac-dd78-db94-8213-56dfc046bad2@cs.ucla.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1519689011 13154 195.159.176.226 (26 Feb 2018 23:50:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 26 Feb 2018 23:50:11 +0000 (UTC) User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 Cc: Bruno Haible To: Paul Eggert , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Feb 27 00:50:06 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eqSX0-000385-Ix for ged-emacs-devel@m.gmane.org; Tue, 27 Feb 2018 00:50:06 +0100 Original-Received: from localhost ([::1]:33924 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eqSZ3-0007Ta-2g for ged-emacs-devel@m.gmane.org; Mon, 26 Feb 2018 18:52:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46680) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eqSYu-0007Sy-GA for emacs-devel@gnu.org; Mon, 26 Feb 2018 18:52:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eqSYq-0007GW-Iy for emacs-devel@gnu.org; Mon, 26 Feb 2018 18:52:04 -0500 Original-Received: from limerock03.mail.cornell.edu ([128.84.13.243]:54014) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eqSYq-0007Fn-ER for emacs-devel@gnu.org; Mon, 26 Feb 2018 18:52:00 -0500 X-CornellRouted: This message has been Routed already. Original-Received: from authusersmtp.mail.cornell.edu (granite4.serverfarm.cornell.edu [10.16.197.9]) by limerock03.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id w1QNptd3001121; Mon, 26 Feb 2018 18:51:56 -0500 Original-Received: from [192.168.0.15] (mta-68-175-129-7.twcny.rr.com [68.175.129.7] (may be forged)) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id w1QNplhb014573 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Mon, 26 Feb 2018 18:51:55 -0500 In-Reply-To: <1cfd41ac-dd78-db94-8213-56dfc046bad2@cs.ucla.edu> Content-Language: en-US X-PMX-Cornell-Gauge: Gauge=XXXXX X-PMX-CORNELL-AUTH-RESULTS: dkim-out=none; X-MIME-Autoconverted: from 8bit to quoted-printable by limerock03.mail.cornell.edu id w1QNptd3001121 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 128.84.13.243 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:223101 Archived-At: On 2/26/2018 6:26 PM, Paul Eggert wrote: > On 02/26/2018 12:25 PM, Ken Brown wrote: >> On 2/1/2018 12:21 PM, Paul Eggert wrote: >>> +# if defined __CYGWIN__ >>> +/* The 'environ' variable is defined in a DLL. Therefore its=20 >>> declaration needs >>> +=C2=A0=C2=A0 the '__declspec(dllimport)' attribute, but the system's= =20 >>> lacks it. >>> +=C2=A0=C2=A0 This leads to a link error on 64-bit Cygwin when the op= tion >>> +=C2=A0=C2=A0 -Wl,--disable-auto-import is in use.=C2=A0 */ >>> +_GL_EXTERN_C __declspec(dllimport) char **environ; >>> +# endif >> >> This breaks the build on 32-bit Cygwin.=C2=A0 The build fails as follo= ws: >> >> =C2=A0 CCLD=C2=A0=C2=A0=C2=A0=C2=A0 make-docfile.exe >> /tmp/ccZciFa6.o: In function `main': >> /home/kbrown/src/emacs/i686/lib-src/../../master/lib-src/emacsclient.c= :1740:=20 >> undefined reference to `_imp__environ' >> collect2: error: ld returned 1 exit status >> >> Bruno is aware of the issue; I first noticed it while building clisp=20 >> and reported it there.=C2=A0 But I thought I should report it here too= in=20 >> case others bump into it.=20 >=20 > Thanks for the heads-up. Does the attached patch fix the problem for=20 > you? If so, I can install it until Bruno comes up with something better. Yes, thanks. Ken