From: Heime <heimeborgia@protonmail.com>
To: Thibaut Verron <thibaut.verron@gmail.com>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>, help-gnu-emacs@gnu.org
Subject: Re: Introducing face in comments for various modes
Date: Mon, 12 Dec 2022 14:46:49 +0000 [thread overview]
Message-ID: <cOEuAEc8V38FSfO--55z_dCgQ8jdUBbBz0IZPUNhLwFAoYkW8tg2QLcqAk7f4tVnOI8Qm5YfhtbpGEYLcpiKT7WUQ51fjTXhmdz9O4BbwBY=@protonmail.com> (raw)
In-Reply-To: <2aa0cf5a-c324-6b44-6247-6a20f0be3981@gmail.com>
Returning back to the code presented. Do you know how I could use a generic variable for the different programming languages for the comment character ? So I won't have to hardwire ";;" inside the regex.
------- Original Message -------
On Monday, December 12th, 2022 at 12:17 PM, Thibaut Verron <thibaut.verron@gmail.com> wrote:
> On 12/12/2022 12:55, Heime wrote:
>
> > ------- Original Message -------
> > On Monday, December 12th, 2022 at 10:50 AM, Thibaut Verron thibaut.verron@gmail.com wrote:
> >
> > > On 12/12/2022 11:20, Heime wrote:
> > >
> > > > ------- Original Message -------
> > > > On Monday, December 12th, 2022 at 9:58 AM, Thibaut Verronthibaut.verron@gmail.com wrote:
> > > >
> > > > > On 12/12/2022 10:21, Heime wrote:
> > > > >
> > > > > > ------- Original Message -------
> > > > > > On Monday, December 12th, 2022 at 8:49 AM, Thibaut Verron
> > > > > > thibaut.verron@gmail.com wrote:
> > > > > >
> > > > > > > Le lun. 12 déc. 2022 à 04:01, Heimeheimeborgia@protonmail.com a
> > > > > > > écrit :
> > > > > > >
> > > > > > > ------- Original Message -------
> > > > > > > On Monday, December 12th, 2022 at 2:24 AM, Heime
> > > > > > > heimeborgia@protonmail.com wrote:
> > > > > > >
> > > > > > > > The colors of the standard themes are chosen with its (light)
> > > > > > > > background in mind. If you change that background, it is not
> > > > > > > > surprising that things fall apart.
> > > > > > > > Choosing colours with a light background in mind is the wrong approach
> > > > > > > > because colours produce far greater visual
> > > > > > > > impact.
> > > > > > > > There is no right or wrong approach, but individual preferences.
> > > > > > > > Standard metrics exist. The Gnu Project like many others, does not
> > > > > > > > want to use them.
> > > > > > > > You're moving the goalpost: the sentence I quoted claimed that "focusing
> > > > > > > > on a light background is the wrong approach".
> > > > > > > > Having worked with modus-themes, it was concluded that there exist greater
> > > > > > > > variations in possibilities with a dark background that with a light one.
>
>
> Great for themes with a black background.
>
> That doesn't make it "wrong" for a theme to have a light background.
>
> > > It's already bad enough now with some packages defining their own faces
> > > without at least inheriting from the standard ones.
> > > Right. My focus has been to provide colours with good metrics so that
> > > people inherit from the standard ones.
>
>
> That's called designing a theme. Aka the current approach. Which you
> have been arguing is wrong.
>
> > > There are currently 5330 packages on Melpa. Do you plan to contact the
> > > authors of all of them individually to get them to implement your
> > > preferred colors?
> > > To start using actual standards. Absolutely, they should learn more and change
> > > their packages.
>
>
> Great. Good luck with that.
>
> On the other hand, the current recommended approach is to inherit from
> existing faces and let theme designers (or users, if they choose to)
> populate those with suitable colors.
>
> No need for package developers to implement standards, no need to learn
> about theme design, no need to change things to accommodate for
> user-preferred colors, and if you have a problem, only one bug report to
> file -- with the theme.
>
> > > > > You shouldn't think of themes as "fixing the default choices"
> > > > > (especially considering that you are the one "breaking" them by
> > > > > insisting to use them with a background they weren't designed for).
> > > > > Their purpose is to implement different choices in a consistent way.
> > > > > Good design in much more important that consistency.
> > > > > It's also much easier to achieve in a consistent system.
> > > > > The argument is to design separately for light and also for dark background.
> > > > > Emacs does have light and dark checks.
>
>
> That's again, moving the point.
>
> Yes, Emacs does have those checks, but it's just a different way of
> providing two themes for light and dark backgrounds. If done for full
> themes, it's only a formal change, between two separate theme
> definitions, or one with interleaved conditionals.
>
> If done for only a subset of faces, leaving the others untouched, it's a
> poor-person's way to try to accommodate everything, but it's imperfect
> and it might be unreadable on themes which are far from the standard
> white or black (not to mention terminal users). For that use-case, it is
> usually preferred to find an existing face to inherit from, trusting the
> theme designers for this face to be rendered in a readable way.
>
next prev parent reply other threads:[~2022-12-12 14:46 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-11 15:35 Introducing face in comments for various modes Heime
2022-12-11 17:40 ` Stefan Monnier via Users list for the GNU Emacs text editor
2022-12-12 2:24 ` Heime
2022-12-12 3:00 ` Heime
2022-12-12 8:49 ` Thibaut Verron
2022-12-12 9:21 ` Heime via Users list for the GNU Emacs text editor
2022-12-12 9:58 ` Thibaut Verron
2022-12-12 10:20 ` Heime
2022-12-12 10:50 ` Thibaut Verron
2022-12-12 11:55 ` Heime
2022-12-12 12:17 ` Thibaut Verron
2022-12-12 14:46 ` Heime [this message]
2022-12-12 15:22 ` Yuri Khan
2022-12-12 15:38 ` Thibaut Verron
2022-12-12 15:55 ` Christopher Dimech
2022-12-12 16:07 ` Christopher Dimech
2022-12-12 17:44 ` Stefan Monnier
2022-12-13 5:20 ` Christopher Dimech
2022-12-12 15:22 ` Stefan Monnier
2022-12-13 7:52 ` Jean Louis
2022-12-13 8:04 ` Heime
2022-12-13 8:30 ` Heime
2022-12-13 9:35 ` Thibaut Verron
2022-12-13 9:46 ` Heime
2022-12-13 10:05 ` Thibaut Verron
2022-12-13 10:24 ` Christopher Dimech
2022-12-13 10:40 ` Heime
2022-12-13 10:45 ` Thibaut Verron
2022-12-13 10:49 ` Heime
2022-12-13 15:00 ` Heime
2022-12-13 12:37 ` Jean Louis
2022-12-13 14:00 ` Heime
2022-12-13 12:36 ` Jean Louis
2022-12-13 13:46 ` Heime
2022-12-13 12:35 ` Jean Louis
2022-12-13 8:17 ` Christopher Dimech
2022-12-13 19:19 ` Jean Louis
2022-12-12 15:20 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='cOEuAEc8V38FSfO--55z_dCgQ8jdUBbBz0IZPUNhLwFAoYkW8tg2QLcqAk7f4tVnOI8Qm5YfhtbpGEYLcpiKT7WUQ51fjTXhmdz9O4BbwBY=@protonmail.com' \
--to=heimeborgia@protonmail.com \
--cc=help-gnu-emacs@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=thibaut.verron@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.