* Re: master a12dccc 3/3: Add more build outputs to .gitignore [not found] ` <20180223015046.01A9C20A22@vcs0.savannah.gnu.org> @ 2018-02-23 6:23 ` Glenn Morris 2018-02-23 14:44 ` [Emacs-diffs] " Stefan Monnier 1 sibling, 0 replies; 5+ messages in thread From: Glenn Morris @ 2018-02-23 6:23 UTC (permalink / raw) To: emacs-devel; +Cc: Daniel Colascione Hi, a lot of this change looks iffy: Daniel Colascione wrote: > commit a12dccc713c3de1c1069ea6b4c173a789bd4a45c > * .gitignore: Add more generated files > +# Miscellaneous build stuf > +build-aux/ What generated files did you find in build-aux? > +lib/.deps > +src/stamp-h.in > +src/stamp-h1 The src/stamp stuff should not be needed for ~ the past year, since http://lists.gnu.org/archive/html/emacs-diffs/2017-03/msg00180.html Maybe you had some very old, stale build files left over in your tree from a long time ago? ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Emacs-diffs] master a12dccc 3/3: Add more build outputs to .gitignore [not found] ` <20180223015046.01A9C20A22@vcs0.savannah.gnu.org> 2018-02-23 6:23 ` master a12dccc 3/3: Add more build outputs to .gitignore Glenn Morris @ 2018-02-23 14:44 ` Stefan Monnier 2018-02-23 19:24 ` Daniel Colascione 1 sibling, 1 reply; 5+ messages in thread From: Stefan Monnier @ 2018-02-23 14:44 UTC (permalink / raw) To: Daniel Colascione; +Cc: emacs-devel > +# Miscellaneous build stuf > +build-aux/ [...] > +lib/.deps > +src/stamp-h.in > +src/stamp-h1 Does our build still generate these? Stefan ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Emacs-diffs] master a12dccc 3/3: Add more build outputs to .gitignore 2018-02-23 14:44 ` [Emacs-diffs] " Stefan Monnier @ 2018-02-23 19:24 ` Daniel Colascione 2018-02-23 19:59 ` Paul Eggert 0 siblings, 1 reply; 5+ messages in thread From: Daniel Colascione @ 2018-02-23 19:24 UTC (permalink / raw) To: Stefan Monnier; +Cc: emacs-devel On 02/23/2018 06:44 AM, Stefan Monnier wrote: >> +# Miscellaneous build stuf >> +build-aux/ > [...] >> +lib/.deps >> +src/stamp-h.in >> +src/stamp-h1 > > Does our build still generate these? > I saw them in my build, but it's fully possible that I just didn't notice that they were stale. I'd been doing most of my work in my pdumper working directory, not the Emacs trunk one. Feel free to revert the .gitignore change if it's actually bogus. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Emacs-diffs] master a12dccc 3/3: Add more build outputs to .gitignore 2018-02-23 19:24 ` Daniel Colascione @ 2018-02-23 19:59 ` Paul Eggert 2018-02-23 20:09 ` Daniel Colascione 0 siblings, 1 reply; 5+ messages in thread From: Paul Eggert @ 2018-02-23 19:59 UTC (permalink / raw) To: Daniel Colascione, Stefan Monnier; +Cc: emacs-devel Yes, this was almost surely just a stale-build issue. I reverted the .gitignore change. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Emacs-diffs] master a12dccc 3/3: Add more build outputs to .gitignore 2018-02-23 19:59 ` Paul Eggert @ 2018-02-23 20:09 ` Daniel Colascione 0 siblings, 0 replies; 5+ messages in thread From: Daniel Colascione @ 2018-02-23 20:09 UTC (permalink / raw) To: Paul Eggert, Stefan Monnier; +Cc: emacs-devel On 02/23/2018 11:59 AM, Paul Eggert wrote: > Yes, this was almost surely just a stale-build issue. I reverted the > .gitignore change. Thanks ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-02-23 20:09 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20180223015044.5283.73201@vcs0.savannah.gnu.org>
[not found] ` <20180223015046.01A9C20A22@vcs0.savannah.gnu.org>
2018-02-23 6:23 ` master a12dccc 3/3: Add more build outputs to .gitignore Glenn Morris
2018-02-23 14:44 ` [Emacs-diffs] " Stefan Monnier
2018-02-23 19:24 ` Daniel Colascione
2018-02-23 19:59 ` Paul Eggert
2018-02-23 20:09 ` Daniel Colascione
Code repositories for project(s) associated with this external index https://git.savannah.gnu.org/cgit/emacs.git https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.